From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 2C8BE191E8; Sat, 07 Sep 2024 16:40:40 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 3E81F191BE; Sat, 07 Sep 2024 16:40:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DMARC_MISSING, RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fout3-smtp.messagingengine.com (fout3-smtp.messagingengine.com [103.168.172.146]) by atuin.qyliss.net (Postfix) with ESMTPS id DE72E19257 for ; Sat, 07 Sep 2024 16:40:33 +0000 (UTC) Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfout.phl.internal (Postfix) with ESMTP id 39D9E138026F; Sat, 7 Sep 2024 12:40:32 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Sat, 07 Sep 2024 12:40:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1725727232; x=1725813632; bh=/8r+rLde9K HgL7JTk4zZY/YjA2JWQtRxuRXmR9tSKpU=; b=B3mW/RMy+0nNmE2RdgTDb8a3QX ShDC8LYFMjeW0x5yzruDki7AbaLROxt4AI89WxezRnayLrCrIRHU8I0cvxxjP/hm nUm8U+r0Fof2sw28L/reU70odc/io2owILthWTgyQ88/MozIxuCZQwGaDj4iuJod PdJaS+Xu7gctUp56/uYWanHnyuxTwdItq7rjyoPq+niNV6V8n3pmX2A8oczadFKj pbWKnbW8nh6AMAJiI0qk0TcydxQ2z1QH0K+0YerRzG3ja9qQIC1IcFIyrqeT0Zbi /KKd2mM3F6g51D9jeHAxLzoenx/7pC1mAHtF/RBof1bAmuGX+0sZIlcfQO9Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1725727232; x=1725813632; bh=/8r+rLde9KHgL7JTk4zZY/YjA2JW QtRxuRXmR9tSKpU=; b=lm4gPjrhHkEiESaRB5xpXqHQ57mYs1c4Aoqcy2O75LRi HiBQQY/fBOJ9y21WCFuif2F9PK4TDLJ8e0RXXpeAtqLpVoCcq23HZ7I/xXnXJmAa FLN1081NDFHJMOSBYJKdRMUdRfzEEs4ial6Nl6bQustEfLtOpUYJWaTUY+tn8vbC hKE26aBkhrpvp9/e/3Jne5DwRqa0HUJF318DSxl4b7gdSUocBod5bq2QYqP5L2Py pOLv2JeYASTKwFUR/VsKsz0rF3FTtxj85tun8R2Ub7QTdYWTEmSyH6n4LBEaDm1L 1JiA0cSr5Hc/AbUNEiwToxPf56he5IbUUSNiphI9Lg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudeifedguddtiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvve fujghffffkgggtsehgtderredttddtnecuhfhrohhmpeetlhihshhsrgcutfhoshhsuceo hhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeeiudffueeilefgtefgtd dttdekkeehkefgheekudefveetgeefiefftedvteeuveenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehhihesrghlhihsshgrrdhishdpnhgspg hrtghpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepshhhhihmvghg rgesshhhhihmvghgrgdrohhrghdruhhkpdhrtghpthhtohepuggvvhgvlhesshhpvggtth hruhhmqdhoshdrohhrgh X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 7 Sep 2024 12:40:31 -0400 (EDT) Received: by sf.qyliss.net (Postfix, from userid 1000) id 1A2A4282552A0; Sat, 07 Sep 2024 18:40:30 +0200 (CEST) From: Alyssa Ross To: Dom Rodriguez Subject: Re: [PATCH v2] crosvm: Rename `--vhost-user-{fs,gpu}` args In-Reply-To: <20240906224329.2336996-1-shymega@shymega.org.uk> References: <20240906224329.2336996-1-shymega@shymega.org.uk> Date: Sat, 07 Sep 2024 18:40:28 +0200 Message-ID: <877cbnfmdf.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Message-ID-Hash: VC5LJUBP3CYPRV4EECBL3EWZJSZGBLYP X-Message-ID-Hash: VC5LJUBP3CYPRV4EECBL3EWZJSZGBLYP X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Dom Rodriguez writes: > crosvm was producing warnings when using `--vhost-user-gpu` and > `--vhost-user-fs`. > > In this commit, I have adjusted the `crosvm` invocations to look > something like `--vhost-user $DEVICE,socket=$PATH`, where `$DEVICE` is, in this case, > `gpu` or `fs`, and `$PATH` is the path to the Unix socket. > > Signed-off-by: Dom Rodriguez > --- > img/app/Makefile | 4 ++-- > release/checks/wayland/default.nix | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/img/app/Makefile b/img/app/Makefile > index 3adf8c4..11ef6e1 100644 > --- a/img/app/Makefile > +++ b/img/app/Makefile > @@ -152,8 +152,8 @@ run-crosvm: $(imgdir)/appvm/blk/root.img start-vhost-user-gpu start-virtiofsd > --disk $(RUN_IMG) \ > -p "console=ttyS0 root=PARTLABEL=root" \ > --net tap-name=tap0 \ > - --vhost-user-fs build/virtiofsd.sock:virtiofs0 \ > - --vhost-user-gpu build/vhost-user-gpu.sock \ > + --vhost-user fs,socket=build/virtiofsd.sock:virtiofs0 \ > + --vhost-user gpu,socket=build/vhost-user-gpu.sock \ > --vsock cid=3 \ > --serial type=file,hardware=serial,path=build/serial.log \ > --serial type=stdout,hardware=virtio-console,stdin=true \ This is still not right, I'm afraid. When I run nix-shell --run 'make clean && make run' VMM=crosvm in img/app, I get this error: [2024-09-07T16:36:32.592274891+00:00 ERROR crosvm] exiting with error 1: failed to connect to vhost-user socket path build/virtiofsd.sock:virtiofs0 Probably the tag should also be a comma-separated key=value option? (This doesn't have any automated test, because it's just part of the development environment, and setting up a test environment to resemble a development machine isn't trivial. Should be possible though.) > diff --git a/release/checks/wayland/default.nix b/release/checks/wayland/default.nix > index d05aa88..a36dbab 100644 > --- a/release/checks/wayland/default.nix > +++ b/release/checks/wayland/default.nix > @@ -29,7 +29,7 @@ nixosTest ({ lib, pkgs, ... }: { > systemd.services.crosvm = { > after = [ "crosvm-gpu.service" "weston.service" ]; > requires = [ "crosvm-gpu.service" "weston.service" ]; > - serviceConfig.ExecStart = "${lib.getExe pkgs.crosvm} run -s /run/crosvm --disk ${appvm}/img/appvm/blk/root.img --disk ${run}/blk/run.img -p \"console=ttyS0 root=PARTLABEL=root\" --vhost-user-gpu /run/crosvm-gpu.sock --vsock cid=3 --serial type=stdout,hardware=virtio-console,stdin=true ${appvm}/img/appvm/vmlinux"; > + serviceConfig.ExecStart = "${lib.getExe pkgs.crosvm} run -s /run/crosvm --disk ${appvm}/img/appvm/blk/root.img --disk ${run}/blk/run.img -p \"console=ttyS0 root=PARTLABEL=root\" --vhost-user gpu,socket=/run/crosvm-gpu.sock --vsock cid=3 --serial type=stdout,hardware=virtio-console,stdin=true ${appvm}/img/appvm/vmlinux"; > serviceConfig.ExecStop = "${lib.getExe pkgs.crosvm} stop /run/crosvm"; > }; This part works now though, thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmbcgfwACgkQ+dvtSFmy ccBS1Q/+Mr4zz0Bvo+WQqvh9CmD0SfsKknTluT9I0X7W/rQ692hUcquys0FW+Tpv +w91yO7VNVq0MDl23PkyJ/kUWtt2A9jIC2Z8SE0e0yWmBeMlE0v0zYuVapFyNmep MA57qgtgFA8pFvQ/RsO8uMUEpkYVGbBUsh8DPm6gxfYU/yK7g+p8mBmqE6SVqvCX Qs14AqdGRTsisGHBVvsFzlTO7rG7Bpyueyo6EJm7sV9/HfhTTOxBB7/8eiLJG3gK zVW6BDFumSj4EximsDWk4kJ398jhpqRkKjMfSCDJhj5Hd/hUcfnvaZYiVEE9gCfe E86rBgt075kBDMusg3hwEf6XXVtJ30V5SCP+VVWo6Yn5FFQ/t5SH6bRwQrqS7X4s NNu5VKgi2swhDPpzhn3/M7EwOxPPQBP0bUMiPWZHnna2TW60y6qmrxlyK4rMyYn3 d2h/idSA5F8gxhG84PBeSzOedz5UFpAn3QAp9pE904JVeDV0fEIO6mLC17HPduZS R+bD9LynjtZ4TL3TuKxwrGyvYE8c2kiUb3qJ7tuKzG6+aumv4hX87G2Mmxn9ReH4 6Z2b/Zx2vHFXsmUpqXMebsnv8EaeDI/JD79x/qjZZYdXq2u5MqKN1BNiAPpR8ItB pZx3xgVSpJ9kQbLUi1pmWH/7iClXclR3OTcEnRXSqxby3256QIA= =5urt -----END PGP SIGNATURE----- --=-=-=--