Re: [PATCH v2] crosvm: Rename `--vhost-user-{fs,gpu}` args

Alyssa Ross
2024-10-21T19:54:09Z

[-- Attachment #1: Type: text/plain, Size: 1670 bytes --]

Alyssa Ross <hi@alyssa.is> writes:

> Dom Rodriguez <shymega@shymega.org.uk> writes:
>
>> On 28.09.2024 16:27, Alyssa Ross wrote:
>>>
>>>You're right! I've just spent the last little while looking around
>>>trying to figure out what's up here, and I think I've figured it out.
>>>
>>>In this commit[1] they made the vhost-user-fs tag optional, because it
>>>can now be set with virtiosfd instead of the VMM. This is probably
>>>good, because the more generic vhost-user becomes, the more hope
>>>Spectrum has of one day not needing Cloud Hypervisor patches. :) So we
>>>could try using --vhost-user fs for crosvm, and then passing --tag to
>>>virtiofsd, but it'd need to be tested with VMM=qemu and
>>>VMM=cloud-hypervisor as well, because I'm not sure whether they support
>>>a backend-provided tag.
>>
>> Oh, that explains *a lot*! I agree, a generic approach would be
>> preferable.
>>
>>>If that's too much work, I'd also be happy to apply just the GPU part of
>>>this patch. Just let me know. :)
>>
>> I've started a new job, and so I've only really got weekends free - and
>> even then, I have Repair Cafes to volunteer at.
>>
>> If I send over the GPU patch only, can you apply that, and then we can
>> discuss on Matrix/IRC the best approach for `vhost-user-fs`? Feel free
>> to tag me - I'm mostly using IRC rightn ow.
>
> SGTM.

BTW: I've just seen this when building release/checks/wayland after
a recent Nixpkgs update:

machine # [ 18.830327] crosvm[987]: [src/crosvm/cmdline.rs:2829] Deprecated disk flags such as --[rw]disk or --[rw]root are passed. Use --block instead.

Just in case you're interested. :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]