From: Alyssa Ross <hi@alyssa.is>
To: Cole Helbling <cole.e.helbling@outlook.com>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH ucspi-vsock] Factor out set_verbosity()
Date: Thu, 18 Mar 2021 13:12:03 +0000 [thread overview]
Message-ID: <877dm4obbw.fsf@alyssa.is> (raw)
In-Reply-To: <SJ0PR03MB55811291F3C6DAC141A58ECAB3699@SJ0PR03MB5581.namprd03.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 344 bytes --]
>> This will save some cognitive load when reading main functions.
>> ---
>> log.c | 20 +++++++++++++++++++-
>> log.h | 5 +++++
>> vsockclient.c | 6 +-----
>> vsockserver.c | 6 +-----
>> 4 files changed, 26 insertions(+), 11 deletions(-)
>
> Yay, refactoring!
>
> Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>
Committed as c2990a9.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2021-03-18 13:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 0:35 [PATCH ucspi-vsock] Factor out set_verbosity() Alyssa Ross
2021-03-18 6:55 ` Cole Helbling
2021-03-18 13:12 ` Alyssa Ross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dm4obbw.fsf@alyssa.is \
--to=hi@alyssa.is \
--cc=cole.e.helbling@outlook.com \
--cc=devel@spectrum-os.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).