From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 137D0A561; Wed, 29 Jul 2026 14:15:58 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 0C36CA544; Wed, 29 Jul 2026 14:15:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fout-b2-smtp.messagingengine.com (fout-b2-smtp.messagingengine.com [202.12.124.145]) by atuin.qyliss.net (Postfix) with ESMTPS id 98E21A4D9 for ; Wed, 29 Jul 2026 14:15:54 +0000 (UTC) Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfout.stl.internal (Postfix) with ESMTP id 15DA71D00161; Wed, 29 Jul 2026 10:15:53 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Wed, 29 Jul 2026 10:15:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1785334552; x=1785420952; bh=KcDvK+FMra 5uvvPTl31AqSBqxe566hIh4htxUucJUxQ=; b=bMzm1TNLc3Ebx9VgfQ9rbS3PVQ V7AEuBV8BCA2+3s3aDnYpp8JEvqoaeGMNAoSJ0kFsVfIHq6cO9skRG2JmzHPWsZZ RmE25tPs/IGkaubuQxE9wHL0cbBvkmffcpMmm71mZdDrftKO9/o5F3mqia4Q19zJ xiG9ipS1fEFf+2yPmNWO3+qMddA45Z0z05G1Apk7ZKvZZmX2p8jBYad8p7IIvCsB +pAzDZh2Hlvx1gVkT+whgHZdYx2uyaqTVbcFcHdipPl315d1ptMhEIzzulfnBF1F vJgD19AYDihokCyPXUws7zayx853sKPvMmC5P4v1jFl5W+RIBkt89guKFKKA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1785334552; x=1785420952; bh=KcDvK+FMra5uvvPTl31AqSBqxe566hIh4ht xUucJUxQ=; b=NDAYF77huxgGBdwQ7CIWInru1HaDNE4VdLYsFuuiI+hdBGLXWS1 6yNWCJHRC3YWLLSOe6zrJaAazyjsRxDshlzSk4lwhsnR3RnBUtD6H58J8maYrbR1 ukKw6ABknYoxFtLr7GSdkTxATUjqbyzh3U+sWM2W0toZnlWAZtplVWCIvBvTYH/Y lNd9EImnG2CZA8+bxFOAYNhpRuCnv61v7hGREQyLXV377a6tWKkFlbsYjR4u26Cu H+CkOztEgb5IyhGB5VjcBN0iwwdF3/P1EhFRHPoS/cSUwpDQabDbweFBawfrYDqi t0mLKNR+WWLTivXoYDgbb3OM2fP7Jd8CmJA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTF2V3fFLKl/4NXTxEZmTDbIhShjyhxF2tZKKaxp7POdVvVLCK2ebSFFNnflzmldjK SvjCg5P/yvhbdjsj6weNttd227Wdw1x4yWRsejVXimH37415/h6gfcvGY4o74KKtBjq1yT sKo5lnPIGoB4ksIWGGKMoLCrXuqS7NBAEMoSwgwiJnbGLvPumUfEXYMHnC/QR9S4HQpQzr JJDDSXXp1PyRmad1kb+E3wSjFFZpByg+y5n19mjTSCST/fgVZQKT+DiIjK0CGjZHqehtb8 1ywqKtkY/s6ksUDuJ69ZRS81+llKFU5fBfhxj+9NFRd1IvRJmK/ntLGMHCK4pW59R1NIPJ ZTx9Nk0+/S/Xzt3+lsh+YC4cJiZ+6hdYh7QgUWx52XUWRy1c5JFQJRAnPzP98V/p7kar/2 PqeAfJ8kSlQ1DJkdebFr7o1pA42cNYcqgHYfpQKZ7gG1jjiYz/GSPLzT1a4Wu4l+SsRVbe FdJT3S/egpRfGB8/hNJf4G2rwwIHbWVN6ARTgZaeH+l6JFgTPjQ/h9vhw5l3P4Gt8Su7RB 6aVkhG5n9kU36lak0Cik+fhSPsFdHSoCcGQpcMJR8PUHAMwIhTESi6w0loKldcReU2myGb PZDg6UvAky0PzgBiK5YVDz/5Aud13QiHDkpNA/Dk9FM2GVbhCKnV5O1FjXDA X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 29 Jul 2026 10:15:52 -0400 (EDT) Received: by fw12.qyliss.net (Postfix, from userid 1000) id 2D83DC4E6FCB; Wed, 29 Jul 2026 16:15:51 +0200 (CEST) From: Alyssa Ross To: Demi Marie Obenour Subject: Re: [PATCH v4 18/20] host/rootfs: systemd-udevd: Run in cgroup In-Reply-To: <3d1541ca-cb50-42f5-a289-697727773725@gmail.com> References: <20260721-cgroups-v4-0-46b2e5fff7b6@gmail.com> <20260721-cgroups-v4-18-46b2e5fff7b6@gmail.com> <87se54k4ir.fsf@alyssa.is> <3d1541ca-cb50-42f5-a289-697727773725@gmail.com> Date: Wed, 29 Jul 2026 16:15:49 +0200 Message-ID: <878q6t6fvu.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: 2IUOPY4D6WRFRYO7XX5VCH7YOVSQVHUP X-Message-ID-Hash: 2IUOPY4D6WRFRYO7XX5VCH7YOVSQVHUP X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Spectrum OS Development X-Mailman-Version: 3.3.10 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Demi Marie Obenour writes: > On 7/27/26 08:20, Alyssa Ross wrote: >> Demi Marie Obenour writes: >>=20 >>> Signed-off-by: Demi Marie Obenour >>> --- >>> host/rootfs/file-list.mk | 1 + >>> host/rootfs/image/etc/s6-rc/systemd-udevd/finish | 5 +++++ >>> host/rootfs/image/etc/s6-rc/systemd-udevd/run | 5 +++-- >>> 3 files changed, 9 insertions(+), 2 deletions(-) >>> >>> diff --git a/host/rootfs/file-list.mk b/host/rootfs/file-list.mk >>> index e3411d40014342e67071a48f9e1c7bc7b3954bcf..065571ef3a5c61fa79a1d2e= d878052a5f391be96 100644 >>> --- a/host/rootfs/file-list.mk >>> +++ b/host/rootfs/file-list.mk >>> @@ -106,6 +106,7 @@ S6_RC_FILES =3D \ >>> image/etc/s6-rc/systemd-udevd-coldplug/dependencies.d/systemd-udevd \ >>> image/etc/s6-rc/systemd-udevd-coldplug/type \ >>> image/etc/s6-rc/systemd-udevd-coldplug/up \ >>> + image/etc/s6-rc/systemd-udevd/finish \ >>> image/etc/s6-rc/systemd-udevd/notification-fd \ >>> image/etc/s6-rc/systemd-udevd/run \ >>> image/etc/s6-rc/systemd-udevd/type \ >>> diff --git a/host/rootfs/image/etc/s6-rc/systemd-udevd/finish b/host/ro= otfs/image/etc/s6-rc/systemd-udevd/finish >>> new file mode 100755 >>> index 0000000000000000000000000000000000000000..4d5b454e97c3584d0644c2d= 738514f13b1c53957 >>> --- /dev/null >>> +++ b/host/rootfs/image/etc/s6-rc/systemd-udevd/finish >>> @@ -0,0 +1,5 @@ >>> +#!/usr/bin/execlineb -WS3 >>> +# SPDX-License-Identifier: EUPL-1.2+ >>> +# SPDX-FileCopyrightText: 2026 Demi Marie Obenour >>> + >>> +cgroup-s6-finish $@ >>> diff --git a/host/rootfs/image/etc/s6-rc/systemd-udevd/run b/host/rootf= s/image/etc/s6-rc/systemd-udevd/run >>> old mode 100644 >>> new mode 100755 >>> index aec6444e951503eae988e666b77fda8f2ae33d72..901f3e6667a8de04a6af399= 45406a1757455f089 >>> --- a/host/rootfs/image/etc/s6-rc/systemd-udevd/run >>> +++ b/host/rootfs/image/etc/s6-rc/systemd-udevd/run >>> @@ -1,7 +1,8 @@ >>> -#!/bin/execlineb -WP >>> +#!/bin/execlineb -WS1 >>> # SPDX-License-Identifier: EUPL-1.2+ >>> # SPDX-FileCopyrightText: 2025 Demi Marie Obenour >>> -s6-setlock /run/sd-notify-wrapper/systemd-udevd.lock >>> + >>> +cgroup-setup --delegate --child-name udev -- $1 >>> s6-ipcserver-socketbinder -b0 -m -a 0600 /run/sd-notify-wrapper/system= d-udevd.sock >>> background -d { >>> fdmove 1 3 >>> >>=20 >> Is there a reason not to always enable delegation? Is there a reason we >> need to set the name here? > > --delegate only sets the user.delegate=3D1 xattr used by systemd. > Programs that are systemd-aware and manage their own cgroups check this > xattr to see if a cgroup has been delegated by systemd. The kernel > and other programs do not care. Right, but why can't we just always set user.delegate=3D1? Would we ever have a program that checked it that we didn't want to manage its own cgroups? > systemd-udevd.service uses the "udev" name, so I decided to also use it > for consistency. Is this the only reason we even need a --child-name feature? If so, it doesn't seem well justified to me unless it actually affects something. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQQGoGac7QfI+H5ZtFCZddwkt31pFQUCamoLFQAKCRCZddwkt31p FR4IAP4xdGWUfN9L4d3brt6un2P7b33e0KpXUjRcpoEkkd7NfQEA1j6xD8NLluM9 G+5nbTE3DZcYYXMMK9t4uEgXZJKDSA4= =73Ck -----END PGP SIGNATURE----- --=-=-=--