From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 3CA689521; Wed, 24 Jun 2026 07:53:40 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 19C4E95AA; Wed, 24 Jun 2026 07:53:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fhigh-b7-smtp.messagingengine.com (fhigh-b7-smtp.messagingengine.com [202.12.124.158]) by atuin.qyliss.net (Postfix) with ESMTPS id 07B4A95A6 for ; Wed, 24 Jun 2026 07:53:35 +0000 (UTC) Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfhigh.stl.internal (Postfix) with ESMTP id 7BA0B7A0081; Wed, 24 Jun 2026 03:53:33 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Wed, 24 Jun 2026 03:53:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1782287613; x=1782374013; bh=rAO/Vlmhp7 i5wxDbGxWxBkBammA16lp/2XrQ68tw4eU=; b=E+83P6k5KBjgFrgffu/MmEVWPe tklITAq5n9SNr9r/Oy5mlhUrrvZthErQXY0j+iQS6Ru8vP+PJUD9GvQaKcCHHrC6 b0jclEm1OEkIQEa1dUg+qtaYMI6mazO7hg7XewqK7V1FkixI5mQQ+EOZLLiaxkeN cgAPBN3mWQGFPRVQ/csiGe21FowZjYbTRx6pieXKc7pMvy4FfsWJPC0O5rXsjr5M 5P7XHH/xVfqj0faVynHgGIqsAFy38eeoUMT6hzozd5fSZDUtu0cwy1NAKVrXy9Kx Y7iWXGXzzXL5R39PMpdwVwURToI08NL/r8EAQi33DDTqLJbYbp2ZYtSX/p5Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1782287613; x=1782374013; bh=rAO/Vlmhp7i5wxDbGxWxBkBammA16lp/2Xr Q68tw4eU=; b=TMntnnjK7C1rhCJAyCi0HsgTrvy9vXkg6QWsQ8SHt4bkCMfiyOE pUflTRmbTw+bdZ5FvaQ6nqTS4hZ4MmNkBsUSKgLmMKvpylXUxAxujOrbHMdfUXsR +pD1ma38gYoi6blpBwGHmfca6/rhvfMKyrPaKDFST50VLJZ29PP5+gWJjvx2zqFf m3bS24+BiPuI4Z5+NiUYIQG47QkST6T6QI9/WgMvQo5erUr+aMmolujV3YZwefnZ qmnrniZQXMx4xcZhRbAKlbDQDVSNqhQUW01K2hiPrfgBSzfnFuHIwFqbL1ptc63u fbyxNetMF4A32ZAoBRQADtf1OIS/Tf5enow== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTEkPeGrLj/ksuOq7m6dsdSr6AQ0AR0y/I1tagr9XalQP0bnms9JjIKHmYXZYZ503d NFFFVXUh8n11z4RjIz2J+DSNkN7cNtgRc30ZvAv9Q441qKJbhzvQA4bWI6cEhGB5Lb9IG0 9xyEmbPKQnFoaMrOHKuEWfznBrmwy0QI16G1xz35MlXd5WltyZadIokQpDPQUJw9Hh/r0v EnmrDGaCfrtPCi8GaO0rzKpN81aAeu+4ZDl/27Mmj/FVLG6Uqrm8utNZy3MSYZnQzyU9K2 qv+lyU9l2De3OSPq81HEkN7fKrMaR4Zxj/aqTkynorMaZdSdQvcyGZU70nxDFMr05RAVO2 +r96ccrei5ZPr4BGg6z3qeYjIpS+jNLUdVJDg7j5YaQB6dvJpxlj96dPba9wj0Yvr2DIEg rTRc4DLYlIvQUN0jBstzH8gE+dvaqCsV50VHwUMCqUrjO/DoBKYD0pljNmkN1CvABNcadz pHFgckkg4NuIOix8y3faWUQgMy1CLck8NHwkdKb0czi12pU9cvy0wDibskqc/B8b7zEqUa tcGclOAIPTLAZz9oUkyE1KeIwDbnkT1q4txAJCZcyMbKTEUgIkeRiW2h410Vri+F5vvqjT vW3PblXotpkqNlN9g//IK4bObROwonOYMscGyKIjOW0ZKoaHf6B/OrqO3jPQ X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 24 Jun 2026 03:53:32 -0400 (EDT) Received: by fw12.qyliss.net (Postfix, from userid 1000) id 821AFB90BCF2; Wed, 24 Jun 2026 09:53:29 +0200 (CEST) From: Alyssa Ross To: Yureka Subject: Re: [PATCH] tools/router: trace unicast packets In-Reply-To: References: <20260619130940.273236-1-hi@alyssa.is> Date: Wed, 24 Jun 2026 09:53:26 +0200 Message-ID: <878q8474sp.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: O7O2C3N3ZD6R5ZTYQK7HMW3HG3IFQK27 X-Message-ID-Hash: O7O2C3N3ZD6R5ZTYQK7HMW3HG3IFQK27 X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.10 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Yureka writes: > On 6/19/26 15:09, Alyssa Ross wrote: >> I found this useful for debugging. >> ("Is it actually sending anything?") >> >> Signed-off-by: Alyssa Ross >> --- >> tools/router/src/router.rs | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/tools/router/src/router.rs b/tools/router/src/router.rs >> index a91e4155..f36866d8 100644 >> --- a/tools/router/src/router.rs >> +++ b/tools/router/src/router.rs >> @@ -11,7 +11,7 @@ use crate::packet::*; >> use crate::protocol::*; >>=20=20=20 >> use futures_util::{FutureExt, Sink, SinkExt, Stream, StreamExt}; >> -use log::{debug, info, warn}; >> +use log::{debug, info, trace, warn}; >> use tokio_stream::StreamMap; >> use vhost_device_net::IncomingPacket; >> use vm_memory::GuestMemory; >> @@ -128,6 +128,7 @@ impl Router { >> .await?; >> } >> ref unicast =3D> { >> + trace!("got unicast packet {:?} -> {:?}", in_iface,= out_iface); >> let Some(sink) =3D self.sinks.get_mut(unicast) els= e { >> warn!("dropped packet because interface is not= ready"); >> continue; >> >> base-commit: 57bf21eaf65ca5a42d18999ba65f96dcd338113c > > In general useful, yes. I think logging on this level could affect=20 > performance (even if disabled at run-time). There is some crate feature=20 > of the log crate to conditionally compile the trace log level for debug=20 > builds. Ah, yes, I saw some other program doing that recently. Will investigate, thanks!. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQQGoGac7QfI+H5ZtFCZddwkt31pFQUCajuM9wAKCRCZddwkt31p FR93AQChu+CF1S2b37nZ5woghVeoYtZwk/CuSjroWG5y5WpJiAEAoSYtQ+3H83Ew uY4ufH3mPlCewuXwLM2YpzSGqUccRAs= =iXlh -----END PGP SIGNATURE----- --=-=-=--