From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 35D168F1A; Sat, 23 May 2026 08:29:10 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 3AF678F10; Sat, 23 May 2026 08:29:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fhigh-b6-smtp.messagingengine.com (fhigh-b6-smtp.messagingengine.com [202.12.124.157]) by atuin.qyliss.net (Postfix) with ESMTPS id 4D1E18F0D for ; Sat, 23 May 2026 08:29:06 +0000 (UTC) Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfhigh.stl.internal (Postfix) with ESMTP id D1FE87A009B; Sat, 23 May 2026 04:29:04 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Sat, 23 May 2026 04:29:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1779524944; x=1779611344; bh=DGyUBUhAFj jyYhJHzmAAh8y3nVxhfkQEV8SWUswYIvs=; b=HJbyqd9epUJP2jzuBtas38n3zW O4xtsseqsamV+X9yGZu8Rmy4AIL2qjp40BI83yDFWr0J+3yyhq14VjKFBjreqfoX u7Gr8zsOJYgd+kzb0h7v4+WLatmbYnLDjuSbJzkJupQUw74enOISvHw5B+7+QfXx zkIkFRvl1z5SsgF+yfSklMrSHdpr+IoimWlfQaX7ATnE7xbnZ7SkxQm7KWJDqWIZ mtg6YbjFOaDTFmfMnRxAd5ZlkORKm1NZ3oOqHbxHgcld+2A3fdDLXE7d2S6OY7Ek DE02W+XUzy+ByFtG/FvIIr45Wu3I6TBYNlz4LV5B7cZ2+fBpe3Zjs8yAIohg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1779524944; x=1779611344; bh=DGyUBUhAFjjyYhJHzmAAh8y3nVxhfkQEV8S WUswYIvs=; b=mkompUnC3Thi3ND9tZK0iuzOGDJFita9JOY7fJpZDJltkmcdb91 U9y/4DbZvQ9Sii4DXJ5QoMHA34u2EwyeNuIX71y3IkD6ePBBjEGwm5K059KfBeOx HEO/1uoeo2SzSmAGmiPEsfgCZCLwT7XMh+O642kLoYSnH7r6b0OuWOIhZhMavVw9 C00twqe1iceykylqO1+HcVZeyqRK8Ta5xrWUbcsMQxbjb709XdMfz7UTuUn9GrRh r5k8YKpZUyR2c/ZY+zgvFCLT5u6DEjoWNg7hAp/BbhbWJexwF4TKJU8z9Iawnifi n+hmDzQTECnQWiCgEyGG5ICJv6Wrz7zo6nw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdduhedvheejucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefujghffffkgggtsehgtderredttdejnecuhfhrohhmpeetlhihshhsrgcu tfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeetheevud fgjefghefhieejudelkeeljeegvdekueeuhffhgedvveefteevgeetieenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehhihesrghlhihsshgrrd hishdpnhgspghrtghpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohep vhgrlhgvnhhtihhnsehgrghgrghrihhnrdifohhrkhdprhgtphhtthhopeguvghvvghlse hsphgvtghtrhhumhdqohhsrdhorhhg X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 23 May 2026 04:29:04 -0400 (EDT) Received: by fw12.qyliss.net (Postfix, from userid 1000) id 60C80B223BE9; Sat, 23 May 2026 10:29:03 +0200 (CEST) From: Alyssa Ross To: Valentin Gagarin Subject: Re: [PATCH] release/checks/whitespace: skip binary files In-Reply-To: <20260520222237.257773-1-valentin@gagarin.work> References: <20260520222237.257773-1-valentin@gagarin.work> Date: Sat, 23 May 2026 10:29:01 +0200 Message-ID: <878q9ar0ky.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: HA5COYTLH3VYX6ECFLR3EW6IIU3GGDL3 X-Message-ID-Hash: HA5COYTLH3VYX6ECFLR3EW6IIU3GGDL3 X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: <> List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Valentin Gagarin writes: > Trailing whitespace is meaningful only for text. > > Signed-off-by: Valentin Gagarin > --- > release/checks/whitespace.nix | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/release/checks/whitespace.nix b/release/checks/whitespace.nix > index 56710b6..3929c8f 100644 > --- a/release/checks/whitespace.nix > +++ b/release/checks/whitespace.nix > @@ -9,6 +9,6 @@ runCommand "spectrum-whitespace" { > fileset =3D srcWithNix; > }; > } '' > - grep --color=3Dalways --exclude=3D'*.patch' -r "[[:space:]]$" $src || = touch $out > + grep --color=3Dalways --binary-files=3Dwithout-match --exclude=3D'*.pa= tch' -r "[[:space:]]$" $src || touch $out > '' > ) (_: {}) Thanks =E2=80=94 definitely an improvement. I'm going to tweak to use the shorter -I to keep the line length manageable. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQQGoGac7QfI+H5ZtFCZddwkt31pFQUCahFlTQAKCRCZddwkt31p FcNbAP45td0quBcT6Cjb8n5VNaUYsy+Ytk3Jhx5qkjTKU3qfyQEAjUUyI6Z1dU5N zckZzAWZidTUmDa15/QRs/1DiObTMA4= =4zkQ -----END PGP SIGNATURE----- --=-=-=--