From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id A5F30613D0; Tue, 20 Sep 2022 12:00:14 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 4629761419; Tue, 20 Sep 2022 12:00:10 +0000 (UTC) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by atuin.qyliss.net (Postfix) with ESMTPS id 77542613AE for ; Tue, 20 Sep 2022 12:00:06 +0000 (UTC) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id F03B53200A1B; Tue, 20 Sep 2022 08:00:03 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 20 Sep 2022 08:00:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1663675203; x=1663761603; bh=j6pliuDSJ4 uNgnCi2TdqgVE5cR7arKB9Xa2KQqsKN3I=; b=oGyNscTCIhkVE/YJfwkKPZPNNK KiAIjl8HlIAuWf4ptwSZntgktQVeqx17y7VVClf4Bo42+6K9czoC88q7B41ogoj0 r/sXy0ErOyviNtYVk/uhZ0Fdb6BuNnHvh1XoC/yDQlyJ1ri4v+ACeS6882xLEY6L mIKJb2sVjqyJPBeA7EMRdN7O2ush9JgvbgdvtEXufEfL2AUqnZM5imZ2HEPmWJTI 7LoWRxyyexbSfYKVfgIdie4OMgac5BkY1imzm+yjpzjfqN+VTUlLXl7es1ghZqna hQCibqWgTvX/+8AiS+KEgiVmZF2NLwG4TegCyHfXjmAsWK6bHCfEtwflTmRw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663675203; x=1663761603; bh=j6pliuDSJ4uNgnCi2TdqgVE5cR7a rKB9Xa2KQqsKN3I=; b=ysls4PoBkJeIw51TxGq48dgfv786qQBhTlqNyqCbyhAD DUSnyVfcFYedvLnytCVxEfZesdvLScUTOB6RdG/1x4QbP2NjCXxBgJRWjy9KmtP1 0vTDoQqYsEUmlkpaiCPSB8tkuFlZXuB4GxjDw1rokEt3yLnnaK8VA+VXq7IDa6xf b6IIkTRdmq9Sz7lbkrUkdpdI4dSh193AkOHxcBFHjzHbjgvteXr+zdrYCBGQoMxZ UwFzK2FgRxWEFNCC45AS/GWPgvAn7s7NmdhZvFKRZeDWXuzUkTf41lktAo9403MP 2qfbSa6Zn85+pxKy4Z74KOasO/a9rhg0sLVWeqilrg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvledggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkgggtsehgtderredttddtnecuhfhrohhmpeetlhihshhs rgcutfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeevje eikeehffeuheejvedtkeellefhhefhleegffeiieduvdeuieefteekleffvdenucffohhm rghinhepshhpvggtthhruhhmqdhoshdrohhrghenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehhihesrghlhihsshgrrdhish X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 20 Sep 2022 08:00:02 -0400 (EDT) Received: by x220.qyliss.net (Postfix, from userid 1000) id 005A9985D; Tue, 20 Sep 2022 12:00:01 +0000 (UTC) From: Alyssa Ross To: Ville Ilvonen Subject: Re: [PATCH] fix: config support with vms In-Reply-To: <509b7100-998a-a7e9-a8a4-61312af67767@unikie.com> References: <20220920110958.2548848-1-ville.ilvonen@unikie.com> <87fsgmmgdf.fsf@alyssa.is> <1263b0d5-14f7-9650-7823-70da02f42c5d@unikie.com> <87bkramfvn.fsf@alyssa.is> <509b7100-998a-a7e9-a8a4-61312af67767@unikie.com> Date: Tue, 20 Sep 2022 11:59:59 +0000 Message-ID: <878rmemf28.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Message-ID-Hash: GFUM4FSGIFHMSTCT2Y624QLASITJLDCV X-Message-ID-Hash: GFUM4FSGIFHMSTCT2Y624QLASITJLDCV X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.5 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Ville Ilvonen writes: > On 9/20/22 14:42, Alyssa Ross wrote: >> Ville Ilvonen writes: >>=20 >>> On 9/20/22 14:31, Alyssa Ross wrote: >>>> Ville Ilvonen writes: >>>> >>>>> with config.nix, the build of vms fails with >>>>> error: undefined variable 'pkgs' >>>>> .. >>>>> 49| >>>>> 50| kernel =3D pkgs.linux_latest.override { >>>>> | ^ >>>>> >>>>> This fixes the issue for all default vms >>>>> >>>>> Signed-off-by: Ville Ilvonen >>>>> --- >>>> >>>> Hi Ville, I was wondering how I'd have missed something like the defau= lt >>>> VMs not evaluating, but indeed I'm not able to reproduce this. And wh= en >>>> I look at the default.nix files for the default VMs, I see: >>>> >>>> 50 kernel =3D buildPackages.linux.override { >>>> >>>> So unless I've missed something, I don't think this issue exists in the >>>> current upstream. (I checked commit 3aa2f8a.) >>> >>> I'm not testing with default but with new config.nix support. >>> Have you tested with any config.nix? >>=20 >> I'm not sure I understand what you mean. config.nix support is already >> present in the commit I tested. >>=20 >> I created a simple config.nix file that just set "pkgs" to "import {}" >> in case the presence of the config file made a difference, and ran: >>=20 >> nix-instantiate vm/*/* img/live > > Interesting. I created a simple config.nix in the root of Spectrum=20 > source tree - https://spectrum-os.org/doc/build-configuration.html > It only overrides the kernel - to imx8 - and sets crossSystem for=20 > aarch64. Build of vms fails without this patch. Are you testing with an upstream Spectrum commit, or with one from the TII branch with cross compilation support? It's likely that making cross compilation work would have required changing line 50 you posted above, because as I explained I don't think it's correct. So if you're using that branch, that could explain why you're seeing this and I'm not. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmMpq0AACgkQ+dvtSFmy ccANwQ/8CsYlCTb3/ev9j+Lrji5E71HLJ+62RsD+EK16eS6IJjKQ8/njY6tvC8Zg Z5CYiKqLKkF1bkO5HfHimjNgYdV7aL/yu3BsT1MPYPSVDA2Azwmz71N5ywphwG3z 4UYCpZBo6GXm6dB/r0St0Uy9MWx2sXUkNWpMz4S6LDg/BKOgiFEO/+36YOPFFMXn XxA24StRyw1CWsyjvljEkMdutJaZPATmVBH9nGQRhuRJ+LKKFZ4ImkzY16ET6IaW oUX16KoVNtfooMiOQK3dFw7edBCRIGoSm7oDUkT+O6X61BtagPKowQKrfFDi79Kp 29v3Sa9NG07fjr6p12Ij5/tqdhJ1/hycE4ygnJR2vz5PZStnrjd6yYKzYsCp02Ru 0+s+yr6co3WpF+NzUK4cGnmw4rsqIPiLO6XGWu3+OxJaCTf+dU9eUrrG7mJRgelk vfPfx/GDIgsedZzJf5e8D9JYhsFvIK+SsoQGHinaRL/gfDzTiYiYBUb1ct3KC819 pkV3zy9n0SdGbuGYu104ugGq8mTZ0O/dWN6OOjL7a6GmG4QaJgYgk1P3HDGcn2Eg KoB92cNJ5lZgZDwI5zNMN4aZs9oVKHXINkD+1ernkPIV8Am1NL4majnIo5gBY7NE PXQeJ1vkG6vCbCUV3JAdvQwJz3iOIv+TcXPKMP88srO85CSsPIg= =zg8Y -----END PGP SIGNATURE----- --=-=-=--