Re: [PATCH] host/rootfs: Always fail if there is a globbing problem

[Alyssa Ross <hi@alyssa.is>]

[-- Attachment #1: Type: text/plain, Size: 1383 bytes --]

Demi Marie Obenour <demiobenour@gmail.com> writes:

> On 12/28/25 16:56, Alyssa Ross wrote:
>> Demi Marie Obenour <demiobenour@gmail.com> writes:
>> 
>>> Better to fail than to continue after an unknown problem has happened.
>>>
>>> Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
>>> ---
>>>  host/rootfs/image/etc/s6-rc/static-nodes/up | 2 +-
>>>  host/rootfs/image/usr/bin/assign-devices    | 2 +-
>>>  host/rootfs/image/usr/bin/run-vmm           | 2 +-
>>>  host/rootfs/image/usr/bin/vm-import         | 2 +-
>>>  host/rootfs/image/usr/bin/vm-start          | 2 +-
>>>  5 files changed, 5 insertions(+), 5 deletions(-)
>> 
>> Networking test fails with this applied:
>> 
>> + vm-import user /run/mnt/vms /run/mnt/storage
>> elglob: fatal: unable to complete exlsn function: No such file or directory
>> elglob: fatal: unable to complete exlsn function: No such file or directory
>
> That is strange.  Which directory doesn't exist?

That issue seems to have gone away now, but there was another issue,
which turned out to be the elglob in run-vmm.  The relevant glob here is
*/config/providers/net/*.  If the first * matches something, but
config/providers/net does not exist below it, globbing fails.  This is
not what we want.  So we can only make this change in situations where
we'll never have a non-existent prefix of the glob path.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]