Re: [PATCH v4 1/2] tools: Add adapter tool for services using sd_notify

[Alyssa Ross <hi@alyssa.is>]

[-- Attachment #1: Type: text/plain, Size: 1853 bytes --]

Demi Marie Obenour <demiobenour@gmail.com> writes:

> On 10/29/25 07:26, Alyssa Ross wrote:
>> Demi Marie Obenour <demiobenour@gmail.com> writes:
>> 
>>> diff --git a/tools/sd-notify-adapter/meson.build b/tools/sd-notify-adapter/meson.build
>>> new file mode 100644
>>> index 0000000000000000000000000000000000000000..6032a3a7704d49cae0655b43d0189444d3b15e4d
>>> --- /dev/null
>>> +++ b/tools/sd-notify-adapter/meson.build
>>> @@ -0,0 +1,4 @@
>>> +# SPDX-License-Identifier: ISC
>>> +# SPDX-FileCopyrightText: 2025 Demi Marie Obenour <demiobenour@gmail.com>
>>> +
>>> +executable('sd-notify-adapter', 'sd-notify-adapter.c', install: true)
>>> diff --git a/tools/sd-notify-adapter/sd-notify-adapter.c b/tools/sd-notify-adapter/sd-notify-adapter.c
>>> new file mode 100644
>>> index 0000000000000000000000000000000000000000..10f4e05eb602491540a792c7fb5620d66d5bb989
>>> --- /dev/null
>>> +++ b/tools/sd-notify-adapter/sd-notify-adapter.c
>>> @@ -0,0 +1,114 @@
>>> +// SPDX-License-Identifier: MIT
>>> +// SPDX-FileCopyrightText: 2025 Demi Marie Obenour <demiobenour@gmail.com>
>>> +
>> 
>> One more thing: why is the meson.build file ISC?  Why is the
>> implementation MIT?  Should I change these to the normal EUPL-1.2+ when
>> applying?
> I'd actually prefer ISC for the implementation, so that this can be
> used in s6 if upstream ever decides to accept it.  MIT is just an oops.

I think there's no way s6 is going to adopt an external implementation
like this that doesn't use skalibs, rather than just rewriting it, but
okay, we can stick with ISC if you want.

There's definitely no way it's going to take the one line Meson
file, but it's unlikely to be copyrightable anyway, and I think we might
as well just inline it into tools/meson.build like lseek, so I'll just
do that when I apply unless you object.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]