From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 4B86E31FD; Sat, 06 Dec 2025 12:26:52 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id DB66431F6; Sat, 06 Dec 2025 12:26:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fhigh-a3-smtp.messagingengine.com (fhigh-a3-smtp.messagingengine.com [103.168.172.154]) by atuin.qyliss.net (Postfix) with ESMTPS id C14AA31F2 for ; Sat, 06 Dec 2025 12:26:48 +0000 (UTC) Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfhigh.phl.internal (Postfix) with ESMTP id DA39A1400073; Sat, 6 Dec 2025 07:26:45 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-06.internal (MEProxy); Sat, 06 Dec 2025 07:26:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1765024005; x=1765110405; bh=Ma0GxDZqvj xx/cyWOe3MvAWIpOoE4zDRLF2O+Vgrzh0=; b=kE8a3wSembZ8T7BG9UBlazTJfz UK+Nr436HzL2iWVckxTuo+Gj23h7RYoZyWhfpW/DEQCvj5zlLyI/oSOkvxhgNMIU vQlhZ5EqRCQL9AZmO2sGFqiRVIJF2ydK2wqt4Z0/bsenEe8vceK72muKMa98jTU0 Y7sygNEH2K0/0hzTTgUU+PMJCWw7odA8Yh7HajQYJB3Tmt7AFBWeKyRkc2dZHt5h /TAMjKczqlcIQ7kfT87A88qV1IGlrceM1OeUCqVcnAScYPDkYtdugF+eX+sHwB8B wOYySW8uTMrumOQ1ZKOX9WVezpfwqMuEU0AN1xihvqorxf2Q4Ku8Eowh6xFA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1765024005; x=1765110405; bh=Ma0GxDZqvjxx/cyWOe3MvAWIpOoE4zDRLF2 O+Vgrzh0=; b=rjVh4mWbFP+nlhNs1APeukCM5e9tqXlKsJQ6l1BJPXnY4vKFHdM v12RbhNDwFm9s8A0zbIbMuuOWJxkECdfHrhAnCoPEQy1wl6Ra7/lBdj41OvM6F0O WZ1afe3CvWJB2vLCQ6sYziBrbq/mxv0QhcBDE8CGs+PpZVXwLXzPjMLpep3Ri31a ljOhw4FHsShLShSpFDferW6AIJJCBD9KHKgocjiSNDku1NqFzjzwiJSvCoYOCZc2 FCItBKe+byMOjjlLYOoOIkemLptKeBOXcCGUzr1uNSFrue3vt2FdAn/MQ7v2Y+8R wojGyolyS9L9ntLQ2/qNiunKslgHn+ZGqhQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddutdelgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufgjfhffkfggtgesghdtreertddttdenucfhrhhomheptehlhihsshgrucft ohhsshcuoehhihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepieduffeuie elgfetgfdttddtkeekheekgfehkedufeevteegfeeiffetvdetueevnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhephhhisegrlhihshhsrgdrih hspdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegu vghmihhosggvnhhouhhrsehgmhgrihhlrdgtohhmpdhrtghpthhtohepuggvvhgvlhessh hpvggtthhruhhmqdhoshdrohhrgh X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 6 Dec 2025 07:26:45 -0500 (EST) Received: by fw12.qyliss.net (Postfix, from userid 1000) id 0946C4793F82; Sat, 06 Dec 2025 13:26:37 +0100 (CET) From: Alyssa Ross To: Demi Marie Obenour Subject: Re: Test for portals passes even when file portal is broken In-Reply-To: References: Date: Sat, 06 Dec 2025 13:26:35 +0100 Message-ID: <87bjkblrt0.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: EBS6IQL54APJJ3TV7P6PEHJDTQFFZ3W5 X-Message-ID-Hash: EBS6IQL54APJJ3TV7P6PEHJDTQFFZ3W5 X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Spectrum OS Development X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Demi Marie Obenour writes: > While trying to sandbox the file chooser portal, I broke it. > This caused files not to be saved, resulting in silent data loss. > Unfortunately, the integration test still passed. > > Is this a bug in the test? Is there a better alternative to manual > testing? Not presently, but we can work on improving the test. The current portal test was written as a regression test for a specific issue we had. It's quite hard to test completely end to end but we could do a lot better. I would quite like to spend some time in February or so working on our tests. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQQGoGac7QfI+H5ZtFCZddwkt31pFQUCaTQg+wAKCRCZddwkt31p FResAQCRLReb9GWr4TQLUFt5oGtd4VJ+ydu0r9HM4YRqYZy5JAEApj3SnCHtNmGp SGP4PgkaLtv136lVy59VlUI5+W+RAgg= =8sLW -----END PGP SIGNATURE----- --=-=-=--