Re: [PATCH v6 2/2] Move UKI creation to a separate derivation

Demi Marie Obenour
2025-11-28T19:27:21Z

[-- Attachment #1.1.1: Type: text/plain, Size: 1597 bytes --]

On 11/28/25 05:47, Alyssa Ross wrote:
> Demi Marie Obenour <demiobenour@gmail.com> writes:
>
>> It will be used by the update code later.
>>
>> No functional change intended, other than a trivial shell script
>> refactoring.
>>
>> Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
>> ---
>> I kept release/live/default.nix using the UKI's systemd because the old
>> code did it that way. Changing this would be better in a separate
>> commit.
>
> Yep, makes sense.
>
>> Changes since v5:
>>
>> - Create a temporary symlink named build/spectrum.efi and then run
>> $(MCOPY) -i $@ build/spectrum.efi ::/EFI/Linux, rather than copying
>> the file with its original name. The latter results in an unbootable
>> image. I do not know the reason.
>
> If I just mcopy -i $@ $(EFI_IMAGE) ::/EFI/Linux/spectrum.efi (explicitly
> specifying the destination file name), then it works. It doesn't is something like
> "/nix/store/3yqb8mfv6skp43yp2r7sn098zrj0hrjf-spectrum-efi".

I distinctly remember it *not* working for me, but I might have used the wrong
destination name. Perhaps I used Spectrum.efi (wrong case)?

> This could be avoided by installing EFI_IMAGE to a subdirectory, so the
> file name didn't get a hash prepended to it by Nix. Happy to just go
> ahead with changing this and applying my style comments from last
> time[1] if you agree.
>
> [1]: https://spectrum-os.org/lists/archives/spectrum-devel/877bve2skh.fsf@alyssa.is/

That would be great and an even better solution.
--
Sincerely,
Demi Marie Obenour (she/her/hers)

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]