From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 1287C7CD0; Sat, 28 Sep 2024 14:28:12 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 37A227CC6; Sat, 28 Sep 2024 14:28:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=DMARC_MISSING,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fhigh-a6-smtp.messagingengine.com (fhigh-a6-smtp.messagingengine.com [103.168.172.157]) by atuin.qyliss.net (Postfix) with ESMTPS id 0AF3C7C40 for ; Sat, 28 Sep 2024 14:28:01 +0000 (UTC) Received: from phl-compute-09.internal (phl-compute-09.phl.internal [10.202.2.49]) by mailfhigh.phl.internal (Postfix) with ESMTP id B9377114012D; Sat, 28 Sep 2024 10:27:59 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-09.internal (MEProxy); Sat, 28 Sep 2024 10:27:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1727533679; x=1727620079; bh=w5eGhtCObf zjEgZUZhL/vzCiT0/6MqOQQ5VetTJawgQ=; b=fPr9DlacXArqiJbQcqsmp5rH1w bYj+RH+e+aco9otubZY7wb4RGx+I1ha+YROxIu9n3NhE5BmpmPfj/zOWBR+/R6Ic mN+bCtuMliJGIgiy84PTVzzLvZ3EnQTEwj9VikxNwJSE0q/niTn/o3qwl3lXq4S7 Ea7hkNT8JO8D0Sm3OGyn+yzqZ/nl6VBN4HG0qQvLuIuowx7qYIpcHThQIKO+kO2z ug1NZH87uYdxiYtbKGBrBWrjGENKfDUfGeu810phabZpxtjGo0ZPTNw3kv5br9XK 2zNY0e/MIlpHg8pGLRznlxkFbJj7GvY53xH6Klh+OnhvJlRmAifvtsKwhLJg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1727533679; x=1727620079; bh=w5eGhtCObfzjEgZUZhL/vzCiT0/6 MqOQQ5VetTJawgQ=; b=FYOIDWZGoItGVhU/DeFBZAVFiomApngt61neYxw8ppJQ ShMWOsrWhDBhKUMPEd8UiUz+7Da4Bd/9AHAACe7xxHiXyJpR5p3WeflNZXhHc6sn 4Rt1UlQm1X9IsQNX01uvJYqiroLqroX61fgQlw49u/9gFut3hIqturrZyNzTjPgl ZK0ogmNcHx6VokvFaCBs7JMk7Cy8cBTNaLCdzBKj2fDFlb+yGzdGvoUH6fuMgSiM 75sSJCdW5zlto2Qe7pqyZpFp0bqokCurqSevEnO6m7iRDEOeD/gm5F+0hP/AcA+z 3X6zq/btrjWpfiTgJHHs3Hd9IocK+ZLQXeq89scw3Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdduuddghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevuf gjfhffkfggtgesghdtreertddttdenucfhrhhomheptehlhihsshgrucftohhsshcuoehh ihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepkedtffejteelfeevledtje fgfffggfdtjeeuveetteekiefhtddtvddvieduhedunecuffhomhgrihhnpehgohhoghhl vghsohhurhgtvgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehhihesrghlhihsshgrrdhishdpnhgspghrtghpthhtohepvddpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtohepshhhhihmvghgrgesshhhhihmvghgrgdroh hrghdruhhkpdhrtghpthhtohepuggvvhgvlhesshhpvggtthhruhhmqdhoshdrohhrgh X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 28 Sep 2024 10:27:58 -0400 (EDT) Received: by sf.qyliss.net (Postfix, from userid 1000) id EF2F3301DE086; Sat, 28 Sep 2024 16:27:57 +0200 (CEST) From: Alyssa Ross To: Dom Rodriguez Subject: Re: [PATCH v2] crosvm: Rename `--vhost-user-{fs,gpu}` args In-Reply-To: References: <20240906224329.2336996-1-shymega@shymega.org.uk> <877cbnfmdf.fsf@alyssa.is> Date: Sat, 28 Sep 2024 16:27:56 +0200 Message-ID: <87bk07am4z.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Message-ID-Hash: EX5RXF5DBYAI5WA66AYJOKK6ZCKTNI3N X-Message-ID-Hash: EX5RXF5DBYAI5WA66AYJOKK6ZCKTNI3N X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Dom Rodriguez writes: > On 07.09.2024 18:40, Alyssa Ross wrote: >>Dom Rodriguez writes: >> >>> crosvm was producing warnings when using `--vhost-user-gpu` and >>> `--vhost-user-fs`. >>> >>> In this commit, I have adjusted the `crosvm` invocations to look >>> something like `--vhost-user $DEVICE,socket=$PATH`, where `$DEVICE` is, in this case, >>> `gpu` or `fs`, and `$PATH` is the path to the Unix socket. >>> >>> Signed-off-by: Dom Rodriguez >>> --- >>> img/app/Makefile | 4 ++-- >>> release/checks/wayland/default.nix | 2 +- >>> 2 files changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/img/app/Makefile b/img/app/Makefile >>> index 3adf8c4..11ef6e1 100644 >>> --- a/img/app/Makefile >>> +++ b/img/app/Makefile >>> @@ -152,8 +152,8 @@ run-crosvm: $(imgdir)/appvm/blk/root.img start-vhost-user-gpu start-virtiofsd >>> --disk $(RUN_IMG) \ >>> -p "console=ttyS0 root=PARTLABEL=root" \ >>> --net tap-name=tap0 \ >>> - --vhost-user-fs build/virtiofsd.sock:virtiofs0 \ >>> - --vhost-user-gpu build/vhost-user-gpu.sock \ >>> + --vhost-user fs,socket=build/virtiofsd.sock:virtiofs0 \ >>> + --vhost-user gpu,socket=build/vhost-user-gpu.sock \ >>> --vsock cid=3 \ >>> --serial type=file,hardware=serial,path=build/serial.log \ >>> --serial type=stdout,hardware=virtio-console,stdin=true \ >> >>This is still not right, I'm afraid. >> >>When I run nix-shell --run 'make clean && make run' VMM=crosvm in >>img/app, I get this error: >> >>[2024-09-07T16:36:32.592274891+00:00 ERROR crosvm] exiting with error 1: failed to connect to vhost-user socket path build/virtiofsd.sock:virtiofs0 >> >>Probably the tag should also be a comma-separated key=value option? >> >>(This doesn't have any automated test, because it's just part of the >>development environment, and setting up a test environment to resemble a >>development machine isn't trivial. Should be possible though.) > > It's bizarre. I've done some more testing, and it seems that > `--vhost-user` isn't *quite* there yet on feature parity with > `--vhost-user-fs`. Maybe I'm going wrong here, but it doesn't recognise > the tag as a k/v option. > > I have managed to get the tests running with `--vhost-user-fs`, but it > does look mismatched now. > > Would you prefer I revert the changes to `--vhost-user fs` => > `--vhost-user-fs`? You're right! I've just spent the last little while looking around trying to figure out what's up here, and I think I've figured it out. In this commit[1] they made the vhost-user-fs tag optional, because it can now be set with virtiosfd instead of the VMM. This is probably good, because the more generic vhost-user becomes, the more hope Spectrum has of one day not needing Cloud Hypervisor patches. :) So we could try using --vhost-user fs for crosvm, and then passing --tag to virtiofsd, but it'd need to be tested with VMM=qemu and VMM=cloud-hypervisor as well, because I'm not sure whether they support a backend-provided tag. If that's too much work, I'd also be happy to apply just the GPU part of this patch. Just let me know. :) [1]: https://chromium.googlesource.com/crosvm/crosvm/+/b3f46c8fcbb0ce1047c4a5ca2c26c66e29e8eb44 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmb4EmwACgkQ+dvtSFmy ccAaVQ//SOU3jgvTzKP0E7E2tJhpZnAwH4md4OBbizZCFcX7vZ/cxizPO+ndFupu KewJrER2b1RN2Fkqkd5Dq4Y6O2n63R4qNTP1B8NdRfL7xhtz32gvQ81DWMIdgZzF FS3qg0hZQVZPaJHZ0O3yhIkmocSenkwsAbG8r2ZbHS45OA7Dnq5//sXR8QyoKqml N7bNH7ZCivxl7NsB3VdOUvUl6TzhxZyF/jeOXDniQTXHSiINBeSLOCAVEf6rjVAu xuDbtckCAcocReyi0YuriO86cqBswl8WpUgJjhZTQ2kuO526kdeAH0hfvBvDuNFQ GHiZOAIraCwPFgEfeixLl1DlxCakCjCB4UJhq1tYoKu4lV9zW/jKhNCIHQuifxrV Yex7B1bHOd/dKeArSSvzMkyjvK+fxlJrtG7uY4hoqEkIo9hj582aZaWDw/nE2Fra ntDkZI7/a5WKiwPDQ+kXimPUnBWeKjFtZ/BDzeb1jwVrypvTEEStW6HPOi7vRRzf 0NT52Wb0tagkyKTbM23/13FmRP5KJ9xiWDCrzKNc+1f2XmNnPbnvlU2h/J+mGCe+ vZT7MkMaS/ofsdwKYmZ54vcfZhcPrrWOS21bzM2he/XfebIwkE6Iq7mSnCk44HkO WPHpVcjDi7ocm0yBZxo51gcfc7+5qSFRwLslNC79kP5HpGJveaU= =qzUH -----END PGP SIGNATURE----- --=-=-=--