From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 615829FDE; Thu, 25 Jun 2026 11:29:02 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 7DCC99FD2; Thu, 25 Jun 2026 11:29:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fhigh-b8-smtp.messagingengine.com (fhigh-b8-smtp.messagingengine.com [202.12.124.159]) by atuin.qyliss.net (Postfix) with ESMTPS id C76559FD0 for ; Thu, 25 Jun 2026 11:28:58 +0000 (UTC) Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfhigh.stl.internal (Postfix) with ESMTP id 2C1BE7A0208; Thu, 25 Jun 2026 07:28:57 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Thu, 25 Jun 2026 07:28:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1782386937; x=1782473337; bh=S+u3q4X5j0 ZgRLYBt3mkVJ5wLcZs+Yj5+TT9oHfSwmI=; b=bZU006BnSjt3aVLyQDno8xv7vn VDLaWroOqQmPKRCpPFCjCTYy6xs2AAybPsKY4w7xFvlMgCMfIfDxiD9UuWPy2Oqv k7dA2qUmN8ZA2LqCY1WM1YswybvDspGQTCnl3/Vp2/n8N6mta8Z0F7FvfdSMN2K+ eECkgB2NQ3e9zVgX2WJPZ1Nn9vB2Q2Q5gJ1nL6YfphqPKRvIlLsYPwtekSxdKC4r yqkHmfxzgrSXT4GZybJMYHHZ8cGcmk8fuqVuAMUPVJcIePh08MSYZVVD6xegItrU BAN9IoT92aNVDfiwBTUi0it0oiet0umYw1ZaRUhY5MserFTSbiHPdTvn1VYQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1782386937; x=1782473337; bh=S+u3q4X5j0ZgRLYBt3mkVJ5wLcZs+Yj5+TT 9oHfSwmI=; b=bQ//1lFyHqgNeGKpvnqLb0Kjth8cksEj+7g/S4uFExadFNNXXck 7ZD1FITuitZGWVRclzac7qc4DMN8rRKWCLTbIcabELz3BBQ7mBUufujoqPb854U4 O/ZBrXqJA8kUDD/lYE5PIozIRWShlkrmRG+Ny2g9+fW1nShsaElHPNo7NMf2AC+x FjV8Ti4juRRcbtpgEIora15K4LDGKB07O+utva7dEM+Zfi50IhyZhnrUIhfaz46u F2lFKx5Z7oKTsSI6YWxcr0ImTscSBYls68XvpgPmAhQevAx7OXPbLcMgwkAoj6Ne ELN/ZsuMsVaQzebdJ436ovXm/VFu2wp8YgA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGPfRq2HfUaZs75SjK1d6NKQTYfbmvGFmFSFI7R8biMnMYx5n9c7OB+ivAUYTFYWt YTUncpf1gQ/hjKxswZDlIVYggL+1g8/2WpXBoBow3oUJL/KGTW2TTqNB2nOoM81h2jhMeK o4lgQB0Ra3371giq49Or40f2vu+U5EBCCxU2R/1OiDFVoc2ehR8KF8cZ/7Xn0kX9xkjg6Q p/Y2g7vMXfKfqVUQiVkKbDQhzjNASRdIAVadKEHUqL+aCsiYrCJiLYa8DECNIMrSRhvcV5 T1TfMqhGdX7vejtMLy1Xf7Zxl9AgfDHt3X+RkxJl0MDGp8zwT7gD7YHRFUmpODOiQ2YPEd q7GWx3BE2SglzUWFpxF/UlHGoiSBj6hJ6fRFxafopv34v1Lna8cE20MrENNvxHH2SYKoO/ +pkfIpMve7ik4PUbIhhW9al66R80qPcnycaJ9pIy1NY/wz5U3yjSXJG2DZpI4h/kOC3zfs tHSPm3CH4+mzrwIBt1sFUF6sjU5KlQb/vcEbrfpeWM6zhSeaOq/hSV7xCqSIr7LedV0bBG KzM/Vhc6dclDiUCMc2TJSJUYh6IfosRVFKJORwX834gFvuu2hiB0Ds+sigRm5cGI5pYa6P GndyoqFZm2SW1kLVmPVHXD9Gk9VN+DvlXdy7zln4Mia/ZyRtXCOmlO4lsHUA X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 25 Jun 2026 07:28:56 -0400 (EDT) Received: by mbp.qyliss.net (Postfix, from userid 1000) id A3D2A837F7A8; Thu, 25 Jun 2026 13:28:54 +0200 (CEST) From: Alyssa Ross To: Yureka Subject: Re: [PATCH] tools/router: trace unicast packets In-Reply-To: References: <20260619130940.273236-1-hi@alyssa.is> Date: Thu, 25 Jun 2026 13:28:53 +0200 Message-ID: <87cxxe6eq2.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: 74CVJCEYUIA3SLCDU3B5IYGERREV7KBN X-Message-ID-Hash: 74CVJCEYUIA3SLCDU3B5IYGERREV7KBN X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.10 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Yureka writes: > On 6/19/26 15:09, Alyssa Ross wrote: >> I found this useful for debugging. >> ("Is it actually sending anything?") >> >> Signed-off-by: Alyssa Ross >> --- >> tools/router/src/router.rs | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/tools/router/src/router.rs b/tools/router/src/router.rs >> index a91e4155..f36866d8 100644 >> --- a/tools/router/src/router.rs >> +++ b/tools/router/src/router.rs >> @@ -11,7 +11,7 @@ use crate::packet::*; >> use crate::protocol::*; >>=20=20=20 >> use futures_util::{FutureExt, Sink, SinkExt, Stream, StreamExt}; >> -use log::{debug, info, warn}; >> +use log::{debug, info, trace, warn}; >> use tokio_stream::StreamMap; >> use vhost_device_net::IncomingPacket; >> use vm_memory::GuestMemory; >> @@ -128,6 +128,7 @@ impl Router { >> .await?; >> } >> ref unicast =3D> { >> + trace!("got unicast packet {:?} -> {:?}", in_iface,= out_iface); >> let Some(sink) =3D self.sinks.get_mut(unicast) els= e { >> warn!("dropped packet because interface is not= ready"); >> continue; >> >> base-commit: 57bf21eaf65ca5a42d18999ba65f96dcd338113c > > In general useful, yes. I think logging on this level could affect=20 > performance (even if disabled at run-time). There is some crate feature=20 > of the log crate to conditionally compile the trace log level for debug=20 > builds. We're already using release_max_level_debug, so traces are already omitted from release binaries, aren't they? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRV/neXydHjZma5XLJbRZGEIw/wogUCaj0Q9QAKCRBbRZGEIw/w oreMAQDUjnm91cK/HikqLgtie5Kr7tpjVf+VLpl1M83lLXf6CwD+JkaLbI7Y0Jvq 8p1xhYDFAXmltxg6gCe0vdoC2ytiiQw= =y2mS -----END PGP SIGNATURE----- --=-=-=--