From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 111A74FDB; Sun, 21 Sep 2025 12:09:46 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 2900B4F7D; Sun, 21 Sep 2025 12:09:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fhigh-b6-smtp.messagingengine.com (fhigh-b6-smtp.messagingengine.com [202.12.124.157]) by atuin.qyliss.net (Postfix) with ESMTPS id 7E0034FCB for ; Sun, 21 Sep 2025 12:09:43 +0000 (UTC) Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfhigh.stl.internal (Postfix) with ESMTP id 6E0417A019D; Sun, 21 Sep 2025 08:09:42 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Sun, 21 Sep 2025 08:09:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1758456582; x=1758542982; bh=SQ+s/NnM2t nc9JmTIZY7Q3mvZbui0gASiGYkV4JNk70=; b=CbfGIS4fPdkbayGq/JD7DfrcuE xT7XYif9+ENXLdnYq+828Ogj/A1y8glQH+ZxPWGgeM2ssvXzz2O8tkk7tz0bGgoy zigUq40rGvotoNAWfNAybl2dZMf/3u/rWPm32umlat+eAdNOWTdpinnIhaFFmoZu YvSm4ve6jcnUpT41hLnUPgPQMb5MZaXA5mCQ8iHrZdWpBc/muL3WhuW9X1rqiv5C Vmr49QQGOGddP1zyuTTMs8oEHP2KKQQxXzJDxApQEbnSQ/7hkIpEKtRklLxryiaX L6iD6HlBvKTQryEDroZoePk47PABqhbLHbTNefVs+dgNgABfTFHy+duDMWVg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1758456582; x=1758542982; bh=SQ+s/NnM2tnc9JmTIZY7Q3mvZbui0gASiGY kV4JNk70=; b=kwfIGg3hKwpZhT6gGQekJi2SBJ1I9lvZya54K5qJLSYHF7SZRJt ygWNu5pc9F/CrKDZq6e2HRVTmtSaAPEbi9GFeHONdgC3ltGD9kTwrPK6h6YCL3b6 p/8csJW+MB5LxL4tg0Yz2SvjOL2O+LJelq00xXQ9MgJk31oKcmUH65MyGzNm+DUu 2Bap0r0OJuwXY+D+OY9Nii8ue0CQ1GtxxKDbwOMcxRTA+vyp4xu4/ZCFfriB+xCY RQwBvB+2FY19FhGgKKA1buIDHyj+J8rSup1Xdw3ZG1XYaLDinTu3uvHTPsLKeMU6 SLN1QMDIJz51yAa+I7C8xvXu/tBpllbdWJQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdehgeelfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufgjfhffkfggtgesghdtreertddttdenucfhrhhomheptehlhihsshgrucft ohhsshcuoehhihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepieduffeuie elgfetgfdttddtkeekheekgfehkedufeevteegfeeiffetvdetueevnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhephhhisegrlhihshhsrgdrih hspdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegu vghmihhosggvnhhouhhrsehgmhgrihhlrdgtohhmpdhrtghpthhtohepuggvvhgvlhessh hpvggtthhruhhmqdhoshdrohhrgh X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 21 Sep 2025 08:09:41 -0400 (EDT) Received: by mbp.qyliss.net (Postfix, from userid 1000) id 8C9BB24AF69C; Sun, 21 Sep 2025 14:09:35 +0200 (CEST) From: Alyssa Ross To: Demi Marie Obenour Subject: Re: [PATCH 04/20] scripts/make-erofs.sh: Validate all paths In-Reply-To: <87v7lq87ex.fsf@alyssa.is> References: <20250904-systemd-v1-0-2a63b790a913@gmail.com> <20250904-systemd-v1-4-2a63b790a913@gmail.com> <871pohl4rr.fsf@alyssa.is> <80ecbfb5-441e-4fc6-96ca-c765701ea523@gmail.com> <87v7lq87ex.fsf@alyssa.is> Date: Sun, 21 Sep 2025 14:09:34 +0200 Message-ID: <87cy7k57nl.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: WNSH62GKCIT3HHJSO4HVGYDWWYNT5SRA X-Message-ID-Hash: WNSH62GKCIT3HHJSO4HVGYDWWYNT5SRA X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Spectrum OS Development X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Alyssa Ross writes: > Demi Marie Obenour writes: > >> On 9/8/25 04:36, Alyssa Ross wrote: >>> Demi Marie Obenour writes: >>>> + (-*) >>>> + printf 'Path "%s" begins with -\n' "$i" >&2 >>>> + exit 1 >>>> + ;; >>>> + (/nix/store/*|[!/]*) >>>=20 >>> It's technically possible to use Nix with a different store path, so I'd >>> like to avoid anything that requires us to hardcode /nix/store. >> >> Right now, the generated images depend on the store paths, so >> the scripts would need to be adapted to support this. If we >> are going to generalize this, I recommend using a proper >> scripting language like Python, Perl, or Lua. > > The only place I see where we hardcode a store path is > host/initramfs/default.nix, which is a bug and easy to fix with Nix > code. (Fixed in 15ca6c4 ("host/initramfs: don't hardcode Nix store directory").) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRV/neXydHjZma5XLJbRZGEIw/wogUCaM/q/gAKCRBbRZGEIw/w ojYQAP9StRI4vvI5Q3LMhxQI7iY2Q6ojPFRSR3hg851NDwCCWwD6AjID0XZLcLaf G2hHczkhf4xJ+Rnj4yVpglZge/NP5AY= =AVn0 -----END PGP SIGNATURE----- --=-=-=--