patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Alyssa Ross <hi@alyssa.is>
To: Yureka <yuka@yuka.dev>
Cc: devel@spectrum-os.org
Subject: Re: [DO_NOT_APPLY v3 1/3] add xdp-forwarder
Date: Sat, 06 Sep 2025 18:13:51 +0200	[thread overview]
Message-ID: <87ecsjv9s0.fsf@alyssa.is> (raw)
In-Reply-To: <08193621-065b-466f-8703-5ae5ecf71788@yuka.dev>

[-- Attachment #1: Type: text/plain, Size: 819 bytes --]

Yureka <yuka@yuka.dev> writes:

>>> @@ -7,6 +8,9 @@ option('host', type : 'boolean', value : false,
>>>   option('guest', type : 'boolean',
>>>     description : 'Build tools for Spectrum guests')
>>>   
>>> +option('driver', type : 'boolean',
>>> +  description : 'Build tools for Spectrum driver VMs')
>>> +
>> Should be grouped with host and guest (no blank line between).
>
> There is a blank line in between host and guest, so I don't know what 
> you mean exactly.

I think I was confused by the diff output, sorry.  Let's default it to
false though — the most likely way for this to be reused would be for
people running custom application VMs, so that's what should be built by
default.  Should also rename "guest" to "app", I think — I can do that
myself before applying, if you prefer.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  parent reply	other threads:[~2025-09-06 16:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-01 20:12 [DO_NOT_APPLY v3 0/3] xdp-forwarder Yureka Lilian
2025-09-01 20:12 ` [DO_NOT_APPLY v3 1/3] add xdp-forwarder Yureka Lilian
2025-09-06 12:05   ` Alyssa Ross
     [not found]     ` <08193621-065b-466f-8703-5ae5ecf71788@yuka.dev>
2025-09-06 16:13       ` Alyssa Ross [this message]
2025-09-06 17:07   ` [DO_NOT_APPLY v3 2/3] integrate xdp-forwarder into net-vm Demi Marie Obenour
2025-09-07  0:08     ` Yureka
2025-09-01 20:12 ` Yureka Lilian
2025-09-06 16:08   ` Alyssa Ross
2025-09-01 20:12 ` [DO_NOT_APPLY v3 3/3] docs/architecture: add paragraph about networking Yureka Lilian
2025-09-08 10:05   ` Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ecsjv9s0.fsf@alyssa.is \
    --to=hi@alyssa.is \
    --cc=devel@spectrum-os.org \
    --cc=yuka@yuka.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).