Re: [PATCH 1/2] chromiumOSPackages: improve update.py repo compat

Cole Helbling
2020-05-30T23:55:17Z

On Sat May 30, 2020 at 7:00 PM, Alyssa Ross wrote:
> These changes make chromiumOSPackages.updateScript better understand
> the Repo manifest format[1].
>
> It now properly distinguishes between paths in the Chromium OS source
> tree and paths on the git servers, which are usually not the same.
> For example, chromiumos-overlay is located in the source tree at
> src/third_party/chromiumos-overlay, but on chromium.googlesource.com
> it's located at chromiumos/overlays/chromiumos-overlays. Components
> are now keyed by their location in the Chromium OS source tree (and
> packages have all been updated for this change.)
>
> Additionally, it now understands Repo remotes. This means that it is
> now possible to use a Chromium OS component like Minijail, which is
> hosted on android.googlesource.com rather than
> chromiumos.googlesource.com. This was not previously possible.
>
> [1]:
> https://gerrit.googlesource.com/git-repo/+/HEAD/docs/manifest-format.md
> ---
> .../linux/chromium-os/common-mk/default.nix | 2 +-
> .../linux/chromium-os/crosvm/default.nix | 4 +-
> .../os-specific/linux/chromium-os/default.nix | 2 +-
> .../linux/chromium-os/libqmi/default.nix | 2 +-
> .../linux/chromium-os/minigbm/default.nix | 2 +-
> .../linux/chromium-os/modem-manager/next.nix | 2 +-
> .../linux/chromium-os/modp_b64/default.nix | 2 +-
> pkgs/os-specific/linux/chromium-os/update.py | 56 ++++++++++++-------
> .../linux/chromium-os/upstream-info.json | 40 ++++++-------
> pkgs/os-specific/linux/kernel/linux-cros.nix | 2 +-
> 10 files changed, 64 insertions(+), 50 deletions(-)

Hopefully this means next time I can fulfill my promise of helping
out... Fingers crossed Google doesn't change/break anything between now
and then.

Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>