patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Alyssa Ross <hi@alyssa.is>
To: Demi Marie Obenour <demiobenour@gmail.com>
Cc: Spectrum OS Development <devel@spectrum-os.org>,
	Yureka Lilian <yureka@cyberchaos.dev>
Subject: Re: [PATCH v2] host/rootfs: Don't wait for /dev/dri/card0
Date: Thu, 25 Jun 2026 11:56:39 +0200	[thread overview]
Message-ID: <87fr2b54fc.fsf@alyssa.is> (raw)
In-Reply-To: <aa84319e-5e40-4e41-abba-d85dd4d700fb@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2389 bytes --]

Demi Marie Obenour <demiobenour@gmail.com> writes:

> On 6/24/26 04:55, Alyssa Ross wrote:
>> Alyssa Ross <hi@alyssa.is> writes:
>> 
>>> Demi Marie Obenour <demiobenour@gmail.com> writes:
>>>
>>>> Weston can find a card itself.  If the card is not ready, it will exit,
>>>> but s6 will automatically restart it.
>>>>
>>>> Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
>>>
>>> I don't think this commit message really captures it.  As long as the
>>> card is not hotplugged, it _will_ be ready, as far as I know, because it
>>> will become ready when DRM is loaded, before userspace starts.  This
>>> makes it sound like Weston not finding a card and being restarted by s6
>>> would be routine behaviour, whereas we'd actually not expect to ever see
>>> it, except in the very unusual case of somebody having no cards at boot
>>> and later hotplugging one.  (Even then it's not ideal to need to restart
>>> in a loop, but that case can wait for COSMIC.)
>>>
>>> I suggest the following alternative, which also removes some other
>>> obsolete instances of the same pattern.
>>>
>>> From 71216f0aa36049cbd3c7b7562e6e7ff225a1c810 Mon Sep 17 00:00:00 2001
>>> From: Alyssa Ross <hi@alyssa.is>
>>> Date: Tue, 26 May 2026 16:05:21 +0200
>>> Subject: [PATCH] Stop waiting for /dev/dri/card0
>>>
>>> On the host, which does not run in a well-controlled VM environment,
>>> there might not be a card0 (sometimes you just get card1).  This
>>> causes hangs.  It hasn't been necessary to wait for non-hotplugged DRI
>>> devices to exist since the Nixpkgs kernel set CONFIG_DRM=y.  (If
>> 
>> Alas this is not true upon further investigation.  I saw
>> release/checks/wayland fail with this applied, because while DRM was
>> loaded pre-userspace, DRM_BOCHS still wasn't.  s6 would indeed just
>> restart Weston until it works, but I don't really want a restart loop to
>> be a routine thing…
>
> Is it okay to just let the restart loop happen until Spectrum switches
> to COSMIC?  An alternative would be to use a udev rule and a FIFO,
> but that's extra work that will be thrown away later.

I think it's a small amount of work, and we can reuse some of what we
did before with mdevd, so I'll just do it.  More is needed than just
switching to COSMIC: COSMIC needs to be modified so that it won't refuse
to start up if there are no cards.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

      reply	other threads:[~2026-06-25  9:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-24 20:51 [PATCH] host/rootfs: Automatically select card node Demi Marie Obenour
2026-05-25 17:08 ` Alyssa Ross
2026-05-26  7:31 ` [PATCH v2] host/rootfs: Don't wait for /dev/dri/card0 Demi Marie Obenour
2026-05-26 14:15   ` Alyssa Ross
2026-06-24  8:55     ` Alyssa Ross
2026-06-25  1:07       ` Demi Marie Obenour
2026-06-25  9:56         ` Alyssa Ross [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fr2b54fc.fsf@alyssa.is \
    --to=hi@alyssa.is \
    --cc=demiobenour@gmail.com \
    --cc=devel@spectrum-os.org \
    --cc=yureka@cyberchaos.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).