From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 776BA4291; Thu, 16 Jul 2026 08:29:30 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 59C5341F4; Thu, 16 Jul 2026 08:29:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fhigh-b2-smtp.messagingengine.com (fhigh-b2-smtp.messagingengine.com [202.12.124.153]) by atuin.qyliss.net (Postfix) with ESMTPS id 4E30141F2 for ; Thu, 16 Jul 2026 08:29:25 +0000 (UTC) Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfhigh.stl.internal (Postfix) with ESMTP id 68AD17A00FC; Thu, 16 Jul 2026 04:29:23 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Thu, 16 Jul 2026 04:29:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1784190563; x=1784276963; bh=cKDbvXbNtJ 1lf3QpxmqI/ovs1DPTBlI/NCxZuwvvNoA=; b=Sbf7HlbFFWp2iEmBi9/fIrnfPq 65ZB1d82K0sQXXhVlM5a+zr+/9rs6NoGRmezi3O5pYIS6ratikoydt5N256Km5CU Pzj93qTTmiwkHup9sojnLBBl504n2JC3E3EL5SI0C6jfsS1jxcsEp8iy5KfGoXDU kRkjycUh7AeZjvbkupFn+2wNNMSV0cDRcuSS1ru0TCZuCuJ9WTQPw4Oo1la+z854 n8ObMesOsUNkumx0Q+59NTDTnuHVPQcZT7MYjqk5Ek8Bw6iI9l/aU79RHAC1MAoe S23E/MEx11eyeRVPFgqwsLYox/EMw01oKchnJpFd5mrDmdIJRua0Z6Z/Qw9g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1784190563; x=1784276963; bh=cKDbvXbNtJ1lf3QpxmqI/ovs1DPTBlI/NCx ZuwvvNoA=; b=pHLZheU2G1HkJQ4cvjBt2WcigN7WHPsUYSJgLABeTMLfNYkBAX+ IO9rV2i5Qk2XNZg3t0K5zO2zhy0tEs1pwYkrRyQx4xCuX+h1lbWEz6eLc7iQnlNh w6s9c3QLUcT4TW0tY3AVOg9ewVQiO7WUqGK21kaCNbclNBQyaarHYJbb1f11iVSk /ho7SWlyoRvzPpXlS11vnQM66L6JqgJ7YVoFFO85lE5iWAFK3qwoSbvdUd3SRf3+ qeklK3ECOqlUcfX7OVq4YRnGPkA75auc6nF7jwlUih/ohWw5AQO43sGfaUeHg22i u9kkDLs31BePanYtX5ADQ+6pWSLoj5kLaMQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFZkcmfg6g9aghOCMekeY/DMySZDpI0xfDahb1dgCi5NjqgQt0bbOOVVrnqo1x65g Tjh2Vc0qfs9XZZlHLBa5/pjt0UdHO/Uh3r8ag86y+2EuK+2eWvGhDRPk2VuPqlVmpxwBZW xxT2yjOQoKzG9rkpv7hWaWbHP9o0jAFd6GOvctDjBCOs0Cv62ydKBL0yZkX3NH7SWj2Fjm K28JQMo+cOfjf+ht77M9ZXTwpbyW7EzaeNlL840448U+pmHWSydtTzToKM6qmJKMVo0Cc8 xa4fW9uAbE82W9pUCXJTeoKSsrUx7y7v9LWe+TITW0HZOaa1iwDwdgO+ukF6N8rXwEt3hb 3DuP9xlYJ1cWA7gWY2aS9kypXjHeks324KwnTBSl2xiUGFpjYmyPoz5J+HLs7NCZPEMXeP BvbP07qbmAHD3YHCjO0aOf38YWc/9gCQd6dvl4ny0AJ6H/bB0VJk7QV77DLuAJGQ/OrINi hPOYPotblzjOiFQ8PNmhjUjvywPiXScMlB+xMmfrh50m1bOlDkqgXE+YDIk5zvdBJLJ0Gm muO4FtBmEOxBEQPP+la2G0m0zXh6bLZ8IhDMemsaDDD+APqcoJ9kbRvGX9DP+8JjicK9Wb 06Q32lF0W84IluSGEFiGsGUlO0NQx8QRdOD2R1xQc1522PDPkHWvV7NalEDA X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 16 Jul 2026 04:29:22 -0400 (EDT) Received: by mbp.qyliss.net (Postfix, from userid 1000) id 3CBC18957709; Thu, 16 Jul 2026 10:29:19 +0200 (CEST) From: Alyssa Ross To: Demi Marie Obenour Subject: Re: Networking test runs run-vmm twice with the same VM ID In-Reply-To: References: Date: Thu, 16 Jul 2026 10:29:18 +0200 Message-ID: <87h5lze3s1.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: CSNAELIQLIPVI4XRDYCSMA42FOZBVXMV X-Message-ID-Hash: CSNAELIQLIPVI4XRDYCSMA42FOZBVXMV X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Spectrum OS Development X-Mailman-Version: 3.3.10 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Demi Marie Obenour writes: > The networking test runs run-vmm twice with the same VM ID. > If it waits for the previous cgroup to be empty, the second > call waits forever. > > Is this expected? I would expect that run-vmm is only called > once. Assuming you mean run twice in sequence, rather than run twice at the same time, then yes, it is expected. The way it works at the moment is that imported VMs have a VM ID assigned when they're imported, and they can then be started any number of times. When the VM shuts down, the VMM exits, so if the VM is started again after that, run-vmm will be run again with the same VM ID. If this were not the case, VM IDs could not be assigned at import time, and stay the same between successive boots of the same VM. If your cgroup is not being emptied as expected, that is a bug, regardless of whether it ends up being used again, because there shouldn't be lingering processes or cgroups hanging around forever. It sounds like we should have a test that confirms that this doesn't happen, if it's hard to get right. The networking test does do something slightly unusual, which is that it restarts the VMM with s6-svc -Wr -r, rather than e.g. via the Cloud Hypervisor API. I would expect that this runs the finish script, but might be worth confirming. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRV/neXydHjZma5XLJbRZGEIw/wogUCaliWXgAKCRBbRZGEIw/w oqfXAP9lzjsi4iDdZipoPiYjjjv1oIwd0hh76C6A64F6PVZ8vgD/Ut7LvFnrDK43 ezNGiE6fB/8PZgSqdGWM5Pxg3sr3NA8= =WTjO -----END PGP SIGNATURE----- --=-=-=--