From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id BD1F0F368; Sat, 06 Sep 2025 16:08:45 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id B3D27F34D; Sat, 06 Sep 2025 16:08:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fhigh-b6-smtp.messagingengine.com (fhigh-b6-smtp.messagingengine.com [202.12.124.157]) by atuin.qyliss.net (Postfix) with ESMTPS id 977CAF34B for ; Sat, 06 Sep 2025 16:08:41 +0000 (UTC) Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfhigh.stl.internal (Postfix) with ESMTP id 0614C7A03AE; Sat, 6 Sep 2025 12:08:39 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Sat, 06 Sep 2025 12:08:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1757174919; x=1757261319; bh=Qce9JYeblV Qudq8bQuxtULb3caWPggq8UpUhkXLcpgg=; b=ddnCMb4qxxcf+vqZxWxcU2LZJQ 3bmG15y8nx/MSYnwIPn84TYBMlxAaNMe7jtZ+XoCtsKPNmooiB2ehLaRDrLLyp2o MazA8h7wZtlnnTgTiKGqfOlDAuhh9SKj5wBQBcY2lWVd92wf+rAFqMTKSmK0Syl3 x1xfFH4IUCss1/QKrytDyHQ3u4/usOxig4E6xKeFCuamXclclQa7iVqKNt3FIIsX lIiTRcbjMhlGWyAInOvn3DYbN5jNOCjPuMx83NBKqvAaBx4tqd8hRRPSnDdo9ZJC IPy46w3RYSEhC2qQiy1TJa2bt6xQ+2oUGgJVCHhtZPj91BvHtJeisBkzfP1Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1757174919; x=1757261319; bh=Qce9JYeblVQudq8bQuxtULb3caWPggq8UpU hkXLcpgg=; b=OfD1ebtV5Ahvf22sZOj7POZUSS549k8GWQVSIpvEloMgx6irOBN lGuTkmcOoSeL5jokMOdtQgRNdsVqwNr4qeT26me1ReGhUpWxf308JgCGtPylJxAh hcxb6Eq9TOg8P+/4iWXPDCm0SK3mVEYjg3BUEHPA7mr2FXZhoSfbkkcP3uqXqY/e qIYowmtmk7A5a/L1B4oi0hS5NEfhbGqg2jYKW0sbsaAb1y7tX3bze2bTBGGHCUgR or7fFBl4NZVdUa5aTKjdTe3EpJ6bz7ldgDVwlJCBlarQ+mXfkinuPu2+xUyefGG/ eL8VvO0G9KtjmP8L0xfPT6qRGkYBRalvGxg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdduvddvudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufgjfhffkfggtgesghdtreertddttdenucfhrhhomheptehlhihsshgrucft ohhsshcuoehhihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepieduffeuie elgfetgfdttddtkeekheekgfehkedufeevteegfeeiffetvdetueevnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhephhhisegrlhihshhsrgdrih hspdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopeih uhhrvghkrgestgihsggvrhgthhgrohhsrdguvghvpdhrtghpthhtohepuggvvhgvlhessh hpvggtthhruhhmqdhoshdrohhrgh X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 6 Sep 2025 12:08:39 -0400 (EDT) Received: by mbp.qyliss.net (Postfix, from userid 1000) id 4DF401657B96; Sat, 06 Sep 2025 18:08:36 +0200 (CEST) From: Alyssa Ross To: Yureka Lilian Subject: Re: [DO_NOT_APPLY v3 2/3] integrate xdp-forwarder into net-vm In-Reply-To: <20250901201248.19794-3-yureka@cyberchaos.dev> References: <20250901201248.19794-1-yureka@cyberchaos.dev> <20250901201248.19794-3-yureka@cyberchaos.dev> Date: Sat, 06 Sep 2025 18:08:34 +0200 Message-ID: <87h5xfva0t.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: PWUYBL7B4BAZNWCD4DQYNJXCVKGWDABU X-Message-ID-Hash: PWUYBL7B4BAZNWCD4DQYNJXCVKGWDABU X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Yureka Lilian writes: > diff --git a/vm/sys/net/default.nix b/vm/sys/net/default.nix > index b5873eb..10cb382 100644 > --- a/vm/sys/net/default.nix > +++ b/vm/sys/net/default.nix > @@ -1,23 +1,22 @@ > # SPDX-License-Identifier: MIT > # SPDX-FileCopyrightText: 2021-2023 Alyssa Ross > +# SPDX-FileCopyrightText: 2025 Yureka Lilian >=20=20 > -import ../../../lib/call-package.nix ({ lseek, src, terminfo, pkgsStatic= }: > -pkgsStatic.callPackage ( > +import ../../../lib/call-package.nix ({ lseek, spectrum-guest-tools, src= , terminfo, pkgsMusl }: > +pkgsMusl.callPackage ( Switching to non-static really ought to be a separate patch, with rationale explained in the message. >=20=20 > { lib, stdenvNoCC, nixos, runCommand, writeClosure > , erofs-utils, jq, s6-rc, util-linux, xorg > -, busybox, connmanMinimal, dbus, execline, kmod, linux_latest, mdevd, nf= tables > -, s6, s6-linux-init > +, busybox, dbus, execline, kmod, linux_latest, mdevd > +, s6, s6-linux-init, xdp-tools > }: >=20=20 > let > inherit (lib) concatMapStringsSep; > inherit (nixosAllHardware.config.hardware) firmware; >=20=20 > - connman =3D connmanMinimal; > - > packages =3D [ > - connman dbus execline kmod mdevd s6 s6-linux-init s6-rc > + dbus execline kmod mdevd s6 s6-linux-init s6-rc xdp-tools >=20=20 > (busybox.override { > extraConfig =3D '' > @@ -30,13 +29,16 @@ let > CONFIG_RMMOD n > ''; > }) > - > - (nftables.override { withCli =3D false; }) > ]; >=20=20 > # Packages that should be fully linked into /usr, > # (not just their bin/* files). > - usrPackages =3D [ connman dbus firmware kernel terminfo ]; > + usrPackages =3D [ > + dbus firmware kernel terminfo > + > + # for xdp-forwarder > + spectrum-guest-tools Shouldn't this be spectrum-driver-tools? > + ]; >=20=20 > packagesSysroot =3D runCommand "packages-sysroot" { > inherit packages; --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRV/neXydHjZma5XLJbRZGEIw/wogUCaLxcggAKCRBbRZGEIw/w ov3UAQDLdV+M1Ji8dAukzfIqv1fsoTgEq8UYsFdq29fHd5+8xwD/a4Q26a76zn2u GJnkI2WRlZxAVzz0Cy78sRAXUHJ0cgs= =yeYR -----END PGP SIGNATURE----- --=-=-=--