From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,URIBL_SBL_A autolearn=unavailable autolearn_force=no version=3.4.5 Received: by atuin.qyliss.net (Postfix, from userid 496) id A712A191BD; Sat, 29 May 2021 14:08:56 +0000 (UTC) Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 8D9CC191A4; Sat, 29 May 2021 14:08:42 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id A151D19131; Sat, 29 May 2021 14:08:40 +0000 (UTC) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by atuin.qyliss.net (Postfix) with ESMTPS id 09E5C19130 for ; Sat, 29 May 2021 14:08:37 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 96B4A5C018F; Sat, 29 May 2021 10:08:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sat, 29 May 2021 10:08:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm3; bh=u2KUlf4YNADYRmYvAVk06szQ5+ m6U29WSUBTN1P0hDY=; b=drM/jBCUfrpPP9r+B4oQqn9HKVIGmXTbkfC9sFxCcn kTajb4CS+OwFnb6tp37T2MVcyOnnOq3FOeKIyFbajfdKownPQ/AmBL/8b0mofizr Gsr1bqc35IIUnbB3Mo9HfuRgT1KMWOHw3cV+Gmiy0Ubd8NiG1q42DGrfJQkF0pR4 SeyD1uzeGRKvTNJDSoMrUk3TLZurX3iVaCGxoCeCxRPQkFN8x0OazyOhdQYyq4KS sHmkXeW4ioVSeqBwltGawJ9ZezRB16OCsfWcyHyGPRxdEBfAyTOyL1X/ENRYtZ/6 H+7WQjZYPJTNlfxFwXFyjvfzveEw3+GVs+a7Uh/Fe6mw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=u2KUlf 4YNADYRmYvAVk06szQ5+m6U29WSUBTN1P0hDY=; b=nC9f2tSnAQRMODk4aMI9zh BdfL07BmJHgW+keizOdh2CtpOvRKWlmM8EoNlha4fqYyAOOBF0LX+aI5nRPAcWEC 316W9pjh2XsY8BdbFwhx4Ep5QBs0PVu+WphFmqOXKarxa3yt3JfTnoBCqWwgpafR 0rDJVReGMKAvA7QPq2a5azIKw5udoMpb8gMZRoyLwvQxKBAXu1i2gTF7daOocp7e Oi9Xr3ErtZRfmtnKPMGFEle8WrFRcfee3KcDHLnYyv8EukmgbIHGjOyznk5XQ4FH VEbR38QAPao4k0Mw4kEwbWLq3uocI9hHNZIp1AdmKP5IsCZ9ceJafX1wvqIa397A == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdekledgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfggtgesghdtreertddttdenucfhrhhomheptehlhihsshgr ucftohhsshcuoehhihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepiefhve etveeludegtdeludehieevgefhjeffueffjeeuleeutdehfeduhfetheefnecuffhomhgr ihhnpehgohhoghhlvghsohhurhgtvgdrtghomhenucfkphepgeeirdektddrudefkedrje efnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhephhhi segrlhihshhsrgdrihhs X-ME-Proxy: Received: from x220.qyliss.net (p2e508a49.dip0.t-ipconnect.de [46.80.138.73]) by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 29 May 2021 10:08:34 -0400 (EDT) Received: by x220.qyliss.net (Postfix, from userid 1000) id 3395C1660; Sat, 29 May 2021 14:08:34 +0000 (UTC) From: Alyssa Ross To: Cole Helbling Subject: Re: [PATCH crosvm v2] crosvm: support setting guest MAC from tap-fd In-Reply-To: References: Date: Sat, 29 May 2021 14:08:31 +0000 Message-ID: <87h7ilr5sw.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Message-ID-Hash: J2JLSV25GWREXG3ECVVGFW3OCTZYDF2G X-Message-ID-Hash: J2JLSV25GWREXG3ECVVGFW3OCTZYDF2G X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.4 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain "Cole Helbling" writes: > On Tue May 18, 2021 at 1:36 AM PDT, Alyssa Ross wrote: >> "Cole Helbling" writes: >> > Is there a better Error variant for this? `TooManyArguments` seems not- >> > completely-accurate when specifying an already-in-use FD. >> >> Here are all the variants. Do you think there's a better one? >> >> https://chromium.googlesource.com/chromiumos/platform/crosvm/+/f35d2c43ff19520855cffee761dc8899c5a439a1/src/argument.rs#49 >> >> The only other one I can see that might be applicable would be >> InvalidValue... > > Yeah, I think InvalidValue would be a better choice (IMHO). The user hasn't > provided too many arguments; they just provided a invalid TAP FD because it's > already in use. Hmm, I agree with you, but I just went to make this change, and noticed that everywhere else in the file, they use TooManyArguments for this sort of case. e.g. "wayland socket name already used". So I think it's probably best to stick with TooManyArguments for consistency (and that's probably why I did it like that in the first place, although I don't remember). --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmCySuAACgkQ+dvtSFmy ccAzmw/+L0Ku/XHlxaR8nc4VvEdLsTU80DkbYhKn/p4fgAoqHFMSM6GiVDcwfC9F 9XmZ+ZMQfHGX/a/fHU0SQ/phEI/2dJ2O2lxF/zxaWl8O3TGDrxaIybprYqw8RbXL 2mrKd3Kz4imNfxHotaIQH8Md7dMAtJUwvFB1WuAKbXuzbxQ5+WvHsjjuYTV0lDTP okqBZSohpFht+leiWUmYQaexcg7tydd1jz0BV3uQlFUS/6qEC8F+lXqcY1dgmRVm 3PgxPtgUuesjANewXq1KPciAe7kI/G9CJ2fMrUuU8YYCfJx+fijOIs+AQ/jNzHMj 7DyQggSPul2wl0jVoFI9FWnOzA8dtXjMOkhyIoafbv21W7On6CZ1AfutyNk57M/r X7oR4w6+H5QG8YujKu8GImR0R9YU4amwVmsPc4nnaJCTpyxzW1EGMFpJCvHQs5Mp +ObxGwmh799NrvoU154oHU2jSEgdLC9zs8302JLlHFJwovDOO7ISZCBAPHimoKe8 HGBKJ6QKfWMVGEUSfPVE+zpWY3nleANpto/GSDy/CQhBpyHqEvK92RQjZ9YRyxwo dOa6ZNUz8+cxXd6C3DKvt8Do6wfQciKLiCrPP+HocP//ZjVeVzAlVDKHMu0T196c xpK8BDVJaeqIwP4vhe1It+A7vLDxdkosniVrry9t/9ufbqD6FHs= =BFDP -----END PGP SIGNATURE----- --=-=-=--