From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 92FEA6C96; Tue, 16 Dec 2025 12:48:22 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id BA3A56C91; Tue, 16 Dec 2025 12:48:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fhigh-b5-smtp.messagingengine.com (fhigh-b5-smtp.messagingengine.com [202.12.124.156]) by atuin.qyliss.net (Postfix) with ESMTPS id EB3116C8C for ; Tue, 16 Dec 2025 12:48:18 +0000 (UTC) Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfhigh.stl.internal (Postfix) with ESMTP id 74AD17A0193; Tue, 16 Dec 2025 07:48:16 -0500 (EST) Received: from phl-frontend-01 ([10.202.2.160]) by phl-compute-05.internal (MEProxy); Tue, 16 Dec 2025 07:48:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1765889296; x=1765975696; bh=SPfLH85pzr 6BNsABIrFumcKBEnIbk3BdpuPe6aJklik=; b=StsOCz7+F6Uir/gUQWKjUKVl0q EgxP/SaJMjKrMnEwU0wIug7XaDX/I4RAFCy3y6m3Lxp8hJ++LtDrwJ/gP/y4ZRX/ kaHZiw2qyf4EIQDCB1M7Le5G6x9ggV4uppLZA2Jrw8AFtkJvEpo9JQiNlP6qk5dc Ij3h3anpji1ISTJ+Ambl6jtKOZaElneqk91PaDQrioUZ2lEF+MAUMlghs50QmkTl g7BzXRNmq/Xq6NZBffft+jEyxnVahfDMRHeLrhe9RRVlCWlF3EjR8H354lba+HAr iWPeRXhPZ3E7oIvZcKAV8E1UgArtVDtJ2pI3gnZCI6f/944A66b/0zpwdMSg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1765889296; x=1765975696; bh=SPfLH85pzr6BNsABIrFumcKBEnIbk3BdpuP e6aJklik=; b=JZp4/ZrAMKD9jYLgROY+n9NpAReRC4bbMVbH/93QhPNR45Fcdk7 UVecIjnkTeOuh2WjFB6S7rQ2iCv2rAFtJV0+SD62mz+Ko0zBei76paXCHp94QOFm vj2+liE5oWEUYucTqsrsM4vlZLCw3V6Ox5K3vdvP22333r0KdUE5+y7NIy85vMFe bJ4EzJ1GR0qpVOkvxDHaVI3m5UMqf1Qi+TxIVVB3vJ5RJwmVR1Hx40QxmQqpGXpR lQRut1hB4w58dJiN2c8+J/hiJ4Ft9v/PzhSAiEVj9xkOboyibU5bqwNS1Y3WLmp5 M/JOqZNF1SFP6OFvcQ2FLeY3y7qRJtmq44Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdefleejvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufgjfhffkfggtgesghdtreertddtjeenucfhrhhomheptehlhihsshgrucft ohhsshcuoehhihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepteehvedugf ejgfehhfeijeduleekleejgedvkeeuuefhhfegvdevfeetveegteeinecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhephhhisegrlhihshhsrgdrih hspdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegu vghmihhosggvnhhouhhrsehgmhgrihhlrdgtohhmpdhrtghpthhtohepuggvvhgvlhessh hpvggtthhruhhmqdhoshdrohhrgh X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 16 Dec 2025 07:48:15 -0500 (EST) Received: by fw12.qyliss.net (Postfix, from userid 1000) id E90387C97DF5; Tue, 16 Dec 2025 13:48:10 +0100 (CET) From: Alyssa Ross To: Demi Marie Obenour Subject: Re: [PATCH 1/2] host/rootfs: remove /proc/kcore bind mounts In-Reply-To: <87o6nyycn4.fsf@alyssa.is> References: <20251215122707.116898-1-hi@alyssa.is> <3ef8f200-e265-4466-bff3-63fdee58a984@gmail.com> <87o6nyycn4.fsf@alyssa.is> Date: Tue, 16 Dec 2025 13:48:09 +0100 Message-ID: <87ike6y4mu.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: M7HVBGP54HAWPMCDVFMTTT23GIABV7PR X-Message-ID-Hash: M7HVBGP54HAWPMCDVFMTTT23GIABV7PR X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Alyssa Ross writes: > Demi Marie Obenour writes: > >> On 12/15/25 07:27, Alyssa Ross wrote: >>> Neither of these services run as root any more, so they don't have >>> access to /proc/kcore any more regardless. (Also we don't have >>> /proc/kcore on aarch64 so this previously errored there.) >>>=20 >>> Fixes: 62590b8 ("host/rootfs: Sandbox crosvm") >>> Fixes: ec47d36 ("host/rootfs: Sandbox Cloud Hypervisor") >>> Signed-off-by: Alyssa Ross >>> --- >>> .../service/vm-services/template/data/service/vhost-user-gpu/run | 1 - >>> host/rootfs/image/usr/bin/run-vmm | 1 - >>> 2 files changed, 2 deletions(-) >>>=20 >>> diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/vm-s= ervices/template/data/service/vhost-user-gpu/run b/host/rootfs/image/etc/s6= -linux-init/run-image/service/vm-services/template/data/service/vhost-user-= gpu/run >>> index b1f9bac..e063a82 100755 >>> --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/vm-services= /template/data/service/vhost-user-gpu/run >>> +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/vm-services= /template/data/service/vhost-user-gpu/run >>> @@ -40,7 +40,6 @@ bwrap >>> --tmpfs /proc/irq >>> --remount-ro /proc/irq >>> --ro-bind /dev/null /proc/timer_list >>> - --ro-bind /dev/null /proc/kcore >>> --ro-bind /dev/null /proc/kallsyms >>> --ro-bind /dev/null /proc/sysrq-trigger >>> -- >>> diff --git a/host/rootfs/image/usr/bin/run-vmm b/host/rootfs/image/usr/= bin/run-vmm >>> index 0640239..e30b14c 100755 >>> --- a/host/rootfs/image/usr/bin/run-vmm >>> +++ b/host/rootfs/image/usr/bin/run-vmm >>> @@ -113,7 +113,6 @@ bwrap >>> --tmpfs /proc/irq >>> --remount-ro /proc/irq >>> --ro-bind /dev/null /proc/timer_list >>> - --ro-bind /dev/null /proc/kcore >>> --ro-bind /dev/null /proc/kallsyms >>> --ro-bind /dev/null /proc/sysrq-trigger >>> -- >>>=20 >>> base-commit: 6ceeb9b236cc50d2bba90068533ca1b7ff229c8b >> >> /proc/sysrq-trigger and /proc/timer_list can also be dropped, >> as they are not accessible to unprivileged users. > > And what about the others? I see systemd just makes them all read-only > =E2=80=94 is that only to protect against root? Do we still need to hide > /proc/sys, /proc/scsi, /proc/acpi, /proc/fs, and /proc/irq? The only > entry I see that's writable by non-root in any of those on my NixOS > system is /proc/sys/kernel/ns_last_pid, which doesn't look very harmful= =E2=80=A6 I'm just going to drop the /proc/scsi bind mount as well for now to fix aarch64, but if you still think it's necessary we can instead do the kernel config change. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQQGoGac7QfI+H5ZtFCZddwkt31pFQUCaUFVCQAKCRCZddwkt31p FbR1AP9qDGy1O4GzKUl0JTzBaBGhOE0VRE19DFkyrvmr4i1hyAD9GmZz80XxB2Bu h9ci1T4WKA2n90hoQbMh9SDZj5Wyowg= =v8pQ -----END PGP SIGNATURE----- --=-=-=--