Re: [PATCH 2/3] img/app: dbus: don't listen on VSOCK

[Alyssa Ross <hi@alyssa.is>]

[-- Attachment #1: Type: text/plain, Size: 1741 bytes --]

Demi Marie Obenour <demiobenour@gmail.com> writes:

> On 11/13/25 12:56, Alyssa Ross wrote:
>> Demi Marie Obenour <demiobenour@gmail.com> writes:
>> 
>>>> diff --git a/img/app/image/etc/s6-rc/dbus-vsock/notification-fd.license b/img/app/image/etc/s6-rc/dbus-vsock/notification-fd.license
>>>> new file mode 100644
>>>> index 0000000..0d3d47c
>>>> --- /dev/null
>>>> +++ b/img/app/image/etc/s6-rc/dbus-vsock/notification-fd.license
>>>> @@ -0,0 +1,2 @@
>>>> +SPDX-License-Identifier: CC0-1.0
>>>> +SPDX-FileCopyrightText: 2025 Alyssa Ross <hi@alyssa.is>
>>>> diff --git a/img/app/image/etc/s6-rc/dbus-vsock/run b/img/app/image/etc/s6-rc/dbus-vsock/run
>>>> new file mode 100755
>>>> index 0000000..37fae7d
>>>> --- /dev/null
>>>> +++ b/img/app/image/etc/s6-rc/dbus-vsock/run
>>>> @@ -0,0 +1,17 @@
>>>> +#!/bin/execlineb -P
>>>> +# SPDX-License-Identifier: EUPL-1.2+
>>>> +# SPDX-FileCopyrightText: 2025 Alyssa Ross <hi@alyssa.is>
>>>> +
>>>> +if { modprobe vsock }
>>>> +
>>>> +export LISTEN_FDS 1
>>>> +getpid LISTEN_PID
>>>> +export SYSTEMD_LOG_LEVEL notice
>>>> +
>>>> +systemd-socket-activate -l vsock::219 --now
>>>> +
>>>> +# Notify readiness.
>>>> +if { fdmove 1 3 echo }
>>>> +fdclose 3
>>>> +
>>>> +socat ACCEPT-FD:4,fork UNIX-CONNECT:/run/session-bus
>>>
>>> I'd prefer to use NOTIFY_SOCKET here.
>> 
>> Then we have to run a whole background process to translate the
>> systemd protocol to the s6 one.  Doesn't seem worth it to me.
> Whoops, wrong environment variable name :).  I meant $LISTEN_FDS.

I still don't understand what you mean.  You'd like this to calculate
2 + LISTEN_FDS, and substitute that into the socat command line, even
though we know the result will always be 4?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]