From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 53B5F239B; Tue, 28 Oct 2025 12:58:20 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id CC965234A; Tue, 28 Oct 2025 12:58:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fhigh-a7-smtp.messagingengine.com (fhigh-a7-smtp.messagingengine.com [103.168.172.158]) by atuin.qyliss.net (Postfix) with ESMTPS id 7737C2347 for ; Tue, 28 Oct 2025 12:58:15 +0000 (UTC) Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfhigh.phl.internal (Postfix) with ESMTP id B2A28140035C; Tue, 28 Oct 2025 08:58:13 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Tue, 28 Oct 2025 08:58:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1761656293; x=1761742693; bh=WZ+qIFYNGg dj3uzaByB7scFRtOQrIpQd4pjksdL/EjE=; b=YOrkRWLUTSn14LwhqLGL3FtMyC UdQQVod6XKqePQ5bpNdva8qlCg410E+lL/l83VszxIdYRJ1udKrk51c6Dh0pJg7l 9FqpO+sNJIYXc0fJWGzMUtnS0SGkLIzgXe+5+BZXnVoF6nEoD0AuckDVfWZD8ZW7 1fKuMwTd4BRqMP1q4k+bfU/kV2jYvd3zaxYHl9pYMRT7UcRjDnfli8s/iL5a5fAj WpgFLaJNLjOVcNZ4Q9xNszC4Mge/CyhpOwJWNBCMFyGIV330pj8F4FR9xfY3wyXR Hj+VCZKZM1khcalen96ahl4Y9fAOO+CGkfDhLz7qFC0wE3dTSv4B4R8KBWTw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1761656293; x=1761742693; bh=WZ+qIFYNGgdj3uzaByB7scFRtOQrIpQd4pj ksdL/EjE=; b=J7HalrsNkJZZcVSdjhekstyV/H9gnlNya3ZND/utHEl3Ao+0Spd ehwanSaY28BtYeGcYZa95TbYB/HreR9jqOV6yDh0JC3rcZ7GPiTlTysz+ZuLlLZW OfFUfm6vCVZYKFXECA6C0ak4Bype4JQ+x/QhMml4kPlMo3q6T8iKqCAMJ8EmRTXu dxuMwICbXix5irUCx8ZCmKXpfUO6CXMpN1UU0VDON5ZFeCHVuhmM3IhP792d8cng xfByCKfhX8o7LDgqqnDqlVG2A1Rfop0RorwSuB5xHvPhSLRFyDzpNwb41ikUBY7l r9cXOJwnLSCM6wzBYzGe2ty/fXO5bOU0FYA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdduiedtleduucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefujghffffkgggtsehgtderredttddtnecuhfhrohhmpeetlhihshhsrgcu tfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeffieelie ekleeujeeifeejgfeuveejgeelhfdvkeffteevgefhkeekuefgfefgffenucffohhmrghi nhepnhhigidruggvvhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehhihesrghlhihsshgrrdhishdpnhgspghrtghpthhtohepvddpmhhouggv pehsmhhtphhouhhtpdhrtghpthhtohepuggvmhhiohgsvghnohhurhesghhmrghilhdrtg homhdprhgtphhtthhopeguvghvvghlsehsphgvtghtrhhumhdqohhsrdhorhhg X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Oct 2025 08:58:13 -0400 (EDT) Received: by mbp.qyliss.net (Postfix, from userid 1000) id EDF5961DE66F; Tue, 28 Oct 2025 13:57:56 +0100 (CET) From: Alyssa Ross To: Demi Marie Obenour Subject: Re: [PATCH] Add dontFixup=true to derivations that build images In-Reply-To: <20251025-dont-fixup-v1-1-9e10c24efbc3@gmail.com> References: <20251025-dont-fixup-v1-1-9e10c24efbc3@gmail.com> Date: Tue, 28 Oct 2025 13:57:56 +0100 Message-ID: <87ikfzmbe3.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: QWBR7GRVJEEGR7TI6CNQOAQ23PVMUUFU X-Message-ID-Hash: QWBR7GRVJEEGR7TI6CNQOAQ23PVMUUFU X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Spectrum OS Development X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Demi Marie Obenour writes: > This prevents lengthy and pointless scans of large image files. > dontFixup is added to the derivations that already used > unsafeDiscardReferences. Both dontFixup and unsafeDiscardReferences are > added to a derivation that builds an ext4 filesystem image. > > Signed-off-by: Demi Marie Obenour > --- > host/initramfs/default.nix | 3 +++ > host/rootfs/default.nix | 1 + > img/app/default.nix | 2 ++ > release/checks/integration/default.nix | 2 ++ > release/combined/default.nix | 3 +++ > release/combined/eosimages.nix | 1 + > release/live/default.nix | 2 ++ > vm-lib/make-vm.nix | 1 + > vm/sys/net/default.nix | 2 ++ > 9 files changed, 17 insertions(+) Good idea! > diff --git a/release/checks/integration/default.nix b/release/checks/inte= gration/default.nix > index 570918613e083b0c2d7c82486544b6405ae5ea89..582a4be8df3098ddaf318b7da= c60690c2f8b2304 100644 > --- a/release/checks/integration/default.nix > +++ b/release/checks/integration/default.nix > @@ -37,6 +37,8 @@ let >=20=20 > userData =3D runCommand "user-data.img" { > nativeBuildInputs =3D [ e2fsprogs tar2ext4 ]; > + unsafeDiscardReferences =3D true; > + dontFixup =3D true; > } '' > tar -Pcvf root.tar \ > --transform=3Ds,^${appimage},test.appimage, ${appimage} \ This is not correct, because 1) unsafeDiscardReferences is an attribute set; 2) it doesn't do anything without __structuredAttrs. https://nix.dev/manual/nix/2.26/language/advanced-attributes#adv-attr-unsaf= eDiscardReferences So I'm going to make a standalone commit first that adds __structuredAttrs and unsafeDiscardReferences here, and then apply the rest of this. I'll also tweak it to group __structuredAttrs, unsafeDiscardReferences, and dontFixup, so it's clear they should be applied together if being copied. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRV/neXydHjZma5XLJbRZGEIw/wogUCaQC91AAKCRBbRZGEIw/w oiI+AQDf07lvLORrWlvHeuGhU89+qC8AxSps+SV43bpsXphnuAD/WVOdEnqtGBuc ddxga4qOQ+JzofTUDDM2V6Au7Kj/mgU= =fZzN -----END PGP SIGNATURE----- --=-=-=--