Re: [PATCH v2 2/2] chromiumOSPackages: 81.12871.0.0-rc1 -> 83.13020.0.0-rc1

[Alyssa Ross <hi@alyssa.is>]

[-- Attachment #1: Type: text/plain, Size: 3678 bytes --]

> When running `nix-build . -A spectrumPackages.spectrum-vm` with these
> two patches applied, vm_protos fails to build:
>
>     [23/52] ACTION //vm_tools/proto:fuzzer-protos_gen(//common-mk/toolchain:toolchain)
>     /usr/share/proto: warning: directory does not exist.
>     [26/52] CXX obj/out/Release/gen/include/vm_protos/proto_bindings/libfuzzer-protos.fuzzer.grpc.pb.o
>     FAILED: obj/out/Release/gen/include/vm_protos/proto_bindings/libfuzzer-protos.fuzzer.grpc.pb.o
>     c++ -MMD -MF obj/out/Release/gen/include/vm_protos/proto_bindings/libfuzzer-protos.fuzzer.grpc.pb.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Igen/include -I../../common-mk -I/usr/include -Igen -Igen -Igen -Igen -Wall -Wunused -Wno-unused-parameter -Wunreachable-code -ggdb3 -fstack-protector-strong -Wformat=2 -fvisibility=internal -Wa,--noexecstack -Wimplicit-fallthrough -Werror --sysroot= -fPIE -fvisibility=default -pthread -I/nix/store/pjl2q3lny3c18ypqjcv0q3akyq89hg2i-grpc-1.28.1/include -I/nix/store/hya0y6slws66h99njc2yiz02irfv4n62-openssl-1.1.1g-dev/include -I/nix/store/mfpg3sk5vk9rm99hbpmd3dgvxqybd391-protobuf-3.8.0/include -pthread -I/nix/store/pjl2q3lny3c18ypqjcv0q3akyq89hg2i-grpc-1.28.1/include -I/nix/store/hya0y6slws66h99njc2yiz02irfv4n62-openssl-1.1.1g-dev/include -I/nix/store/mfpg3sk5vk9rm99hbpmd3dgvxqybd391-protobuf-3.8.0/include -Wno-unreachable-code -std=gnu++14 -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -Wno-psabi -c gen/include/vm_protos/proto_bindings/fuzzer.grpc.pb.cc -o obj/out/Release/gen/include/vm_protos/proto_bindings/libfuzzer-protos.fuzzer.grpc.pb.o
>     In file included from gen/include/vm_protos/proto_bindings/fuzzer.grpc.pb.cc:5:
>     gen/include/vm_protos/proto_bindings/fuzzer.pb.h:38:10: fatal error: vm_crash.pb.h: No such file or directory
>        38 | #include "vm_crash.pb.h"
>           |          ^~~~~~~~~~~~~~~
>     compilation terminated.
>     ninja: build stopped: subcommand failed.
>     builder for '/nix/store/8asskz117p1nhirxaa4pwa0caayxg6c5-vm_protos-83.13020.0.0-rc1.drv' failed with exit code 1

That's interesting -- I can't reproduce this:

    $ NIX_PATH= nix-build -A chromiumOSPackages.vm_protos
    /nix/store/2dn0l8bb33ww5fcg09n30c3fpag6lc39-vm_protos-83.13020.0.0-rc1

I notice that our outPaths for vm_protos are different.  What commit are
did you apply the patches onto?  (For me cfa1e27fdfb.)  Do you have some
global overlay that could be changing things (try with NIX_PATH= as
above to make sure)?

FWIW:

    $ NIX_PATH= nix-build -A chromiumOSPackages
    /nix/store/rgb6lg8jybz1y4nvxx1am5d1137k49ai-chromiumos-overlay
    /nix/store/y7psz0mh8gnlhjg4ik2pqdf209k9sanr-crosvm-83.13020.0.0-rc1
    /nix/store/xw1zkd4bssmrkii1h7vjwq8hs321rssp-dbus-interfaces
    /nix/store/r11gn34ca9r1ac2cf6bc3qg6nb2k1380-dbus-properties
    /nix/store/81962ah6xqcpklp1cxz051dgy0dbjvsm-libqmi-unstable-2019-12-16
    /nix/store/g346jzm6lamf69ysi4lm4m12gwd2347k-linux-5.4.28
    /nix/store/1bqdkvqncnm5njpf44jnsi4lf5cr2jfp-linux-headers-5.4.28
    /nix/store/fyq3kqc87ic6cby31sn498mp6r8lppyw-minigbm
    /nix/store/a53b0zgzrcfq8vbjbi9f9l1ada15k8my-modem-manager-chromiumos-unstable-2012-04-10
    /nix/store/722sj3qd8wbnf9phgp6l6a3b9cfyxihv-modem-manager-chromiumos-next-unstable-2019-10-17
    /nix/store/0zr8d7ba2gvv8fgzkykk9jkrn70k1r9y-modp_b64-83.13020.0.0-rc1
    /nix/store/7df2bcbd0q5kkqwpjapm1yn9aqd2lyyg-protofiles-0.0.36
    /nix/store/p7vl9kg5cynasqsvpi5j4saqgmsnlszw-sommelier-83.13020.0.0-rc1
    /nix/store/2dn0l8bb33ww5fcg09n30c3fpag6lc39-vm_protos-83.13020.0.0-rc1

Are all of those different for you, or just some?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]