From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.3 (2019-12-06) on atuin X-Spam-Level: X-Spam-Status: No, score=-1.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.3 Received: by atuin.qyliss.net (Postfix, from userid 496) id 2F4AF2402C; Mon, 1 Jun 2020 22:45:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 6EC6D2400C; Mon, 1 Jun 2020 22:45:04 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id AAA3B24009; Mon, 1 Jun 2020 22:45:02 +0000 (UTC) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by atuin.qyliss.net (Postfix) with ESMTPS id 1416B24007 for ; Mon, 1 Jun 2020 22:44:58 +0000 (UTC) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 985515C009C; Mon, 1 Jun 2020 18:44:56 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 01 Jun 2020 18:44:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm3; bh=aHU9dWdXyakDMIaSMrH7zXMQfu fipPB8OfOi7euqXAc=; b=KNmRh4n4Bg1ve0+CdaeYDFzA29D/Uwc+eKwUzAMphJ J1jOBgEA1AJRcA7VCXZ875rZs2oVWu9XQaIsg0qQTn1DY12lIQNpx0E37hmfNwRx gL8uh6Pq0rBBEVPK50tH3a30B+SFfm7uHOdp4H/FLpNljRj/ZYtCMCNnd6hp+jiJ P00G7HpLXoC6ZZ3mJT7ERLBPZz3yDzgPFma9zpjcIFivAsLZHLwlTtfUfWUvnHZt pbKi447Jz5dzQn54hp3RDZu62TPPlt7ru0pE3LSMim4MbiJzTZPhTM1oWc5kWBI+ v60OyfPkMbWGRI3Shlm3OrcRy+BC069Wl3fzvsEvmvPg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=aHU9dW dXyakDMIaSMrH7zXMQfufipPB8OfOi7euqXAc=; b=J2p0C6/W432OL1z/rWuFLL oEjLSHoK49IXVOb17LgpcIdGbSYyulaPTk4ZpGapqsetW23FzBP+Rcfh49sgFeld 8++ahfhMMQEZxmSsDd4KmyQotQtFKACWlVtblJAAKXW7QkQSq2c6eyItAeNY6Abr eTwhT8pFfqVzu/F4Ij5haRJccUf3qBfCtt2e5rwgtbxHP2veEdChKF0DI4l5JGKl 5Ous1n4KjkfZZb0HfCoU3WclN1La8Zo/9+RQYgQXLCN4kuZ5+VMPr7q3ybsQwcfx RygC5CCC2p3L2p783QIshwUmgga5p/tbhD8lk5W1we+z/hmjF8T+6bipMf2e0Evg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudefiedgudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfggtgesghdtreertddttdenucfhrhhomheptehlhihsshgr ucftohhsshcuoehhihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepueelve elgfekiefgtefghfegvdffffeludeuffffjeetueelgfdutdefvdeugeefnecuffhomhgr ihhnpehpsgdrtggtnecukfhppeejledrvdefhedrudduledrudelgeenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehhihesrghlhihsshgrrdhi sh X-ME-Proxy: Received: from x220.qyliss.net (p4feb77c2.dip0.t-ipconnect.de [79.235.119.194]) by mail.messagingengine.com (Postfix) with ESMTPA id CE496328005A; Mon, 1 Jun 2020 18:44:55 -0400 (EDT) Received: by x220.qyliss.net (Postfix, from userid 1000) id 16AF0725; Mon, 1 Jun 2020 22:44:55 +0000 (UTC) From: Alyssa Ross To: Cole Helbling Subject: Re: [PATCH v2 2/2] chromiumOSPackages: 81.12871.0.0-rc1 -> 83.13020.0.0-rc1 In-Reply-To: References: Date: Mon, 01 Jun 2020 22:44:53 +0000 Message-ID: <87imga9ziy.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Message-ID-Hash: ZW725WGN6TONETUBCOKNKS7ETJYYVLXR X-Message-ID-Hash: ZW725WGN6TONETUBCOKNKS7ETJYYVLXR X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.0 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable > When running `nix-build . -A spectrumPackages.spectrum-vm` with these > two patches applied, vm_protos fails to build: > > [23/52] ACTION //vm_tools/proto:fuzzer-protos_gen(//common-mk/toolcha= in:toolchain) > /usr/share/proto: warning: directory does not exist. > [26/52] CXX obj/out/Release/gen/include/vm_protos/proto_bindings/libf= uzzer-protos.fuzzer.grpc.pb.o > FAILED: obj/out/Release/gen/include/vm_protos/proto_bindings/libfuzze= r-protos.fuzzer.grpc.pb.o > c++ -MMD -MF obj/out/Release/gen/include/vm_protos/proto_bindings/lib= fuzzer-protos.fuzzer.grpc.pb.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE = -D_FILE_OFFSET_BITS=3D64 -Igen/include -I../../common-mk -I/usr/include -Ig= en -Igen -Igen -Igen -Wall -Wunused -Wno-unused-parameter -Wunreachable-cod= e -ggdb3 -fstack-protector-strong -Wformat=3D2 -fvisibility=3Dinternal -Wa,= --noexecstack -Wimplicit-fallthrough -Werror --sysroot=3D -fPIE -fvisibilit= y=3Ddefault -pthread -I/nix/store/pjl2q3lny3c18ypqjcv0q3akyq89hg2i-grpc-1.2= 8.1/include -I/nix/store/hya0y6slws66h99njc2yiz02irfv4n62-openssl-1.1.1g-de= v/include -I/nix/store/mfpg3sk5vk9rm99hbpmd3dgvxqybd391-protobuf-3.8.0/incl= ude -pthread -I/nix/store/pjl2q3lny3c18ypqjcv0q3akyq89hg2i-grpc-1.28.1/incl= ude -I/nix/store/hya0y6slws66h99njc2yiz02irfv4n62-openssl-1.1.1g-dev/includ= e -I/nix/store/mfpg3sk5vk9rm99hbpmd3dgvxqybd391-protobuf-3.8.0/include -Wno= -unreachable-code -std=3Dgnu++14 -fno-exceptions -fno-unwind-tables -fno-as= ynchronous-unwind-tables -Wno-psabi -c gen/include/vm_protos/proto_bindings= /fuzzer.grpc.pb.cc -o obj/out/Release/gen/include/vm_protos/proto_bindings/= libfuzzer-protos.fuzzer.grpc.pb.o > In file included from gen/include/vm_protos/proto_bindings/fuzzer.grp= c.pb.cc:5: > gen/include/vm_protos/proto_bindings/fuzzer.pb.h:38:10: fatal error: = vm_crash.pb.h: No such file or directory > 38 | #include "vm_crash.pb.h" > | ^~~~~~~~~~~~~~~ > compilation terminated. > ninja: build stopped: subcommand failed. > builder for '/nix/store/8asskz117p1nhirxaa4pwa0caayxg6c5-vm_protos-83= .13020.0.0-rc1.drv' failed with exit code 1 That's interesting -- I can't reproduce this: $ NIX_PATH=3D nix-build -A chromiumOSPackages.vm_protos /nix/store/2dn0l8bb33ww5fcg09n30c3fpag6lc39-vm_protos-83.13020.0.0-rc1 I notice that our outPaths for vm_protos are different. What commit are did you apply the patches onto? (For me cfa1e27fdfb.) Do you have some global overlay that could be changing things (try with NIX_PATH=3D as above to make sure)? FWIW: $ NIX_PATH=3D nix-build -A chromiumOSPackages /nix/store/rgb6lg8jybz1y4nvxx1am5d1137k49ai-chromiumos-overlay /nix/store/y7psz0mh8gnlhjg4ik2pqdf209k9sanr-crosvm-83.13020.0.0-rc1 /nix/store/xw1zkd4bssmrkii1h7vjwq8hs321rssp-dbus-interfaces /nix/store/r11gn34ca9r1ac2cf6bc3qg6nb2k1380-dbus-properties /nix/store/81962ah6xqcpklp1cxz051dgy0dbjvsm-libqmi-unstable-2019-12-16 /nix/store/g346jzm6lamf69ysi4lm4m12gwd2347k-linux-5.4.28 /nix/store/1bqdkvqncnm5njpf44jnsi4lf5cr2jfp-linux-headers-5.4.28 /nix/store/fyq3kqc87ic6cby31sn498mp6r8lppyw-minigbm /nix/store/a53b0zgzrcfq8vbjbi9f9l1ada15k8my-modem-manager-chromiumos-un= stable-2012-04-10 /nix/store/722sj3qd8wbnf9phgp6l6a3b9cfyxihv-modem-manager-chromiumos-ne= xt-unstable-2019-10-17 /nix/store/0zr8d7ba2gvv8fgzkykk9jkrn70k1r9y-modp_b64-83.13020.0.0-rc1 /nix/store/7df2bcbd0q5kkqwpjapm1yn9aqd2lyyg-protofiles-0.0.36 /nix/store/p7vl9kg5cynasqsvpi5j4saqgmsnlszw-sommelier-83.13020.0.0-rc1 /nix/store/2dn0l8bb33ww5fcg09n30c3fpag6lc39-vm_protos-83.13020.0.0-rc1 Are all of those different for you, or just some? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAl7VhOUACgkQ+dvtSFmy ccDEUg//exw+zu8vmd/YBaGo34VPgLkWFANLzlHQ8n5QoZldafqWYqN/G88dX2sH HXEA4f/34o3MbJ3EknMPdIpaMt3i3Ynx+yhBTQ6IXy9cwNqxDqArElQ5UgX8bhOg NVhDInGV14wFmL0rqoDZx9dxajSJBpPyjzKrCZalGDgXbvi6LdoyV1/ewOEZs/Pf aPe0ACUIO7vO6AL9QWmbZu7jKY0J3ZJT6zVG+6R+idIwNWDDLPkk/AQvWLo8JukR CCjBhEpkB1nKkzCmPZ6rf+dpmSTcV4zhgGLNp7MZHpa2Z268HE8xhxpEQYXNC1pC DTqyVWDz+PohUwpEJnA3158bbfI1zehuaKD8WB9bkU/9a8iRnBXzpG7M2nr+A5om O2nhcXNlGpBIUV7L4/ocXMd8KEXXExsGqO4Oirl5WPxar+gW0jyTSwelXI/aG48o teML0joo+OTMc5vJDjYAIwMiFCTk6HB1o7DQ6o8Vkyqy6nRmuiA4lePsJWaXbXcS 2UJki/nLEyGGg1IG/LSMuzgcY3HAtWDOvViCkul8OeNvS0Kp+5phQHkcPJnfYGqk pK971mVj0T9iGsSHg5ptzrsUouSx6JXEFH0GYS6CUkIJ7jPIeMoT+yKA/2GLQDug NEk71uNbjOrxs3etqWZcGKEepi+TC+NRcMUktbcwIh5rlHXNQko= =nTPr -----END PGP SIGNATURE----- --=-=-=--