patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Alyssa Ross <hi@alyssa.is>
To: Demi Marie Obenour <demiobenour@gmail.com>,
	Spectrum OS Development <devel@spectrum-os.org>
Subject: Re: [PATCH v3 2/4] Move all files for the image into a subdirectory
Date: Wed, 17 Sep 2025 14:30:25 +0200	[thread overview]
Message-ID: <87jz1xxnvi.fsf@alyssa.is> (raw)
In-Reply-To: <20250911-genfiles-v3-2-d8709081dc5c@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2772 bytes --]

Demi Marie Obenour <demiobenour@gmail.com> writes:

> diff --git a/img/app/Makefile b/img/app/Makefile
> index 73db07cc4c781d9c41cdf41a6214298aae8de58a..0099aa3b9626bfcc2079e5c67401db4e5316caeb 100644
> --- a/img/app/Makefile
> +++ b/img/app/Makefile
> @@ -30,32 +30,32 @@ $(imgdir)/appvm/blk/root.img: ../../scripts/make-gpt.sh ../../scripts/sfdisk-fie
>  	mv $@.tmp $@
>  
>  VM_FILES = \
> -	etc/dbus-1/session.conf \
> -	etc/fonts/fonts.conf \
> -	etc/fstab \
> -	etc/init \
> -	etc/mdev.conf \
> -	etc/mdev/iface \
> -	etc/mdev/listen \
> -	etc/mdev/virtiofs \
> -	etc/mdev/wait \
> -	etc/passwd \
> -	etc/pipewire/pipewire.conf \
> -	etc/resolv.conf \
> -	etc/s6-linux-init/env/DBUS_SESSION_BUS_ADDRESS \
> -	etc/s6-linux-init/env/DISPLAY \
> -	etc/s6-linux-init/env/GTK_USE_PORTAL \
> -	etc/s6-linux-init/env/NIX_XDG_DESKTOP_PORTAL_DIR \
> -	etc/s6-linux-init/env/WAYLAND_DISPLAY \
> -	etc/s6-linux-init/env/XDG_RUNTIME_DIR \
> -	etc/s6-linux-init/run-image/service/getty-hvc0/run \
> -	etc/s6-linux-init/run-image/service/s6-linux-init-shutdownd/notification-fd \
> -	etc/s6-linux-init/run-image/service/s6-linux-init-shutdownd/run \
> -	etc/s6-linux-init/scripts/rc.init \
> -	etc/s6-linux-init/scripts/rc.shutdown \
> -	etc/s6-linux-init/scripts/rc.shutdown.final \
> -	etc/wireplumber/wireplumber.conf.d/99_spectrum.conf \
> -	etc/xdg/xdg-desktop-portal/portals.conf
> +	image/etc/dbus-1/session.conf \
> +	image/etc/fonts/fonts.conf \
> +	image/etc/fstab \
> +	image/etc/init \
> +	image/etc/mdev.conf \
> +	image/etc/mdev/iface \
> +	image/etc/mdev/listen \
> +	image/etc/mdev/virtiofs \
> +	image/etc/mdev/wait \
> +	image/etc/passwd \
> +	image/etc/pipewire/pipewire.conf \
> +	image/etc/resolv.conf \
> +	image/etc/s6-linux-init/env/DBUS_SESSION_BUS_ADDRESS \
> +	image/etc/s6-linux-init/env/DISPLAY \
> +	image/etc/s6-linux-init/env/GTK_USE_PORTAL \
> +	image/etc/s6-linux-init/env/NIX_XDG_DESKTOP_PORTAL_DIR \
> +	image/etc/s6-linux-init/env/WAYLAND_DISPLAY \
> +	image/etc/s6-linux-init/env/XDG_RUNTIME_DIR \
> +	image/etc/s6-linux-init/run-image/service/getty-hvc0/run \
> +	image/etc/s6-linux-init/run-image/service/s6-linux-init-shutdownd/notification-fd \
> +	image/etc/s6-linux-init/run-image/service/s6-linux-init-shutdownd/run \
> +	image/etc/s6-linux-init/scripts/rc.init \
> +	image/etc/s6-linux-init/scripts/rc.shutdown \
> +	image/etc/s6-linux-init/scripts/rc.shutdown.final \
> +	image/etc/wireplumber/wireplumber.conf.d/99_spectrum.conf \
> +	image/etc/xdg/xdg-desktop-portal/portals.conf
>  
>  VM_DIRS = dev run proc sys tmp \
>  	etc/s6-linux-init/run-image/service \

It's a bit of a shame that this makes VM_FILES and VM_DIRS asymmetric,
but I guess it's worth it…

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2025-09-17 12:30 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-04  1:56 [PATCH 0/4] Generate file lists from a script Demi Marie Obenour
2025-09-04  1:56 ` [PATCH 1/4] Move all files for the image into a subdirectory Demi Marie Obenour
2025-09-04  1:56 ` [PATCH 2/4] Generate makefile file lists from a script Demi Marie Obenour
2025-09-08  9:59   ` Alyssa Ross
2025-09-08 18:45     ` Demi Marie Obenour
2025-09-09 14:51       ` Alyssa Ross
2025-09-04  1:56 ` [PATCH 3/4] Common make rules for building erofs images Demi Marie Obenour
2025-09-08 10:01   ` Alyssa Ross
2025-09-08 18:53     ` Demi Marie Obenour
2025-09-09 14:56       ` Alyssa Ross
2025-09-04  1:56 ` [PATCH 4/4] Use /etc/s6-rc/compiled for compiled s6-rc directory Demi Marie Obenour
2025-09-10  5:29 ` [PATCH v2 0/3] Generate file lists from a script Demi Marie Obenour
2025-09-10  5:29   ` [PATCH v2 1/3] Move all files for the image into a subdirectory Demi Marie Obenour
2025-09-10 18:58     ` Alyssa Ross
2025-09-11 12:21       ` Demi Marie Obenour
2025-09-10  5:29   ` [PATCH v2 2/3] Generate makefile file lists from a script Demi Marie Obenour
2025-09-10  5:29   ` [PATCH v2 3/3] Common make rules for building erofs images Demi Marie Obenour
2025-09-11 12:47   ` [PATCH v3 0/4] Generate file lists from a script Demi Marie Obenour
2025-09-11 12:47     ` [PATCH v3 1/4] Do not ignore errors from tar Demi Marie Obenour
2025-09-17 11:48       ` Alyssa Ross
2025-09-18  2:45         ` Demi Marie Obenour
2025-09-19  7:46           ` Alyssa Ross
2025-09-30 12:59             ` Alyssa Ross
2025-09-19  7:55       ` Alyssa Ross
2025-09-19 19:03         ` Demi Marie Obenour
2025-09-11 12:47     ` [PATCH v3 2/4] Move all files for the image into a subdirectory Demi Marie Obenour
2025-09-17 12:30       ` Alyssa Ross [this message]
2025-09-17 12:39       ` Alyssa Ross
2025-09-17 13:03       ` Alyssa Ross
2025-09-11 12:47     ` [PATCH v3 3/4] Generate makefile file lists from a script Demi Marie Obenour
2025-09-11 12:47     ` [PATCH v3 4/4] Common make rules for building erofs images Demi Marie Obenour
2025-09-21  2:23   ` [PATCH v3] Generate file lists from a script Demi Marie Obenour
2025-09-21  8:47     ` Alyssa Ross
2025-09-21 16:51       ` Demi Marie Obenour
2025-09-21 17:07         ` Alyssa Ross
2025-09-21 17:24     ` [PATCH v4] " Demi Marie Obenour
2025-09-25 11:22       ` Alyssa Ross
2025-09-26 16:31       ` [PATCH v5] " Demi Marie Obenour
2025-09-27  8:19         ` Alyssa Ross
2025-09-27  8:42           ` Demi Marie Obenour
2025-09-27 16:22         ` [PATCH v6] " Demi Marie Obenour
2025-09-29  8:12           ` Alyssa Ross
2025-09-29 17:20             ` Demi Marie Obenour
2025-09-29 17:18           ` [PATCH v7] " Demi Marie Obenour
2025-10-01  9:20             ` Alyssa Ross
2025-10-01  9:24               ` Demi Marie Obenour
2025-10-01  9:35             ` Alyssa Ross
2025-10-01 18:30             ` [PATCH v8] " Demi Marie Obenour
2025-10-02  9:46               ` Alyssa Ross
2025-10-02 17:37               ` [PATCH v9] " Demi Marie Obenour
2025-10-03  9:04                 ` Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jz1xxnvi.fsf@alyssa.is \
    --to=hi@alyssa.is \
    --cc=demiobenour@gmail.com \
    --cc=devel@spectrum-os.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).