From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 06659AF4A; Sat, 13 Dec 2025 20:43:47 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id A52D7AFB0; Sat, 13 Dec 2025 20:43:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fhigh-a7-smtp.messagingengine.com (fhigh-a7-smtp.messagingengine.com [103.168.172.158]) by atuin.qyliss.net (Postfix) with ESMTPS id E3AC8AFAF for ; Sat, 13 Dec 2025 20:43:41 +0000 (UTC) Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfhigh.phl.internal (Postfix) with ESMTP id BBEA514000CC; Sat, 13 Dec 2025 15:43:38 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-10.internal (MEProxy); Sat, 13 Dec 2025 15:43:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1765658618; x=1765745018; bh=KnBmF9stVv V2D9B6bj6BwxvwXnW9t9I2mpGO0B2lhA8=; b=OBXlpTuE/KBwxZb3mYmCfSD1/j 3dY/gwP70QjM7+5MVMbG6I3NwXf+BNtb6HK+wq5tRACFH7YgKFNqRfOmTz6Bagx/ 2kWo0hd0BRqR/VMcOSRZ5RQa74SI5ao8GoA+qQNLhtPkJv+bvF06cZbxs0A7JmbA p+YYJV+bUuQAauu7h+5pps7N8Us0WfNu7Jmw4bR9VzFKcA2YxcHtsS8YW8nkHz7m YBmUbTIUKijRHHEfpLOwNX8q5JS5iro8NRO+q76a3BHOACyzOIZOPdTAzTTa9YW4 cFoC1HWbZtiiMrZDRn/V0njpwOJ/tRUAnIYywRHSaYiNE45vxIrzW1vJqkxg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1765658618; x=1765745018; bh=KnBmF9stVvV2D9B6bj6BwxvwXnW9t9I2mpG O0B2lhA8=; b=ed3whHIDh6rJG4si/wk13dmHuEGgkd+cKfyjWhedvSLQdz8lyIy oI6fiEgEnQYLLajilAVp2l3vHT/oXw4HgpBRJEvbSvuZT89+XeOXGW8Ih5YuQsxk MKq4UVyr5slBtoFZ+tfyCzZkOdd2Ks7eBntYAJ6DyQCzY81fDwMqYBwUGDAWqYnx btK1uKsGsKqyPuT+9RRfBDas2HJeLdVbHQXKPwXh63ksP/jFpFQjQf6KLRHPBuvj QqneT7tUa/8xvHttghh+cq1xtnUqiLAvDZ1KoPbIpNGrPceXP60540Y/a58EhDvw BTIoiqfyPPkk+6OokI+Lyqb6LVnOMTHo2cg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdefvddthecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufgjfhffkfggtgesghdtreertddttdenucfhrhhomheptehlhihsshgrucft ohhsshcuoehhihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepieduffeuie elgfetgfdttddtkeekheekgfehkedufeevteegfeeiffetvdetueevnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhephhhisegrlhihshhsrgdrih hspdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegu vghmihhosggvnhhouhhrsehgmhgrihhlrdgtohhmpdhrtghpthhtohepuggvvhgvlhessh hpvggtthhruhhmqdhoshdrohhrgh X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 13 Dec 2025 15:43:38 -0500 (EST) Received: by fw12.qyliss.net (Postfix, from userid 1000) id 135267A88698; Sat, 13 Dec 2025 21:43:27 +0100 (CET) From: Alyssa Ross To: Demi Marie Obenour Subject: Re: [PATCH 4/4] host/rootfs: clean up obsolete tmp dirs on mount In-Reply-To: <3cf4c548-80e5-4790-97bd-65c5263c7301@gmail.com> References: <20251213161637.510752-1-hi@alyssa.is> <20251213161637.510752-4-hi@alyssa.is> <3cf4c548-80e5-4790-97bd-65c5263c7301@gmail.com> Date: Sat, 13 Dec 2025 21:43:25 +0100 Message-ID: <87ldj65d02.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: G47WXHAGTAYQYDKPGG4JXY6PQ46M5WV2 X-Message-ID-Hash: G47WXHAGTAYQYDKPGG4JXY6PQ46M5WV2 X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Demi Marie Obenour writes: > On 12/13/25 11:16, Alyssa Ross wrote: >> In the ideal case, these will be cleaned up when the VM running them >> exits, but there's always the possibility that there are some left >> over, in which case mount time is the perfect time to clean up, when >> we can be reasonably sure nothing else is still accessing them. >>=20 >> Signed-off-by: Alyssa Ross >> --- >> host/rootfs/image/usr/bin/mount-userdata | 36 ++++++++++++++++-------- >> 1 file changed, 25 insertions(+), 11 deletions(-) >>=20 >> diff --git a/host/rootfs/image/usr/bin/mount-userdata b/host/rootfs/imag= e/usr/bin/mount-userdata >> index 6e4ac47d..2e130b83 100755 >> --- a/host/rootfs/image/usr/bin/mount-userdata >> +++ b/host/rootfs/image/usr/bin/mount-userdata >> @@ -7,18 +7,32 @@ backtick -D "" uuid { >> blkid -o value -s UUID -- $1 >> } >>=20=20 >> -multisubstitute { >> - importas -Siu 0 >> - importas -Siu 1 >> - importas -Siu uuid >> -} >> - >> -case $uuid { >> - "" { >> - fdmove -c 1 2 >> - printf "%s: '%s' does not have a UUID\n" $0 $1 >> +if { >> + multisubstitute { >> + importas -Siu 0 >> + importas -Siu 1 >> + importas -Siu uuid >> } >> + >> + case $uuid { >> + "" { >> + fdmove -c 1 2 >> + printf "%s: '%s' does not have a UUID\n" $0 $1 > > Is continuing after printing this error intentional? No. I'd already noticed this and have fixed it. Should have posted a v2. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQQGoGac7QfI+H5ZtFCZddwkt31pFQUCaT3P7QAKCRCZddwkt31p FTBzAP9nPdW92osf0jxPUdnPs+CSsxvr0Gv9jGzpfflB2vji4QD+JHVuZ0ivkgvF 53IiYOLGhoWW3L3pmMxDNwHqDceFuQI= =pJyh -----END PGP SIGNATURE----- --=-=-=--