From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: by atuin.qyliss.net (Postfix, from userid 496) id E0C203160C; Mon, 16 Aug 2021 08:50:00 +0000 (UTC) Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 5164831563; Mon, 16 Aug 2021 08:49:45 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 2CED631561; Mon, 16 Aug 2021 08:49:43 +0000 (UTC) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by atuin.qyliss.net (Postfix) with ESMTPS id 2C0C6315E9 for ; Mon, 16 Aug 2021 08:49:38 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 336B75C00B6; Mon, 16 Aug 2021 04:49:36 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 16 Aug 2021 04:49:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm3; bh=7cMZtZaXA5FVpMO/VNFkGhZDju /8jJTZmglJQs7xqRg=; b=kui1cIvUWBFsbtGxFCMRhPQp5lCxaQVT4ESUBcjC7K wEggOMYSj+VZ8uaucwSoYPFZsrlPyEyTNcLmzMJltOm1N6bMenjU7Cx4VZSfw8XB OjQGl+sUvbI4t8qoq11y9NU7Fdyz2DYO8O4Z7Vr0DugzmRyNhTnvLcFHwSHiSywZ IJ7xa/d2NPiB3XXWCOwtG9s6dxSCTvSdaY+LPP366Qk1jaadKmiJpzd8HN4NZPrK tb5svvBTInnFccYtoLJWAc+7i2pUMr3N5xTn35XwbWo6+VJQ5Pfcae7VVhQQMagW DL0AVVwC9EI0l8bhPEIWTsmrzjC3AyJMfVrfRRdBnJtQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=7cMZtZ aXA5FVpMO/VNFkGhZDju/8jJTZmglJQs7xqRg=; b=iUYRUwj9sn7qdaNdyVeY6u pKzCuv63wRNXr1aNL+GgX3JC7//It0NB7DC5wGTxJb3X44TxgHhJXsY5sTEX7XJB jecXMx8k8NrUsuH7dkP6EmOucnVc/aIwuodSZgDwSXUjmBGjE5NSt1Y6HVSMAKDG ufaoPQZU0DK53HS3F1+0q1yKJscxZIMBH5hRP8pEEshWV36TguFpvctFu5EEaj3f WaFgsrM5sprix81QTxcKG1YTwOLOhHfGKfTS4KA37jyW9Hksx/7hkL2hYJEQ4mPg xp2XsiJfYUHqJGzKFmpHCv+aDJTtM3UTimofyYh0Ls46bO6XCLxlEpNcD0CI055A == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrledugddtkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffffkgggtsehgtderredttddtnecuhfhrohhmpeetlhihshhsrgcu tfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpedvuedvie dvhefhieektddvvdehgfehffelveeuiefggfdtffffueejudejjeekjeenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehhihesrghlhihsshgrrd hish X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 16 Aug 2021 04:49:35 -0400 (EDT) Received: by x220.qyliss.net (Postfix, from userid 1000) id 51AA0112E; Mon, 16 Aug 2021 08:49:33 +0000 (UTC) From: Alyssa Ross To: Cole Helbling Subject: Re: [PATCH nixpkgs] chromiumOSPackages.libqmi: don't enable doc twice In-Reply-To: References: Date: Mon, 16 Aug 2021 08:49:29 +0000 Message-ID: <87lf51n59i.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Message-ID-Hash: JE3WMTQ3KBP3H7P47CEYUSEI57TPSC4A X-Message-ID-Hash: JE3WMTQ3KBP3H7P47CEYUSEI57TPSC4A X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.4 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable "Cole Helbling" writes: > On Thu Aug 12, 2021 at 2:31 AM PDT, Alyssa Ross wrote: >> This is already enabled in the original derivation, so overriding it >> to add it here just means we end up passing the option twice. >> --- >> pkgs/os-specific/linux/chromium-os/libqmi/default.nix | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/pkgs/os-specific/linux/chromium-os/libqmi/default.nix b/pkg= s/os-specific/linux/chromium-os/libqmi/default.nix >> index b96b5224b57..7328642d0b4 100644 >> --- a/pkgs/os-specific/linux/chromium-os/libqmi/default.nix >> +++ b/pkgs/os-specific/linux/chromium-os/libqmi/default.nix >> @@ -15,7 +15,7 @@ libqmi.overrideAttrs ( >>=20=20 >> # ModemManager tests fail with QRTR in Chromium OS 91. >> # Will hopefully be fixed in CrOS 92. >> - configureFlags =3D configureFlags ++ [ "--enable-gtk-doc" "--disabl= e-qrtr" ]; >> + configureFlags =3D configureFlags ++ [ "--disable-qrtr" ]; >>=20=20 >> passthru =3D passthru // { >> updateScript =3D ../update.py; >> --=20 >> 2.32.0 > > But what if we want twice the amount of documentation? > > Joking aside, LGTM. > > Reviewed-by: Cole Helbling Thanks for the review! Pushed as cec682e0071. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmEaJpsACgkQ+dvtSFmy ccDjWA//ZirJqutSL90P6szEBLyx7NrXHS5bJc8af0tvA+C2ls6LbKXrYGY63kvN l1fEtz4z0X0r0r/N7Kz79Z9CrsPgtvKxqM1dhRzwOYbcodP8Z/EWgdHwN1JDIEYC AM4U+oG+xOLE9oew+vLElJycTUvfgcRybB1uGAm1wpj71EC2KevzXi0XZMKhsubo dP4wVGJJxYQkP6ZRGO3yWy36Q4kjfMj7jYx8jcpz+GvwxNqHkd5XN8AgjGQMa3h3 S1WJ4Ten+f9Pcjsu1tYogXeLq8U2JTLaSb/qsydANv87Ir4fvJivznkLPWEhxlFs b9OGOEqIRg5tf8blr9RQ1/B3uBkpU6wnEDa75kYKOqfGN84YDfnLNsm4gZ4ltnG/ nCrYIIKXNkgwrBOMsYV/z1NRg15M5SINY8i+PXY1YuRMxnn90VPivkUgto30xGcg eKLaFW5GlYl4m8rh/NortNBV2m4HIm9yzBsFOuHIIolicp0NQPDsWxCDLFXStwIE 3+cG/rhnccLmpfOUYMOTqgsefWRv/6IwwcCYAoDmRmrrIhj/ic0NikH2ojWEv6cJ chL9mFvtkzujJFTcTApgHc6k/L8detYDc79J65f9wTqtCDe2uG3zt2m4yxXwq+7j OVAKWP2K3gwp0dIeiCQEJhX8+Q8ntg1oYTVJwjNLcEWRcYBH1Ko= =7j+y -----END PGP SIGNATURE----- --=-=-=--