From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 984F619B4A; Mon, 08 Sep 2025 09:12:41 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id B744619AFC; Mon, 08 Sep 2025 09:12:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fhigh-b7-smtp.messagingengine.com (fhigh-b7-smtp.messagingengine.com [202.12.124.158]) by atuin.qyliss.net (Postfix) with ESMTPS id 1DCB419AFB for ; Mon, 08 Sep 2025 09:12:37 +0000 (UTC) Received: from phl-compute-09.internal (phl-compute-09.internal [10.202.2.49]) by mailfhigh.stl.internal (Postfix) with ESMTP id EBF0B7A008A; Mon, 8 Sep 2025 05:12:35 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-09.internal (MEProxy); Mon, 08 Sep 2025 05:12:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1757322754; x=1757409154; bh=D4BbjD0CAn Q+okXQJxiwva2HBil+gWYK+zr5+Zwxljo=; b=mlVZxaRsAImRtqKVSYOwOrLnFp Kv/E+nOIQJ0fEc30s/9XjB/DFwEf9MmvEK3PiENTAnX9x2GMRI2YLTApo0NaHyd0 Latqp+ttG+m+rQ6mDypsFZHkoeiatyW4Jpy3Qhj0184Yw2iC76w9bQBp04uEFjS5 rNN1qcmcR+i6HxjL+iVm7CUfllDMGH9U8xdeao4bcGArR9mLdkzvnM47jJRrRdXD rg1eT+UpGhvRf/xlKD6JL+2dbUisac+NQjUwp/NSVou7MxwEJsmaYyw+RJbozDOg mvYbz0roYYMJ3mjgDntjHSMKGKpCZhyxOBkt9UqKnKowbchoX2H7d+Poiq/g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1757322754; x=1757409154; bh=D4BbjD0CAnQ+okXQJxiwva2HBil+gWYK+zr 5+Zwxljo=; b=iTnMVY83d7Ee06Ye/AYHU5oo+YmUOEi/Vu9yGMhB1rp3lItDePG K0hfk5AqdBgSOQ465tEBhalUim+5Bqt/r7YuKwmYOEXRNlufxp7enkSmAIe7hfIM NxMRNeVcqeoK06sIfBE/BTgdtTqtHSMgT243P7de0FDx/y+qy+BFgdRHFcN91Wt4 ccRfbAnajdPqdc56980u4o06WFLNZrm4XBx8oaQaYqHz2m3R1n9zOKxqK3dLnNEF 2nQycEo9129nI6lfGaI1Vm11NvsWgBkgt1x9/Hrg4YgU/6jhZiBBcuPTnHafL9sv feWWlKt52C+pMsrmQ0On+a31r45kyG9UQ4w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddujedugecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufgjfhffkfggtgesghdtreertddttdenucfhrhhomheptehlhihsshgrucft ohhsshcuoehhihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepveejieekhe ffueehjeevtdekleelhfehhfelgeffieeiuddvueeifeetkeelffdvnecuffhomhgrihhn pehsphgvtghtrhhumhdqohhsrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhephhhisegrlhihshhsrgdrihhspdhnsggprhgtphhtthho pedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopeguvghmihhosggvnhhouhhrse hgmhgrihhlrdgtohhmpdhrtghpthhtohepuggvvhgvlhesshhpvggtthhruhhmqdhoshdr ohhrgh X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 8 Sep 2025 05:12:34 -0400 (EDT) Received: by mbp.qyliss.net (Postfix, from userid 1000) id 2D7921674F0F; Mon, 08 Sep 2025 11:12:32 +0200 (CEST) From: Alyssa Ross To: Demi Marie Obenour Subject: Re: [PATCH 09/20] Add os-release file In-Reply-To: <20250904-systemd-v1-9-2a63b790a913@gmail.com> References: <20250904-systemd-v1-0-2a63b790a913@gmail.com> <20250904-systemd-v1-9-2a63b790a913@gmail.com> Date: Mon, 08 Sep 2025 11:12:31 +0200 Message-ID: <87ms75jojk.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: U2MJZCG26USZALO5PDIHBVUVFSASH3NS X-Message-ID-Hash: U2MJZCG26USZALO5PDIHBVUVFSASH3NS X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Spectrum OS Development X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Demi Marie Obenour writes: > systemd-sysupdate expects one to exist and it's a good idea to have one > anyway. Some third-party dependencies might check for it. > > Signed-off-by: Demi Marie Obenour > --- > host/rootfs/Makefile | 1 + > host/rootfs/etc/os-release | 12 ++++++++++++ > host/rootfs/etc/os-release.license | 2 ++ > img/app/Makefile | 1 + > img/app/etc/os-release | 12 ++++++++++++ > img/app/etc/os-release.license | 2 ++ > vm/sys/net/Makefile | 1 + > vm/sys/net/etc/os-release | 12 ++++++++++++ > vm/sys/net/etc/os-release.license | 2 ++ > 9 files changed, 45 insertions(+) > In general, I wouldn't want most software to be making decisions on /etc/os-release. (systemd-sysupdate is a special case here in having a good reason to do it.) Maybe in img/app we need it for compatibility with arbitrary stuff, but if anything in vm/sys/net is looking at os-release I'd rather it crash and I find out about it so I could fix it. If we do have an /etc/os-release file on the host though, would be great if we could re-use it when building the UKI in release/live. (dump.erofs is probably useful here.) > diff --git a/host/rootfs/Makefile b/host/rootfs/Makefile > index 6cdbac201257faedb70344bcfd5cf9d4fd25b507..4faaccab8cb01d57ef7c48c01eb6fb1326cea4a0 100644 > --- a/host/rootfs/Makefile > +++ b/host/rootfs/Makefile > @@ -17,6 +17,7 @@ FILES = \ > etc/mdev/listen \ > etc/mdev/net/add \ > etc/mdev/wait \ > + etc/os-release \ > etc/parse-devname \ > etc/passwd \ > etc/s6-linux-init/env/WAYLAND_DISPLAY \ > diff --git a/host/rootfs/etc/os-release b/host/rootfs/etc/os-release > new file mode 100644 > index 0000000000000000000000000000000000000000..536183411aa94b727f045c4623c29d66503738be > --- /dev/null > +++ b/host/rootfs/etc/os-release > @@ -0,0 +1,12 @@ > +NAME="Spectrum OS" NAME="Spectrum". There's no "OS" is the name. > +ID="spectrum" > +PRETTY_NAME="Spectrum OS 0.0.0-alpha0" > +VERSION="0.0.0-alpha0" > +VERSION_ID="0" > +IMAGE_ID="Spectrum-OS-Host" The documentation for this field says "A lower-case string". > +IMAGE_VERSION="0" Given we don't have a versioning scheme, why fill in these optional fields? > +RELEASE_TYPE="development" Surely stable (the default) would be more accurate, given the examples for that include OpenSUSE Tumbleweed and Arch Linux, which have a similar rolling release model to what Spectrum will have? We don't have a distinction between development and release builds, and I don't expect us to. > +HOME_URL="https://www.spectrum-os.org/" > +VENDOR_URL="https://www.spectrum-os.org/" "The VENDOR_NAME= field should be set if this one is" > +ANSI_COLOR="1;34" > +DEFAULT_HOSTNAME="spectrum-host" What do we expect this to do? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRV/neXydHjZma5XLJbRZGEIw/wogUCaL6d/wAKCRBbRZGEIw/w ot35AQCgv+m0Fb0V65dVQYlT/jHaDB6cDtGL7wqQqbeoHfUGNgEA6UgpzbFqwFqJ WlBpet2aBy4ujnCy7QO2lXPN8e6dQg8= =MV2L -----END PGP SIGNATURE----- --=-=-=--