From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id EE2175F8A for ; Fri, 18 Jul 2025 11:33:43 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 75F175F83; Fri, 18 Jul 2025 11:33:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fout-a5-smtp.messagingengine.com (fout-a5-smtp.messagingengine.com [103.168.172.148]) by atuin.qyliss.net (Postfix) with ESMTPS id BAF7A5F29 for ; Fri, 18 Jul 2025 11:33:40 +0000 (UTC) Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfout.phl.internal (Postfix) with ESMTP id 0CA66EC0088; Fri, 18 Jul 2025 07:33:40 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Fri, 18 Jul 2025 07:33:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1752838420; x=1752924820; bh=UpNd4iljcQ fXG7yfZ9K1LoDMl1PDSsycQKKKdu2wV2I=; b=BMyRqUhKb/Zs1klItqJ4cxeehd HnnOs8rtkGb78ccYPsYbVaJnUG/W4FIF9z5X3CZdFTIDbWMYeTdJS2OaxKHFWRnp cB0lITGQa0Di9TcObvm1fn/85goVjvTLiYbiRrtF6kLZ4ipZm6gapbnbMQHW4zfN 80w0CZMPJ8u/N5RHk7odZgCOe77Xo767PDcqGOuklWgUkE9JM9UK6A0a1/mJU+7t fmmb/yaC0oA3EP6hgpRE0kQY/wyUm2sZAhBQDT7yUYd8LQjXOW1rBY+05FIabakr 7Tb4e3E1ItkYLtIZ6ibSWT26MfGnKGdApjLibddJJG847OJtSN2sW4LIz2Cg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1752838420; x=1752924820; bh=UpNd4iljcQfXG7yfZ9K1LoDMl1PDSsycQKK Kdu2wV2I=; b=Qxiqr/8oHcSNKPa5XonBG5H9kcSoygQAkEzBqO2NHoAejJwkbCF 0uknZeW+u/mGvduLKAyh4T9uHPvLmRlhRTOD9YjpNLbweBRAQNJ5RYTIirrBMUeV QOGHvKGBuI6zmEpN9MgoZ5ERREfCO0VtJlvH9ltTg2gSwaj+3Z+69ekLsD8t0aEe PRWnHP2ppSQsAyj59ksMnt8NKIsVoPXJoNjxj2QKDZIBIV72DI18OYOe6sU2KGt3 CLYdUaIhdfVBtbvHGpk8Rayjh12S1+pVWts4hBnm+5AswwWHmfBNmtp5aXT2SolE uAXy4mD/c2LeiBQ+4Yyo8ZmnhKn8t3cmpgA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdeifeefgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvffujghffffkgggtsehgtderredttdejnecuhfhrohhmpeetlhihshhsrgcutfho shhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeffudduffeuff egheeigeejtdekhfduheehfeduheelffettdekiedtgeefgfelheenucevlhhushhtvghr ufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehhihesrghlhihsshgrrdhish dpnhgspghrtghpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepuggv mhhiohgsvghnohhurhesghhmrghilhdrtghomhdprhgtphhtthhopeguvghvvghlsehsph gvtghtrhhumhdqohhsrdhorhhg X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 18 Jul 2025 07:33:39 -0400 (EDT) Received: by sf.qyliss.net (Postfix, from userid 1000) id E8EEC2B81CCA5; Fri, 18 Jul 2025 13:14:56 +0200 (CEST) From: Alyssa Ross To: Demi Marie Obenour , Spectrum OS Development Subject: Re: [PATCH v4 1/3] Rebuild the root filesystem when the makefile changes In-Reply-To: References: <6ab772e0-62b0-430f-8d3c-0bba79a3282c@gmail.com> Date: Fri, 18 Jul 2025 13:14:54 +0200 Message-ID: <87ms91sqc1.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: W2WKYDVYAHG2BRWUQAVHE74KI3BBEVEF X-Message-ID-Hash: W2WKYDVYAHG2BRWUQAVHE74KI3BBEVEF X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Demi Marie Obenour writes: > I spent hours figuring out why files were not found in the VMs. Turns > out that 'make' was no rerunning the script to rebuild the root > filesystem. > > Signed-off-by: Demi Marie Obenour > --- > img/app/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/img/app/Makefile b/img/app/Makefile > index f818e914908038cdf14532d1b7b44a1c37c1b270..d81337f99e2e83cf03ac73b9f= c96fae6ce118537 100644 > --- a/img/app/Makefile > +++ b/img/app/Makefile > @@ -71,7 +71,7 @@ build/fifo: > build/empty: > mkdir -p $@ >=20=20 > -build/rootfs.erofs: ../../scripts/make-erofs.sh $(VM_FILES) $(VM_BUILD_F= ILES) build/empty build/fifo > +build/rootfs.erofs: ../../scripts/make-erofs.sh $(VM_FILES) $(VM_BUILD_F= ILES) build/empty build/fifo Makefile > ( \ > cat $$PACKAGES ;\ > for file in $(VM_FILES) $(VM_LINKS); do printf '%s\n%s\n' $$file $$= file; done ;\ I'm not sure about this one =E2=80=94 there's no reason this target in particular needs to depend on the Makefile, but others don't. A change to the Makefile could cause any target to be outdated. I think it's just a normal part of working with make that you have to do a clean build after changing the Makefile. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRV/neXydHjZma5XLJbRZGEIw/wogUCaHossAAKCRBbRZGEIw/w og9tAPsFX6Oyu24opb9Nf01ko1PO6QZHE35Vy2p01TtSyTYIDAD/Ykq7EBok1GV8 4uD9J6bCcBVoaXAhr1qTlAQD4dHMOgk= =qNlc -----END PGP SIGNATURE----- --=-=-=--