From: Alyssa Ross <hi@alyssa.is>
To: Dom Rodriguez <shymega@shymega.org.uk>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH] crosvm: Rename `--vhost-user-{fs,gpu}` args
Date: Fri, 06 Sep 2024 13:22:26 +0200 [thread overview]
Message-ID: <87msklgh71.fsf@alyssa.is> (raw)
In-Reply-To: <20240906093430.1168464-1-shymega@shymega.org.uk>
[-- Attachment #1: Type: text/plain, Size: 890 bytes --]
Dom Rodriguez <shymega@shymega.org.uk> writes:
> crosvm was producing warnings when using `--vhost-user-gpu` and
> `--vhost-user-fs`.
>
> In this commit, I have adjusted the `crosvm` invocations to look
> something like `--vhost-user $DEVICE`, where `$DEVICE` is, in this case,
> `gpu` or `fs`.
>
> I have run unit tests, but would appreciate testing.
How did you run them? release/checks/wayland is failing:
vm-test-run-spectrum-wayland> machine # [ 14.028205] crosvm[968]: [2024-09-06T11:19:20.132395456+00:00 ERROR crosvm] arg parsing failed: Error parsing option '--vhost-user' with value 'gpu': missing field `socket`
vm-test-run-spectrum-wayland> machine # [ 14.029442] crosvm[968]: [src/main.rs:737] arg parsing failed: Error parsing option '--vhost-user' with value 'gpu': missing field `socket`
Does it need to be (from memory) --vhost-user gpu,socket=path or something?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2024-09-06 11:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 9:34 [PATCH] crosvm: Rename `--vhost-user-{fs,gpu}` args Dom Rodriguez
2024-09-06 11:22 ` Alyssa Ross [this message]
2024-09-06 22:41 ` Dom Rodriguez
2024-09-08 7:46 ` Alyssa Ross
2024-09-21 22:51 ` Dom Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msklgh71.fsf@alyssa.is \
--to=hi@alyssa.is \
--cc=devel@spectrum-os.org \
--cc=shymega@shymega.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).