From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 8261D1C266; Fri, 06 Sep 2024 11:22:37 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 967891C290; Fri, 06 Sep 2024 11:22:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DMARC_MISSING, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS, T_SCC_BODY_TEXT_LINE,WEIRD_PORT autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fout1-smtp.messagingengine.com (fout1-smtp.messagingengine.com [103.168.172.144]) by atuin.qyliss.net (Postfix) with ESMTPS id 5933D1C28E for ; Fri, 06 Sep 2024 11:22:32 +0000 (UTC) Received: from phl-compute-09.internal (phl-compute-09.phl.internal [10.202.2.49]) by mailfout.phl.internal (Postfix) with ESMTP id 906E81380311; Fri, 6 Sep 2024 07:22:30 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-09.internal (MEProxy); Fri, 06 Sep 2024 07:22:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1725621750; x=1725708150; bh=jqzRTI11U7 DN9Yx3e6akrui4xFzXl6LR9YQs6dICVik=; b=IjFRbxS210jbcuUl2laqBWYE7M +ZsA73HDA9d8JmaKaG1a4if8S7EkR4rExfzqrO5kbLZReKpo1fKMYzzKz/e+w1Tm qOI1Xwj+SG1vOmrOhieIM5vLe73FydExzMlWklVi97E6mjHYg3OwTgzHU3E8dhtL YwUWwmgg1ZLK5A0ds0FWg3p+RJnL8UiGQxQpjJCqqaLzYKfHnUOqDBtOjh28YbPF AfFbfAtRImmPFNgSs2WoAbrf97Dc0CbFp1evkz2C59860o+4RSK7r0ewEkcLHjNS /BC/s+GQY9+E7sUj93EMpzaQzjlVyRWnIzhkrowFpMdwnLgRb08mYajthapQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1725621750; x=1725708150; bh=jqzRTI11U7DN9Yx3e6akrui4xFzX l6LR9YQs6dICVik=; b=kS1aVpvDBOQhzI5FotpodQyoDuSjvCpKNhokZWq7oTmI /qUFz82LB8GHNjy2kJ3nvXMg9p6NNrhzFVjuYYj5yeRk2O6csekMEjO+cbmJhg0V D6Uj53Q80gWuA3Ap1wjaWHn4L9W+1a1OSEUc+OZnwrrszhR9xyygxgJ1RqWg+NBL 84ZGrWkXF2yg6R0ge632f4laiMlWyEb1qNJh2+4PTSkf1744ByEUaDmOus7d02fk 3urDB49YRjMitIPSj57gX/30EHE0ECG9VWNJKEx0QSvCe6FuijouRVc0qp1KXO56 +htHMViuKBYAGxZGe8g/O8nHVRVCAlXEvujJ0CAFFA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudeiuddgfeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevuf gjfhffkfggtgesghdtreertddttdenucfhrhhomheptehlhihsshgrucftohhsshcuoehh ihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepieduffeuieelgfetgfdttd dtkeekheekgfehkedufeevteegfeeiffetvdetueevnecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehmrghilhhfrhhomhephhhisegrlhihshhsrgdrihhspdhnsggprh gtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehshhihmhgvghgr sehshhihmhgvghgrrdhorhhgrdhukhdprhgtphhtthhopeguvghvvghlsehsphgvtghtrh humhdqohhsrdhorhhg X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 6 Sep 2024 07:22:29 -0400 (EDT) Received: by sf.qyliss.net (Postfix, from userid 1000) id 5EE4D281B6E7B; Fri, 06 Sep 2024 13:22:28 +0200 (CEST) From: Alyssa Ross To: Dom Rodriguez Subject: Re: [PATCH] crosvm: Rename `--vhost-user-{fs,gpu}` args In-Reply-To: <20240906093430.1168464-1-shymega@shymega.org.uk> References: <20240906093430.1168464-1-shymega@shymega.org.uk> Date: Fri, 06 Sep 2024 13:22:26 +0200 Message-ID: <87msklgh71.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Message-ID-Hash: Y44XFQ2KVTNOBVNAZRRWEY2ZLSKJHFSC X-Message-ID-Hash: Y44XFQ2KVTNOBVNAZRRWEY2ZLSKJHFSC X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Dom Rodriguez writes: > crosvm was producing warnings when using `--vhost-user-gpu` and > `--vhost-user-fs`. > > In this commit, I have adjusted the `crosvm` invocations to look > something like `--vhost-user $DEVICE`, where `$DEVICE` is, in this case, > `gpu` or `fs`. > > I have run unit tests, but would appreciate testing. How did you run them? release/checks/wayland is failing: vm-test-run-spectrum-wayland> machine # [ 14.028205] crosvm[968]: [2024-09-06T11:19:20.132395456+00:00 ERROR crosvm] arg parsing failed: Error parsing option '--vhost-user' with value 'gpu': missing field `socket` vm-test-run-spectrum-wayland> machine # [ 14.029442] crosvm[968]: [src/main.rs:737] arg parsing failed: Error parsing option '--vhost-user' with value 'gpu': missing field `socket` Does it need to be (from memory) --vhost-user gpu,socket=path or something? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmba5fIACgkQ+dvtSFmy ccBcmw//YdBLG+XHNlSmyqi5vFeAd2XsYsyVX3JnYRPMSQYlGQwPdyHKavU8nx+X E935CJDdRFAxa/GWCVa6yf3DRsxECOy+iQAerNStrUT9M7oMmD1qjysMgK7zJ8GP hbL6FG4GaoCpYMGBVIWa3voS85j6g+rGa5Nbj9XcieAy90BlHgOTr4HBNvPUIXmn 3zQ7UhGmaNDaLtOoLTUMW79OJt28wPqqMX5XhBDqT2pFKXY8EsRD7eGY7s6claAH /Ho9egphZN2NY9AqgaEnYWulhWHvwwEo3F92UzeqaP3iTa84C4mhi0SB+vyo8Yx2 ZELF1Xaf6OrGbwQ0Gi+EL9P89stz5M9y4kQ4qOMJcTyIq7xQ/ItVjJ78s2s5MEE5 2ZtTI6ZHDK0o3kcsemnWBHP+zYGCKviP1q4fLdMYQy15429Foz6ZfuC095kT/fEA Z2Ej4q7777rFHvg/7uVxA24LdoNmGHMdF4ln4XbS5TehxuMffMWNphYuM3mNDmM3 SwojkdmTNJyOanirds7xVBtx3Yro3jZk8x/99Mb44iba2vc1ig4AMoCNnPAL7wos xVcNRDjhciOqddtP0Hs9oak18nc/4nxfhPDgaq/pKNFneXKnd1k1T871/SAEdauR HDLeVfP3YLVIm81I4F3bUlTxgegRsTBXkidmoqYBXJv7ZVL2v/g= =yfJ8 -----END PGP SIGNATURE----- --=-=-=--