Re: [PATCH] crosvm: Rename `--vhost-user-{fs,gpu}` args

Dom Rodriguez
2024-09-07T08:02:15Z

[-- Attachment #1: Type: text/plain, Size: 1574 bytes --]

On 06.09.2024 13:22, Alyssa Ross wrote:
>Dom Rodriguez <shymega@shymega.org.uk> writes:
>
>> crosvm was producing warnings when using `--vhost-user-gpu` and
>> `--vhost-user-fs`.
>>
>> In this commit, I have adjusted the `crosvm` invocations to look
>> something like `--vhost-user $DEVICE`, where `$DEVICE` is, in this case,
>> `gpu` or `fs`.
>>
>> I have run unit tests, but would appreciate testing.
>
>How did you run them? release/checks/wayland is failing:
>
>vm-test-run-spectrum-wayland> machine # [ 14.028205] crosvm[968]: [2024-09-06T11:19:20.132395456+00:00 ERROR crosvm] arg parsing failed: Error parsing option '--vhost-user' with value 'gpu': missing field `socket`
>vm-test-run-spectrum-wayland> machine # [ 14.029442] crosvm[968]: [src/main.rs:737] arg parsing failed: Error parsing option '--vhost-user' with value 'gpu': missing field `socket`
>
>Does it need to be (from memory) --vhost-user gpu,socket=path or something?

I thought I had tested them, but as it turned out, the command I used
was only for shellcheck. I've run unit tests again, and all seems to
pass. I've queued up the v2 patch for review.

Just a side note from my article about Flakes - we could use the
`checks` output to run on the `pre-commit` Git hook. This could then
check the commit message, run tests, etc.

That way we can catch these sort of mistakes before they even make it to
the mailing list.

But that's a digression - I think it'd be a good idea long-term though.

Best wishes,
--
Dom Rodriguez
GPG Fingerprint: EB0D 45E6 D0DC 1BA1 A2B5 FC24 72DC F123 1E54 BD43

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]