Re: [PATCH] crosvm: Rename `--vhost-user-{fs,gpu}` args

Alyssa Ross
2024-09-06T11:22:37Z

[-- Attachment #1: Type: text/plain, Size: 890 bytes --]

Dom Rodriguez <shymega@shymega.org.uk> writes:

> crosvm was producing warnings when using `--vhost-user-gpu` and
> `--vhost-user-fs`.
>
> In this commit, I have adjusted the `crosvm` invocations to look
> something like `--vhost-user $DEVICE`, where `$DEVICE` is, in this case,
> `gpu` or `fs`.
>
> I have run unit tests, but would appreciate testing.

How did you run them? release/checks/wayland is failing:

vm-test-run-spectrum-wayland> machine # [ 14.028205] crosvm[968]: [2024-09-06T11:19:20.132395456+00:00 ERROR crosvm] arg parsing failed: Error parsing option '--vhost-user' with value 'gpu': missing field `socket`
vm-test-run-spectrum-wayland> machine # [ 14.029442] crosvm[968]: [src/main.rs:737] arg parsing failed: Error parsing option '--vhost-user' with value 'gpu': missing field `socket`

Does it need to be (from memory) --vhost-user gpu,socket=path or something?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]