patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Alyssa Ross <alyssa.ross@unikie.com>
To: Ivan Nikolaenko <ivan.nikolaenko@unikie.com>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH] EFI Loader: use correct arch suffix
Date: Thu, 29 Sep 2022 08:44:08 +0000	[thread overview]
Message-ID: <87mtair2nb.fsf@alyssa.is> (raw)
In-Reply-To: <87h70t83rt.fsf@alyssa.is>

[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]

Alyssa Ross <alyssa.ross@unikie.com> writes:

> Nixpkgs already has an unexposed mapping of Nixpkgs platforms to EFI
> architecture names[1], so it would be a shame to have to duplicate it
> ourselves.  What if instead, we moved that list somewhere accessible in
> Nixpkgs, like how Nixpkgs already exposes the Linux and QEMU names for
> architectures[2]?  Then we could just access stdenv.hostPlatform.efiArch
> or whatever in our Nix expressions, and so could Nixpkgs.
>
> I imagine that'd be a welcome (and small) Nixpkgs refactoring, and I'd
> gladly backport it to Spectrum's Nixpkgs immediately after it was
> accepted upstream.
>
> [1]: https://github.com/NixOS/nixpkgs/blob/68770d269df8d7d8c7deba87156f66b0f997c071/nixos/modules/installer/cd-dvd/iso-image.nix#L434-L445
> [2]: https://github.com/NixOS/nixpkgs/blob/68770d269df8d7d8c7deba87156f66b0f997c071/lib/systems/default.nix#L118

I've merged your Nixpkgs PR (#193175 for anybody following along at
home), and backported it to Spectrum's Nixpkgs as commit
5e6b4a3127b59be1c10e8e1ccf4b57db7ff3cca0.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

      reply	other threads:[~2022-09-29  8:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-27 10:56 [PATCH] EFI Loader: use correct arch suffix Ivan Nikolaenko
2022-09-27 11:17 ` Alyssa Ross
2022-09-29  8:44   ` Alyssa Ross [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtair2nb.fsf@alyssa.is \
    --to=alyssa.ross@unikie.com \
    --cc=devel@spectrum-os.org \
    --cc=ivan.nikolaenko@unikie.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).