From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 4037B80A12; Thu, 29 Sep 2022 08:44:24 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 5783B80A0B; Thu, 29 Sep 2022 08:44:22 +0000 (UTC) Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by atuin.qyliss.net (Postfix) with ESMTPS id 81F10809C9 for ; Thu, 29 Sep 2022 08:44:19 +0000 (UTC) Received: by mail-ed1-x52c.google.com with SMTP id e18so1015176edj.3 for ; Thu, 29 Sep 2022 01:44:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unikie.com; s=google; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date; bh=j0tu7cZmvmoxQCB1wTQj2XrYjLN5f9rsobgTx+2v6Gg=; b=AqaVfar3i18z211jpG93q5BlUvYuXX/IZDEr50gs94Q0FH6F8DJtC7CJ9oEo3ihIQO VAdDdiF7By9R+3n2OW+2hxwWUfNQe4LtIqP6lNoZZnBYBzutdW/+whvfMObK+dRxit15 sKc8nfwYNjtOF0tfMLLnVMDiQJIdRIfvq/F7aSscqUETmmFs2UgGBYzT+g8xqNDKRfFz iAZAZ5/Lku/fFXn2aE/vwIcGRFzg3QNuKg4c5df1DOIJJ7nbXIR8pYEpfJwntsbEEZOv 0nwYVxYzkECCHoSqwNeXSg3p+WZbiilIllG58C6pZTyJbDeaM2V1HFeyZ8x2nwg8l3Ka 3tMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date; bh=j0tu7cZmvmoxQCB1wTQj2XrYjLN5f9rsobgTx+2v6Gg=; b=YhzY8m4aACAnOOrqbCSH3sdjMPposZHMA+kcgKPJuCHclUWop4I7R0Mq13IbeXRpC5 L+5gSPll2MSuTMKowDtw5WVboVA2YXbNudcZKMlYOb4/g04h9z7wsQ3Lf9Lpi8AsANJb 8bt0qksRMA60rdFGxGz8POACo02TsWVvAebEc+HP9or/t96+UHIWPh3L4NgfjUe11uul m/Ln6YlX3x+Gu+E0qqbMzEk9CYB0Gq2AOhngNeyKLeCsbah1FzqnNwlg2lCKe7VvJ3vz V0c0HDkZ/+RUSUpAxV6kR80N1j1P9PNDpONZu1mDOESxa8seIKtK9BH3t/CuYEBHkkDC LlmA== X-Gm-Message-State: ACrzQf0YQBsxLixz2ND2/C1HBvnq/xbAnnifge9deVzv08t3NE5t/vMW lAqdkYd6HeEoeCTnTs/+FGEGFsW2C3HqL1Fm X-Google-Smtp-Source: AMsMyM6sMrHx4jH6e5jNVJUX6KMxSmLrlDbglCLKnpWvnxvFbmdxxikcrizVZz1CTqlWUnx3ZdjUrQ== X-Received: by 2002:aa7:c647:0:b0:458:2a49:b84c with SMTP id z7-20020aa7c647000000b004582a49b84cmr1387681edr.141.1664441055102; Thu, 29 Sep 2022 01:44:15 -0700 (PDT) Received: from x220.qyliss.net (p4feb786f.dip0.t-ipconnect.de. [79.235.120.111]) by smtp.gmail.com with ESMTPSA id r9-20020a17090609c900b0073d84a321c8sm3552799eje.166.2022.09.29.01.44.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 01:44:14 -0700 (PDT) Received: by x220.qyliss.net (Postfix, from userid 1000) id 495BF4D7; Thu, 29 Sep 2022 08:44:13 +0000 (UTC) From: Alyssa Ross To: Ivan Nikolaenko Subject: Re: [PATCH] EFI Loader: use correct arch suffix In-Reply-To: <87h70t83rt.fsf@alyssa.is> References: <20220927105649.2265480-1-ivan.nikolaenko@unikie.com> <87h70t83rt.fsf@alyssa.is> Date: Thu, 29 Sep 2022 08:44:08 +0000 Message-ID: <87mtair2nb.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Message-ID-Hash: KSUB77MZBD2RWZQSKD32I47LKDLUMFLJ X-Message-ID-Hash: KSUB77MZBD2RWZQSKD32I47LKDLUMFLJ X-MailFrom: alyssa.ross@unikie.com X-Mailman-Rule-Hits: header-match-devel.spectrum-os.org-0 X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1 CC: devel@spectrum-os.org X-Mailman-Version: 3.3.5 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Alyssa Ross writes: > Nixpkgs already has an unexposed mapping of Nixpkgs platforms to EFI > architecture names[1], so it would be a shame to have to duplicate it > ourselves. What if instead, we moved that list somewhere accessible in > Nixpkgs, like how Nixpkgs already exposes the Linux and QEMU names for > architectures[2]? Then we could just access stdenv.hostPlatform.efiArch > or whatever in our Nix expressions, and so could Nixpkgs. > > I imagine that'd be a welcome (and small) Nixpkgs refactoring, and I'd > gladly backport it to Spectrum's Nixpkgs immediately after it was > accepted upstream. > > [1]: https://github.com/NixOS/nixpkgs/blob/68770d269df8d7d8c7deba87156f66b0f997c071/nixos/modules/installer/cd-dvd/iso-image.nix#L434-L445 > [2]: https://github.com/NixOS/nixpkgs/blob/68770d269df8d7d8c7deba87156f66b0f997c071/lib/systems/default.nix#L118 I've merged your Nixpkgs PR (#193175 for anybody following along at home), and backported it to Spectrum's Nixpkgs as commit 5e6b4a3127b59be1c10e8e1ccf4b57db7ff3cca0. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmM1WtkACgkQ+dvtSFmy ccCr+g//T1eVdPwJIlpJiBkpcvFoKdfleb90gTIJsclnuRd7rY6CD9nlar+G6xKF 5obkMHThiDia5VikQn1hxtnlQoCJS9zxB2ahRdWVzKUW4dVbO1v0p0zZeMytBk0L TOTGl0RjxcNfJp8abllR+z7qRwMKiFz90sntuXBqX0cOTIosjPTDe13C3aicwXtK hD9EkiXs8yT5mC/Kx9R/HLL93Agg/ZblYYltYT6BamuKf9bo4hvfwx/ZMiU1ZXvs pd0e2HFxwvxvKhvFeyaPe0147c+BUnUBQzfrADRpwa8y2PPZzFVi1GCzup6s4hZ4 Osu75UPqHhK1qJ9M02pKbbB4CQgzWzuz8AxNE15wtCdvR3jdvbGdqgNbHfK/ykVT dpvLWfgAkx4q08nziEIkE2vcTlCfoBQ4DgDczzVZKVn65xeaZd9aU000Yjf8jrvQ p8oXiRujrqzSeokd3GvLgDUjvjHnkI9VjhOyIhb2E6WvRDHxXvSCSQOgn3We4uRz hfYYQ8Sq/abBkLMuvXiI2DQBilvmuBTjYp7k8H0NDyGeecpPgXghxf0ConGGykao 54ZZlQ6pS6h7wEgGu54i4QZ5pTbKTcMvcRVv9R85+urXFPRrQ/X5ePOifUgRJLB4 WLeJlXDQacyVdoKboMP9Wa1e+jUdF5i4lzd7yGWl5IhTXn4r6ac= =mGEQ -----END PGP SIGNATURE----- --=-=-=--