Re: [PATCH] EFI Loader: use correct arch suffix

Alyssa Ross
2022-09-29T08:44:24Z

[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]

Alyssa Ross <alyssa.ross@unikie.com> writes:

> Nixpkgs already has an unexposed mapping of Nixpkgs platforms to EFI
> architecture names[1], so it would be a shame to have to duplicate it
> ourselves. What if instead, we moved that list somewhere accessible in
> Nixpkgs, like how Nixpkgs already exposes the Linux and QEMU names for
> architectures[2]? Then we could just access stdenv.hostPlatform.efiArch
> or whatever in our Nix expressions, and so could Nixpkgs.
>
> I imagine that'd be a welcome (and small) Nixpkgs refactoring, and I'd
> gladly backport it to Spectrum's Nixpkgs immediately after it was
> accepted upstream.
>
> [1]: https://github.com/NixOS/nixpkgs/blob/68770d269df8d7d8c7deba87156f66b0f997c071/nixos/modules/installer/cd-dvd/iso-image.nix#L434-L445
> [2]: https://github.com/NixOS/nixpkgs/blob/68770d269df8d7d8c7deba87156f66b0f997c071/lib/systems/default.nix#L118

I've merged your Nixpkgs PR (#193175 for anybody following along at
home), and backported it to Spectrum's Nixpkgs as commit
5e6b4a3127b59be1c10e8e1ccf4b57db7ff3cca0.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]