From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.4 Received: by atuin.qyliss.net (Postfix, from userid 496) id 52A291BBCE; Fri, 2 Apr 2021 15:55:16 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 4DCF91BBB1; Fri, 2 Apr 2021 15:55:00 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 71A781BBAE; Fri, 2 Apr 2021 15:54:58 +0000 (UTC) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by atuin.qyliss.net (Postfix) with ESMTPS id 40D3A1BC39 for ; Fri, 2 Apr 2021 15:54:56 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 992255C0106; Fri, 2 Apr 2021 11:54:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 02 Apr 2021 11:54:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=SXKKzVZKVlKQREO+1FAbzPA8to OJGQQaOKB8mPIodH8=; b=psBOgPRoVUB+lpHpRb+O2PlTasvWkQGNt9di+OuSl0 0KCUd4EGgN3RSgnLKuWNqwdXdghAQ7hMVxiqPpfwnrP4jBpc20qRUgih+cSb9CD8 n6s4O2e7i/i7USf5nZtkxA5kjM8ZNGMd9QEZ9/G5fjgS4ec94O1va23/r6dZRYRC 46+iQcd5swvgRAUJpVMYu2GqKiDA0sP0KoNBr/fxVvwbYjiEeHR0NcnAaeNFSscc EZ2EID17B49Qh0H4O67awAn+RJetEppgPgGnOKxf+iM/OhgHiaigJ9xBkTzMu0I8 LGYRk4ucXT28mwByyewqny7CKsl9iyi0mmi9RESF4j7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=SXKKzV ZKVlKQREO+1FAbzPA8toOJGQQaOKB8mPIodH8=; b=VrK2rRzMjlNuTIHsdt8SYn u1FgMRQDNz+In+/DUEf+z+2qU6ZAGBDJ1TNG3J4ktB4t8IxWMHbD2yU1sSwyadE7 X0CJIq5eIdnDjGU4os3J77G2H/RTJDlh2hI3rKmDAW4gGzeic/zjbSZfAydrIBcb 5hXm+uuibypF6vlt78hSDG6Dxf92D+N7EFX5mfecsnSEv3ua0/J7JKI4hgSJLfdC vxhOPvfi2yxBM4MLTq66kKP9n/ZHBAoXZbjLISIthikkc+DhULpwB9uBNRcmTKqx HWbPWnl9tZGprgaYKAZ6T5rLVPuMRQQUFzuv9KYw3JrM9UP7d/lhXlkfpr7k9xCA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeiiedgledvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfggtgesghdtreertddttdenucfhrhhomheptehlhihsshgr ucftohhsshcuoehhihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepvdeuvd eivdehhfeikedtvddvhefgheffleevueeigffgtdffffeujedujeejkeejnecukfhppeej ledrvdefuddrvdegfedrvddtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehhihesrghlhihsshgrrdhish X-ME-Proxy: Received: from x220.qyliss.net (p4fe7f3c9.dip0.t-ipconnect.de [79.231.243.201]) by mail.messagingengine.com (Postfix) with ESMTPA id C62BC240065; Fri, 2 Apr 2021 11:54:54 -0400 (EDT) Received: by x220.qyliss.net (Postfix, from userid 1000) id 1BB044D3; Fri, 2 Apr 2021 15:54:54 +0000 (UTC) From: Alyssa Ross To: Jamie McClymont Subject: Re: [RFC PATCH 5/8] chromiumOSPackages.common-mk: disable clang-only warnings In-Reply-To: <0100017891d37b4d-f47bcb1b-a616-4aaa-967e-c242084f7ced-000000@email.amazonses.com> References: <20210402090042.2020627-1-jamie@kwiius.com> <0100017891d37b4d-f47bcb1b-a616-4aaa-967e-c242084f7ced-000000@email.amazonses.com> Date: Fri, 02 Apr 2021 15:54:51 +0000 Message-ID: <87mtug8ywk.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Message-ID-Hash: FKC5M34ZRR3RS7UT27ZWTKO4LF6SXEEB X-Message-ID-Hash: FKC5M34ZRR3RS7UT27ZWTKO4LF6SXEEB X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.1 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Jamie McClymont writes: > --- > pkgs/os-specific/linux/chromium-os/common-mk/default.nix | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Alyssa Ross Tested-by: Alyssa Ross > diff --git a/pkgs/os-specific/linux/chromium-os/common-mk/default.nix b/p= kgs/os-specific/linux/chromium-os/common-mk/default.nix > index cc72aab5d15..d617401138f 100644 > --- a/pkgs/os-specific/linux/chromium-os/common-mk/default.nix > +++ b/pkgs/os-specific/linux/chromium-os/common-mk/default.nix > @@ -64,7 +64,11 @@ stdenv.mkDerivation ({ > patchShebangs common-mk > '' + (lib.optionalString (!stdenv.cc.isClang) '' > substituteInPlace common-mk/BUILD.gn \ > - --replace '"-Wno-c99-designator",' "" > + --replace '"-Wno-c99-designator",' "" \ > + --replace '"-Wstring-compare",' "" \ > + --replace '"-Wstring-plus-int",' "" \ > + --replace '"-Wxor-used-as-pow",' "" \ > + --replace '"-Wunreachable-code-return",' "" > '') + postPatch; >=20=20 > nativeBuildInputs =3D [ gn pkgconfig python3 ninja ] ++ nativeBuildInp= uts; > --=20 > 2.31.1 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmBnPksACgkQ+dvtSFmy ccDkBQ//e4WLlxKMnsZipFMCUsQPSdFlSYk0jCBQSTtk9RQIgrpARxYZyHCWhZfW Uf8tlrYdYV7AjwWeEw2i9NMN+3umeN6IRssbINFlSUtPIOxTOQtLbb62GH5PBcg5 Q42xTHxVf39qO6sh0LcSyyldFYJasjjNDAOFLaKfIm7rSJI7qb1RVNaYmY+6yhxH NRMWMaXc/46J77goHPUK4bWfy+6wmYAaiROt0KPMSo2A4LTKpOfbz3kQb4a8asFk G6yQ3FUOEtvs8dwYpt0u3zV3TpQtqwW6C1JX9qOUOL/O+DpqHPyX5PnDJtEzqOL5 Giq3r97WaXZWHcPVxe3yhYtO1hUHJPygx9INg6KeovsNU2/IecBt2YXpM+SR4PSt Li8NWTiwuJcTFXHHwxHLwiA7NDHgpXzzMQ3SkrQ6UP0ljLr3nAPF8y9QG6BVbC7t VyGDXuim+fhrwy17H9K+EySa/Hb2lXhnthopG7WzV8jMGBH6J8XPkIEToT29E3IJ vKbvEwg7Zd50czaCRza3K8H9ljiB2cHGjF1e6CJoMwTr8Hxja5+/CnI8lfGLLmpP +6i+Ga0SP/3KBx5hYfTNirKcmOkg0Gv2YFBXONMI5KE4s3D+DKAe8XJaBOLnuXqq KH2qipuCHNVZ6KPogn6aQbWzcGZZGYTRA+4CnZNhNYWSOWkWY9w= =D8rm -----END PGP SIGNATURE----- --=-=-=--