From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 925F36009; Tue, 16 Dec 2025 09:55:27 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id B43675F75; Tue, 16 Dec 2025 09:55:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fhigh-b3-smtp.messagingengine.com (fhigh-b3-smtp.messagingengine.com [202.12.124.154]) by atuin.qyliss.net (Postfix) with ESMTPS id 122565F6D for ; Tue, 16 Dec 2025 09:55:23 +0000 (UTC) Received: from phl-compute-09.internal (phl-compute-09.internal [10.202.2.49]) by mailfhigh.stl.internal (Postfix) with ESMTP id 3CB617A017D; Tue, 16 Dec 2025 04:55:21 -0500 (EST) Received: from phl-frontend-01 ([10.202.2.160]) by phl-compute-09.internal (MEProxy); Tue, 16 Dec 2025 04:55:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1765878921; x=1765965321; bh=NolW2G8lw1 +XUToKiglZteJTKBsvfH/C/ZSnZYXA8ZU=; b=LXGuml6nm+mb82uL60hEI9FY9I qHPducrsRYUdo/NQw5iI565No4sP6TjS+bBUnEkz9S5aE0QyMrP02GJF+6bo5tHY ZH4ktOywEHCNgFq7SxMc3BVm6FLmoX6wlN7BcqAVe7xrLyM6fOAbY4lTR0oI0iTY QIYSg2Dzi9srUPSjpLGGbpno4Z4svjGEyd83avLUGzGUxnsACtQkd1ue1sKmE486 GBYxBWaB0yEkGo1K2tLjsLwm09cYg6Uaw2eSRXD0o1Jp1/GB45nguxiVbnipX/zF grD3QtZA+iFO8hCoyoIrA42X0ZkK5hiUs8yEbXPodZhc+Gi7hC91e8Cu7aGA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1765878921; x=1765965321; bh=NolW2G8lw1+XUToKiglZteJTKBsvfH/C/ZS nZYXA8ZU=; b=BHLmFKYyrIh47SKYR5Hfe45GSoThAfvqtVx2WM45Vr7MFgpakMz YOGD03ionbMQAJ2nx3yXBCUQ2x4Q2CZSQw8+wEcQIDoNhAh5jdFucHWv0d9mMN9I TZVAXRysA8TE22ZWGqVs4FNDQzcDdTAk5yZAb1EseL1lL8SKgr1ivS0a0z8ApGi1 mlrqH1z7pGltZD4NO96cN4zGd4g0gzf6MQoXPodGz915ZGK1b55Mg7QbHfCiDmXE oZOlRN7j2NCM7BumoZS1ck0W5ysIeIioR51yBqJKCJfw0Yl94alx+P7mQVnDml0e KOFMhOsCy1mXHQppqUXVfB/ZcewnOUaWZpg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdefleefjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufgjfhffkfggtgesghdtreertddtjeenucfhrhhomheptehlhihsshgrucft ohhsshcuoehhihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepteehvedugf ejgfehhfeijeduleekleejgedvkeeuuefhhfegvdevfeetveegteeinecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhephhhisegrlhihshhsrgdrih hspdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegu vghmihhosggvnhhouhhrsehgmhgrihhlrdgtohhmpdhrtghpthhtohepuggvvhgvlhessh hpvggtthhruhhmqdhoshdrohhrgh X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 16 Dec 2025 04:55:20 -0500 (EST) Received: by fw12.qyliss.net (Postfix, from userid 1000) id 364447C2D5D9; Tue, 16 Dec 2025 10:55:13 +0100 (CET) From: Alyssa Ross To: Demi Marie Obenour Subject: Re: [PATCH 1/2] host/rootfs: remove /proc/kcore bind mounts In-Reply-To: <3ef8f200-e265-4466-bff3-63fdee58a984@gmail.com> References: <20251215122707.116898-1-hi@alyssa.is> <3ef8f200-e265-4466-bff3-63fdee58a984@gmail.com> Date: Tue, 16 Dec 2025 10:55:11 +0100 Message-ID: <87o6nyycn4.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: NZDDIVUJXF7QSTR5AMQJFZR5VML45ENP X-Message-ID-Hash: NZDDIVUJXF7QSTR5AMQJFZR5VML45ENP X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Demi Marie Obenour writes: > On 12/15/25 07:27, Alyssa Ross wrote: >> Neither of these services run as root any more, so they don't have >> access to /proc/kcore any more regardless. (Also we don't have >> /proc/kcore on aarch64 so this previously errored there.) >>=20 >> Fixes: 62590b8 ("host/rootfs: Sandbox crosvm") >> Fixes: ec47d36 ("host/rootfs: Sandbox Cloud Hypervisor") >> Signed-off-by: Alyssa Ross >> --- >> .../service/vm-services/template/data/service/vhost-user-gpu/run | 1 - >> host/rootfs/image/usr/bin/run-vmm | 1 - >> 2 files changed, 2 deletions(-) >>=20 >> diff --git a/host/rootfs/image/etc/s6-linux-init/run-image/service/vm-se= rvices/template/data/service/vhost-user-gpu/run b/host/rootfs/image/etc/s6-= linux-init/run-image/service/vm-services/template/data/service/vhost-user-g= pu/run >> index b1f9bac..e063a82 100755 >> --- a/host/rootfs/image/etc/s6-linux-init/run-image/service/vm-services/= template/data/service/vhost-user-gpu/run >> +++ b/host/rootfs/image/etc/s6-linux-init/run-image/service/vm-services/= template/data/service/vhost-user-gpu/run >> @@ -40,7 +40,6 @@ bwrap >> --tmpfs /proc/irq >> --remount-ro /proc/irq >> --ro-bind /dev/null /proc/timer_list >> - --ro-bind /dev/null /proc/kcore >> --ro-bind /dev/null /proc/kallsyms >> --ro-bind /dev/null /proc/sysrq-trigger >> -- >> diff --git a/host/rootfs/image/usr/bin/run-vmm b/host/rootfs/image/usr/b= in/run-vmm >> index 0640239..e30b14c 100755 >> --- a/host/rootfs/image/usr/bin/run-vmm >> +++ b/host/rootfs/image/usr/bin/run-vmm >> @@ -113,7 +113,6 @@ bwrap >> --tmpfs /proc/irq >> --remount-ro /proc/irq >> --ro-bind /dev/null /proc/timer_list >> - --ro-bind /dev/null /proc/kcore >> --ro-bind /dev/null /proc/kallsyms >> --ro-bind /dev/null /proc/sysrq-trigger >> -- >>=20 >> base-commit: 6ceeb9b236cc50d2bba90068533ca1b7ff229c8b > > /proc/sysrq-trigger and /proc/timer_list can also be dropped, > as they are not accessible to unprivileged users. And what about the others? I see systemd just makes them all read-only =E2=80=94 is that only to protect against root? Do we still need to hide /proc/sys, /proc/scsi, /proc/acpi, /proc/fs, and /proc/irq? The only entry I see that's writable by non-root in any of those on my NixOS system is /proc/sys/kernel/ns_last_pid, which doesn't look very harmful=E2= =80=A6 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQQGoGac7QfI+H5ZtFCZddwkt31pFQUCaUEsfwAKCRCZddwkt31p FeaZAP9qw9qCTO3skhMnGbFfXQrwjOX5hRl20HkSszWV7RCP5AD/b2FrnFZUxF0t l8jnuMOADHTDuK3FD+doqqfyWViBzwY= =9tUx -----END PGP SIGNATURE----- --=-=-=--