From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 026101ED57; Thu, 13 Nov 2025 12:29:04 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 2040E1ED38; Thu, 13 Nov 2025 12:29:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fhigh-a2-smtp.messagingengine.com (fhigh-a2-smtp.messagingengine.com [103.168.172.153]) by atuin.qyliss.net (Postfix) with ESMTPS id 3171D1ED36 for ; Thu, 13 Nov 2025 12:29:00 +0000 (UTC) Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfhigh.phl.internal (Postfix) with ESMTP id 0146614001B0; Thu, 13 Nov 2025 07:28:59 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Thu, 13 Nov 2025 07:28:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1763036938; x=1763123338; bh=NqFhxdsJ6d v34SqqnPh6VxM025nlewdc19kjrgvRr/o=; b=ddGim3JqIULMs9wtm9vCTxFfPp e08UKnG3wkB0wcDAKNo97X0aJPpkRRL7wLYJj46m/i1+oOEEb7HwbjBFn5naPhgu Eyt7BQlz1uaoBq4hbRyKbGlvo3vRGpRcoMvFcqhdfK4LrNW3uX7GZFJ3WKzCvIq0 lFjNb0F4GMS7rm2kNutxjy1C4YiCUdlpDN4nawaG2hnLyfK6habYNv8kOscVnrsW bXVBn6NFe9rdif+2+MJOQePPd9D/n3m239HP/gQEiRxfDU+VrUURkgX6vNRQIibB eWyDu0PdWaD2iGpgZvU9u2fee4M7Cypw+APYfEfnonhSSMNhQVcMvS9K8tgw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1763036938; x=1763123338; bh=NqFhxdsJ6dv34SqqnPh6VxM025nlewdc19k jrgvRr/o=; b=JEO6N/mUr/ZlCpMUt2yKV71cmREJd/lFUdORwihBhaSwk/afgVD H6HTt6CIx7AfQexBkhVivJe0oUlTdr3EJJjU8+qEbtFYzIGzliCHZRxoGerykv68 pcKtYDhCHD87i+yzWoA63DrhAVgPV7BOOjj559v5QMKPW6c6zh5m8BlHt6J6Twsu 3TuNkKwRwhihKae6/ZHSpedcZtmveDxyhtamTPThe6aQenRScu6Oy/qJPqXZBUZ5 R53VqqOqpuo0iBqNjjDL1D1xvnQIjgJx/EwUlm5ctSosFULBmOk6p4XGbL+b+QrJ AtrhHlwh2fSUNA73kgpVF6ytaNvFzHM1XEg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvtdeileegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefujghffffkgggtsehgtderredttddtnecuhfhrohhmpeetlhihshhsrgcu tfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeeiudffue eilefgtefgtddttdekkeehkefgheekudefveetgeefiefftedvteeuveenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehhihesrghlhihsshgrrd hishdpnhgspghrtghpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohep uggvmhhiohgsvghnohhurhesghhmrghilhdrtghomhdprhgtphhtthhopeguvghvvghlse hsphgvtghtrhhumhdqohhsrdhorhhg X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Nov 2025 07:28:58 -0500 (EST) Received: by mbp.qyliss.net (Postfix, from userid 1000) id 5F1986966DB9; Thu, 13 Nov 2025 13:28:57 +0100 (CET) From: Alyssa Ross To: Demi Marie Obenour Subject: Re: [PATCH 3/4] scripts/run-qemu.sh: Preserve ,, in QEMU arguments In-Reply-To: <20251107-simple-sh-quote-fix-v1-3-5f2d35260c4d@gmail.com> References: <20251107-simple-sh-quote-fix-v1-0-5f2d35260c4d@gmail.com> <20251107-simple-sh-quote-fix-v1-3-5f2d35260c4d@gmail.com> Date: Thu, 13 Nov 2025 13:28:56 +0100 Message-ID: <87o6p6glpz.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: AYH4HW5CB3CKEYQWY2WVFIO4T4FVBD4Q X-Message-ID-Hash: AYH4HW5CB3CKEYQWY2WVFIO4T4FVBD4Q X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Spectrum OS Development X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Demi Marie Obenour writes: > QEMU allows commas in option values to be escaped by doubling them. > Therefore, doubled commas should be preserved by scripts/run-qemu.sh. > > Signed-off-by: Demi Marie Obenour > --- > scripts/run-qemu.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This makes all the tests fail: qemu-system-aarch64: -machine ,virtualization=3Don,accel=3Dtcg: Invalid par= ameter '' > diff --git a/scripts/run-qemu.sh b/scripts/run-qemu.sh > index ab324d8fda0810516cb2180d1372bbeb546f52bc..14c58729dfceb3a0d2566fcfe= 076d6c10433419f 100755 > --- a/scripts/run-qemu.sh > +++ b/scripts/run-qemu.sh > @@ -64,7 +64,7 @@ while [ "$i" -lt "$#" ]; do > ;; > esac >=20=20 > - arg=3D"$arg${arg:+,}$opt" > + arg=3D"$arg,$opt" > done > unset IFS >=20=20 > > --=20 > 2.51.2 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRV/neXydHjZma5XLJbRZGEIw/wogUCaRXPCAAKCRBbRZGEIw/w oqJ8AQCI+fYNcs/26e/L4M6zNXEvo79zBRTOTRUwSfrA9uc2uQEAqUAYNoqqrRXB c6bvwhElSw0TjytfqUQ76sC5x3LqyAQ= =J1Vn -----END PGP SIGNATURE----- --=-=-=--