From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 6513FD10D; Tue, 23 Sep 2025 16:18:17 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 42E72D103; Tue, 23 Sep 2025 16:18:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fhigh-a1-smtp.messagingengine.com (fhigh-a1-smtp.messagingengine.com [103.168.172.152]) by atuin.qyliss.net (Postfix) with ESMTPS id 849F8D07B for ; Tue, 23 Sep 2025 16:18:13 +0000 (UTC) Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfhigh.phl.internal (Postfix) with ESMTP id 1B2961400103; Tue, 23 Sep 2025 12:18:12 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Tue, 23 Sep 2025 12:18:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1758644292; x=1758730692; bh=ZrwETHkpus onrjXmg1rpslwM7P/cA0ABC9wRwkQbeAc=; b=DnXyeEbrew4GlNI21Xl0v/qsn4 hyt1LljZMgnAcD+wLYFApVYGRYehFVYqsqgurWadKSqqi5ey/YFPrOtTM/KQD9JL 4p0kSFSYbxmRJr5+CegKmc5SQzZhcVjdB6zw2OvYqUzR1CTZF/K5ZV4H40T4424B GhjXraDY/V5Uu/AZYOHdfdcB1sSWk5XK/6XCk0qlSGV50BIVUe8icCS2sGG+1fsH 0YshN+UM7Q3QcjGkRoOQOvC1yWoCIec+kGj3ZmgBVy81094SxaUCEvVIYDG81X18 6yat2CfgiYjekxzZ1UMnLB4AFxIK+GWiLQYQMlMz3RbKphYUr7KT3meJuq9A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1758644292; x=1758730692; bh=ZrwETHkpusonrjXmg1rpslwM7P/cA0ABC9w RwkQbeAc=; b=XmNKUX/+zXfGM8q0AbgTcXXkR6i7vcBZ2uMA2UgsYNyDs2NpFuK dBQgMIQKIZvyXif5XZi7I8M1GkF1AIYIt+s2EhBdRAHpuxVETuT9eVHkUm9LVwBU JXvivN1NvHUHekrh0BNIZTVgWwi9uIDYCccY88IsxLoqanvx82Qx8ekdce505EDn HUqv+x28gjNmbQIUkzHTiLXXHRu5fPiERx42pjVl/Awxv2gGqEDTLCGYJ4Z/7WeO M6xkcC6dYGLTxXGScPJS6OBgKf6+yaPd66turSzpkVia79RDL4lka2wQ9qxo8A/T xz/w5z+jPJ3rZejEA1A0YDDwTnmayyr4IRQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdeiuddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecunecujfgurhephffvvefujghffffkgggtsehgtderredttd ejnecuhfhrohhmpeetlhihshhsrgcutfhoshhsuceohhhisegrlhihshhsrgdrihhsqeen ucggtffrrghtthgvrhhnpeetheevudfgjefghefhieejudelkeeljeegvdekueeuhffhge dvveefteevgeetieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehhihesrghlhihsshgrrdhishdpnhgspghrtghpthhtohepvddpmhhouggvpe hsmhhtphhouhhtpdhrtghpthhtohepuggvvhgvlhesshhpvggtthhruhhmqdhoshdrohhr ghdprhgtphhtthhopeihuhhkrgeshihukhgrrdguvghv X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 23 Sep 2025 12:18:11 -0400 (EDT) Received: by mbp.qyliss.net (Postfix, from userid 1000) id F295E24C7FE0; Tue, 23 Sep 2025 18:17:59 +0200 (CEST) From: Alyssa Ross To: Yureka Subject: Re: [PATCH v4 2/5] tools: add xdp-forwarder In-Reply-To: <25dd22ba-e501-4fa5-800c-6b3602bddfa4@yuka.dev> References: <20250923132012.28013-1-yureka@cyberchaos.dev> <20250923132012.28013-3-yureka@cyberchaos.dev> <87plbhurp5.fsf@alyssa.is> <3b730bf9-15f7-43c9-8ea7-4ebd20e9d3e5@yuka.dev> <87qzvxkwwv.fsf@alyssa.is> <25dd22ba-e501-4fa5-800c-6b3602bddfa4@yuka.dev> Date: Tue, 23 Sep 2025 18:17:59 +0200 Message-ID: <87o6r1kurs.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: BGLYYDGUFAIXIRLR3M4KOZXJF3OP273X X-Message-ID-Hash: BGLYYDGUFAIXIRLR3M4KOZXJF3OP273X X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Yureka writes: > On 9/23/25 17:31, Alyssa Ross wrote: >> Yureka writes: >> >>> On 9/23/25 17:14, Alyssa Ross wrote: >>>> Yureka Lilian writes: >>>>> @@ -88,12 +94,15 @@ stdenv.mkDerivation (finalAttrs: { >>>>> mesonFlags =3D [ >>>>> (lib.mesonBool "app" appSupport) >>>>> (lib.mesonBool "host" hostSupport) >>>>> + (lib.mesonBool "driver" driverSupport) >>>>> "-Dhostfsrootdir=3D/run/virtiofs/virtiofs0" >>>>> "-Dtests=3Dfalse" >>>>> "-Dunwind=3Dfalse" >>>>> "-Dwerror=3Dtrue" >>>>> ]; >>>>>=20=20=20=20 >>>>> + hardeningDisable =3D lib.optionals driverSupport [ "zerocallusedre= gs" ]; >>>>> + >>>> Could we instead do this in bpf_o_cmd, so it's not disabled for >>>> userspace programs? >>> This environment variable works on the stdenv level, so it is difficult >>> to mix it in from the meson recipe. Any way to do this would add NixOS >>> specifics to the meson recipe and doesn't feel quite right. >> The environment variable in stdenv just adds >> -fzero-call-used-regs=3Dused-gpr to the compiler flags, before the ones >> given on the command line, so I was thinking we could just add >> -fzero-call-used-regs=3Dskip (the default) to bpf_o_cmd, to explicitly s= ay >> we don't want it for these compiler invocations. It'll override the >> option given by the compiler wrapper, and won't do anything Nix-specific >> =E2=80=94 it would be the right thing for other distros that change comp= iler >> defaults as well, which I think is not that uncommon. > > Sadly this does not work, because passing -fzero-call-used-regs=3Dskip=20 > results in > > clang: error: unsupported option '-fzero-call-used-regs=3Dskip' for targe= t=20 > 'bpf' Ah okay, disabling the hardening is fine then. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRV/neXydHjZma5XLJbRZGEIw/wogUCaNLINwAKCRBbRZGEIw/w okfXAP426hgl2lMVWJRc25h3k3KLYXpulMdANMl35ctFol5QxgEA1YRmqWhnBHek KXBGkEeyqpAWwLAgkhovtCzAgRNfbQc= =WwvA -----END PGP SIGNATURE----- --=-=-=--