From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id DC39A110FE; Mon, 08 Dec 2025 17:29:19 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 6CA1B11108; Mon, 08 Dec 2025 17:29:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fhigh-a4-smtp.messagingengine.com (fhigh-a4-smtp.messagingengine.com [103.168.172.155]) by atuin.qyliss.net (Postfix) with ESMTPS id 01171110F5 for ; Mon, 08 Dec 2025 17:29:15 +0000 (UTC) Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfhigh.phl.internal (Postfix) with ESMTP id 54D491400209; Mon, 8 Dec 2025 12:29:13 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Mon, 08 Dec 2025 12:29:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1765214953; x=1765301353; bh=jaahuYgXG7 ysnFns6YS+Xe4OQdlmOjiM8sKS/AFuvYo=; b=ZGsaPqmPR36laJ02fvkJVcHWaA A+yvkmo4edazAUz6CwmVVHDiKVUgFtxAxoMiaH0WgoBx+DECMf+GMd/Bk46EcTbC 93HeO46Kp7z3V209KaHLnaHOT6qx6ZU3ktkhEzMnveATRdj6enXyfo2o60VN2eF0 nxdPfAfj9lLHDgtLX1bxucDtjCbOv1ARaxAW1fzL8H+y4sYHl0FNf4HSnhfkYID4 iRD33zBXXpLyJL7T1EesxO9NHf0UyImTONVZxtgV/cfcBdjNudmc8oOGdOCjsjoL G3ejwJRtdxJXBWv2y+Krq+a3YZl+oguEqB0r7byM2PT9auPzbtUbGmULK2RQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1765214953; x=1765301353; bh=jaahuYgXG7ysnFns6YS+Xe4OQdlmOjiM8sK S/AFuvYo=; b=xNoogSp89Vg/ek4UxcOv3La07HnQ2YbIKCt1VDsXmvhruYmfDzb RAmla5ATpf/yqfAZBfwx4qCQVFu9OXYPlRuPfcDoit+46Ggd8Qkho0GFPY2D4Jvl lAW7ec1ROFOC4sA576F1dTSPtY3fYniTVV1DFy52AWbggzdnoDkk+bTCbvu2dR0j nhAX6AHY+3CJ8VtRot7kdtu1zL/1KfQnZodZuZEup4w1tthLBTkBRKIRAZnB4jMF EpnOX6ZFw/JHu2eZsRbKhmtx/syt+DPswo0ZW2Q2ua82Wp2agLukvDL3aI1zvZLi bRVBpR32iKUiRA7NQbGvasITEqbKktVcIsw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddujedvkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufgjfhffkfggtgesghdtreertddtjeenucfhrhhomheptehlhihsshgrucft ohhsshcuoehhihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepheehgfetve fgfeevtdetueekgfehfeelueeutddtudeuiefhvdelleffheffhfegnecuffhomhgrihhn pehmrghtrhhigidrthhopdhfrghirhihughushhtrdhsphgrtggvpdhmrghtrhhigidroh hrghdpuggrthgrrghtuhhrshgvrhhvihgtvgdrshgvnecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehmrghilhhfrhhomhephhhisegrlhihshhsrgdrihhspdhnsggprh gtphhtthhopeefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopeguvghmihhosggv nhhouhhrsehgmhgrihhlrdgtohhmpdhrtghpthhtohepjhhohhgrnhhnvghsrdhsuhgvlh hlnhgvrhesmhgrihhlsghogidrohhrghdprhgtphhtthhopeguvghvvghlsehsphgvtght rhhumhdqohhsrdhorhhg X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 8 Dec 2025 12:29:12 -0500 (EST) Received: by fw12.qyliss.net (Postfix, from userid 1000) id B309B5A1FB39; Mon, 08 Dec 2025 18:29:01 +0100 (CET) From: Alyssa Ross To: Demi Marie Obenour Subject: Re: [PATCH] vm/app/systemd-sysupdate: fix mounting overlay In-Reply-To: References: <20251208154738.300709-1-hi@alyssa.is> Date: Mon, 08 Dec 2025 18:28:59 +0100 Message-ID: <87pl8olw6c.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: PJJRUYARKGCZFJCLA5VBPOYYDGTELVOX X-Message-ID-Hash: PJJRUYARKGCZFJCLA5VBPOYYDGTELVOX X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Johannes =?utf-8?Q?S=C3=BCllner?= , devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Demi Marie Obenour writes: > On 12/8/25 10:47, Alyssa Ross wrote: >> This assumed it would be run as root, so has been broken since we >> stopped running application scripts as root inside img/app VMs. >>=20 >> Reported-by: Johannes S=C3=BCllner >> Link: https://matrix.to/#/!xSysqhzbOZImdvGpix:fairydust.space/$9psDI3BIP= 00EIzW-qOqzJswkwzgYyQLKpbfDDp0uo6k?via=3Dfairydust.space&via=3Dmatrix.org&v= ia=3Ddataaturservice.se >> Fixes: 8bfcbf9 ("img/app: run applications as non-root") >> Signed-off-by: Alyssa Ross >> --- >> vm/app/systemd-sysupdate/download-update | 1 + >> 1 file changed, 1 insertion(+) >>=20 >> diff --git a/vm/app/systemd-sysupdate/download-update b/vm/app/systemd-s= ysupdate/download-update >> index eada41c..335e389 100755 >> --- a/vm/app/systemd-sysupdate/download-update >> +++ b/vm/app/systemd-sysupdate/download-update >> @@ -3,6 +3,7 @@ >> # SPDX-FileCopyrightText: 2025 Demi Marie Obenour >> export LC_ALL C >> export LANGUAGE C >> +unshare -rUm > > -r implies -U, and it would be more readable to use the long forms > of these options. > And yet mount -o and -t, and mktemp -d? (I can change it, but I have a general preference for short options to stop lines getting too long, and for portability when necessary.) >> if { mount -toverlay -olowerdir=3D/run/virtiofs/virtiofs0/etc:/etc -- o= verlay /etc } >> backtick tmpdir { mktemp -d /tmp/sysupdate-XXXXXX } >> # Not a useless use of cat: if there are NUL bytes in the URL --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQQGoGac7QfI+H5ZtFCZddwkt31pFQUCaTcK2wAKCRCZddwkt31p FX9oAQDgdlIeG13MpuXZPoirZtqVbHtzqWLEx+0KfPFIRJcIxwEAs+q+rW+ZhqLt VEzNZ87A9ONVVBZeCaiDNh/CbLh61QQ= =KqYW -----END PGP SIGNATURE----- --=-=-=--