patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Alyssa Ross <hi@alyssa.is>
To: "Johannes Süllner" <johannes.suellner@mailbox.org>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH] release/live: fix Makefile dependency being missing in Nix shell
Date: Sat, 06 Dec 2025 18:37:25 +0100	[thread overview]
Message-ID: <87pl8rjyui.fsf@alyssa.is> (raw)
In-Reply-To: <20251206141900.18119-1-johannes.suellner@mailbox.org>

[-- Attachment #1: Type: text/plain, Size: 664 bytes --]

Johannes Süllner <johannes.suellner@mailbox.org> writes:

> In commit a6d872ae, a Btrfs userdata partition was added to the live VM
> that can be startet with `make run`. The Makefile creates this partition
> and therefor requires `btrfs-progs`.

Thanks for the fix!  It needs a Signed-off-by for me to be able to take
it.  You can just include it in a reply this time if you want.

I also like to add a Fixes tag for this sort of thing, with the idea
that it's nice to collect the data about regressions about fixes.
Somebody will probably do some interesting analysis on them some day.

Fixes: a6d872a ("release/live: allow writes in "make run"")

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2025-12-06 17:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-06 14:18 [PATCH] release/live: fix Makefile dependency being missing in Nix shell Johannes Süllner
2025-12-06 17:37 ` Alyssa Ross [this message]
2025-12-06 18:30   ` [PATCH] release/live: fix a " Johannes Süllner
2025-12-06 18:51     ` Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pl8rjyui.fsf@alyssa.is \
    --to=hi@alyssa.is \
    --cc=devel@spectrum-os.org \
    --cc=johannes.suellner@mailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).