From: Alyssa Ross <hi@alyssa.is>
To: Dom Rodriguez <shymega@shymega.org.uk>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH v4] crosvm: Rename `--vhost-user-gpu` flag
Date: Sun, 10 Nov 2024 20:55:16 +0100 [thread overview]
Message-ID: <87pln27tjv.fsf@alyssa.is> (raw)
In-Reply-To: <20241108181450.1424488-1-shymega@shymega.org.uk>
[-- Attachment #1: Type: text/plain, Size: 780 bytes --]
Dom Rodriguez <shymega@shymega.org.uk> writes:
> crosvm was producing warnings when using `--vhost-user-gpu` and
> `--vhost-user-fs`, of which the former is fixable, but the latter
> requires some more work. The latter will be patched later on.
>
> To mitigate the former, I have adjusted the `crosvm` invocations to look
> something like `--vhost-user $DEVICE,socket=$PATH`, where `$DEVICE` is,
> in this case, `gpu`, and `$PATH` is the path to the Unix socket.
>
> Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
> ---
>
> The typo gremlins snuck into that last v3 patch, but hopefully v4 will
> fix it.
>
> img/app/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks!
There's also still the --vhost-user-gpu in
release/checks/wayland/default.nix.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2024-11-10 19:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 18:12 [PATCH v4] crosvm: Rename `--vhost-user-gpu` flag Dom Rodriguez
2024-11-10 19:52 ` Alyssa Ross
2024-11-10 19:55 ` Alyssa Ross [this message]
2024-11-11 1:35 ` Dom Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pln27tjv.fsf@alyssa.is \
--to=hi@alyssa.is \
--cc=devel@spectrum-os.org \
--cc=shymega@shymega.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).