From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 7962FDDA3; Sun, 10 Nov 2024 19:55:29 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 87D9FDD25; Sun, 10 Nov 2024 19:55:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DMARC_MISSING, RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fout-a7-smtp.messagingengine.com (fout-a7-smtp.messagingengine.com [103.168.172.150]) by atuin.qyliss.net (Postfix) with ESMTPS id 576FADD8A for ; Sun, 10 Nov 2024 19:55:22 +0000 (UTC) Received: from phl-compute-08.internal (phl-compute-08.phl.internal [10.202.2.48]) by mailfout.phl.internal (Postfix) with ESMTP id DCEFA13802C0; Sun, 10 Nov 2024 14:55:20 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-08.internal (MEProxy); Sun, 10 Nov 2024 14:55:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1731268520; x=1731354920; bh=y+Mro6EAqX g25mDKqKG8Ah7t4VHD8omn4SCcnKdU8wg=; b=bSaUbzI5xiUXSIDSA9N2l8bPv6 XJDLA2Dk4PJY29N6uDU8VasRtQn5rVqQRdzl1qtQqZ7haKBmLerlzUR9tfw8oD0H GaTGkFZOsNkcTf4LuiBg5yvgtyqzyUn4nRjPq0r8agNhVCEZnLTr4hLoRsOYPSes lQpUfEubOsHZ0fFIZmFL2WS7RqcpoJ2gdU8MGB8Fqe5mT/rrJjo/8Qmd5PfxemVM hZeNi6aSuvztih3Z2HjrnXyktZ6ASThOHOR+0fjWbrmW2d7Ibsxnd5T4ZzKu1Ypb wPLjnfdFbVvinlRjPa4Sk1T586lWlnbH6+CZLkOPBuiYt6txfE2MlfPMMruA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1731268520; x=1731354920; bh=y+Mro6EAqXg25mDKqKG8Ah7t4VHD8omn4SC cnKdU8wg=; b=nHjRBMZ2AoyaqMvJEphJ7QGNBgrzCJvXqqVopCrB0b6Kn51VlvU G4IVuBC45Yvy07BOx7m/9+zHDlllLr31Bhs8zntV28gJuBEGRYn4LN5gmBHjXJt6 dwKLtQZhXUpbvHHMCZdM2eLJ+tYxqsXlQoMJIybi+cU0yRFIB04UESB6yO8qTSy4 jd+nFzK+DBqoCc3Eu8DpLUteyhvNS1n0WZud7GsJTHaJj2ORiIYX0tADu0gg+vHK XD7Opj4GxgpQ2IFdgn4+6C+0Mgqhs6tMxmbahgF5E3Kd0Et/NxiFQKM3/DVN5cUK ML/HCPemueHfAza71c/Fnx8vPzsjHDt6mvA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddruddtgdduvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevuf gjfhffkfggtgesghdtreertddttdenucfhrhhomheptehlhihsshgrucftohhsshcuoehh ihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepieduffeuieelgfetgfdttd dtkeekheekgfehkedufeevteegfeeiffetvdetueevnecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehmrghilhhfrhhomhephhhisegrlhihshhsrgdrihhspdhnsggprh gtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehshhihmhgvghgr sehshhihmhgvghgrrdhorhhgrdhukhdprhgtphhtthhopeguvghvvghlsehsphgvtghtrh humhdqohhsrdhorhhg X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 10 Nov 2024 14:55:19 -0500 (EST) Received: by sf.qyliss.net (Postfix, from userid 1000) id 8E28D483552A8; Sun, 10 Nov 2024 20:55:17 +0100 (CET) From: Alyssa Ross To: Dom Rodriguez Subject: Re: [PATCH v4] crosvm: Rename `--vhost-user-gpu` flag In-Reply-To: <20241108181450.1424488-1-shymega@shymega.org.uk> References: <20241108181450.1424488-1-shymega@shymega.org.uk> Date: Sun, 10 Nov 2024 20:55:16 +0100 Message-ID: <87pln27tjv.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: SQMP2ROTRVLWFOG6HK2DUODUJASJ72LS X-Message-ID-Hash: SQMP2ROTRVLWFOG6HK2DUODUJASJ72LS X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Dom Rodriguez writes: > crosvm was producing warnings when using `--vhost-user-gpu` and > `--vhost-user-fs`, of which the former is fixable, but the latter > requires some more work. The latter will be patched later on. > > To mitigate the former, I have adjusted the `crosvm` invocations to look > something like `--vhost-user $DEVICE,socket=$PATH`, where `$DEVICE` is, > in this case, `gpu`, and `$PATH` is the path to the Unix socket. > > Signed-off-by: Dom Rodriguez > --- > > The typo gremlins snuck into that last v3 patch, but hopefully v4 will > fix it. > > img/app/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks! There's also still the --vhost-user-gpu in release/checks/wayland/default.nix. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRV/neXydHjZma5XLJbRZGEIw/wogUCZzEPpAAKCRBbRZGEIw/w ouXHAP0WSboqgjcyGkxBZ49tTGXsVl4Hg406QB0Unr11v3i7XgD/Tp2wucib2h6h VVO7/KbFOtRGFDf9aHpJu/qq6iF67QM= =CFJI -----END PGP SIGNATURE----- --=-=-=--