From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 13D40563; Fri, 10 Jul 2026 13:43:53 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id C82C626D; Fri, 10 Jul 2026 13:43:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fhigh-a2-smtp.messagingengine.com (fhigh-a2-smtp.messagingengine.com [103.168.172.153]) by atuin.qyliss.net (Postfix) with ESMTPS id 7F2B2269 for ; Fri, 10 Jul 2026 13:43:49 +0000 (UTC) Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfhigh.phl.internal (Postfix) with ESMTP id 9EFF914000FA; Fri, 10 Jul 2026 09:43:48 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Fri, 10 Jul 2026 09:43:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1783691028; x=1783777428; bh=2wnqqbPa4y 8SQZvqJ7jU22zsCJ/Q8yNJ7XPncsmhiU8=; b=pbk8gZvxmrx6LegTdTMIoHmMRp yZkuHqzHUD/IZ+H/L04ewEGjiMtbEyFFEHaz+k5ls69DL7kKenaH5AyFLTh1Xnb6 beXXaPoWC3ps8iymeOcUF0pxmEeKradIo9IzSM4ryyLWudinTnrshDNgr1FH0jlc PdXZsJ6b08qZzFKkMOM7xp2jBJGmvgchzPiORrPMXncbtUofyVLAYMTPD09ktvUw PJ9aCqKK/VvA2ZWAVMwbSv7e4Z5Is9KnvyVdWGsZO/aabmkE/xOYJIs2Qe344Opt rq34tEXk2CpqUZkfAsm9jDLAdkTRKzVBqTc0e+v3tkYdEWzo/HS3ZT+22w1Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1783691028; x=1783777428; bh=2wnqqbPa4y8SQZvqJ7jU22zsCJ/Q8yNJ7XP ncsmhiU8=; b=WA48HTdNcfreld8TpD/8o5a1bL4C8p1W8gDC6AkDxunQJzgpelU zj6mfnMHBmUzEEUPckEt6Ha6A+5a0MTH3wMtcHEGkuM94x6qxPV6bfcCn1xVYOej 7TRNZP3iO/x213e4eLD8ba7TgIBiTd/5PCDql6geRn/SvLqXLXfcV1IGAo2k4hjB hRziBe7CuwqFbqeMex/sjVtVYEwjT0SosYrtYF6DHFCMdx/C42mftL+YTnr2XxrV DbEDYQgkdK8tfMehTt/w5ZzzGQhkDSJzLxCptqOkSwKg8kRSoUm26UZttDP6tAQ8 TUbR6VoZ2mREcgBcRdktpcV+MbSkN+U5YMg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFNFyjpYsDvWlFy+2vWp1oauZejD63DXkEI6nmPwCXXDIdQBOF5NLRu+ffD/HtDey DE+fnL4KVuXyhOMHPqcJpRhIkHa8XCQba6mSxOO44eNNaoXzLO0wNq70IhiJj5cq+VxhhH OzXez/NWMtI9pchcd7u2FZk2oqt5JP6aDfkKveRNTCChG3qJNauccPj3Jk1AQF7M2dP7U3 wNDEh4kbvDqq3+sqkGzEqlN8Ak5NiJaJseFxNpvhsuTzrAsMbVwLRxNoBsNHihF7zQ8KE7 ckMWlTFcL+DyZVcvo9p6P0xsFpss8ftUfD5S+WEJ6wHYZvOUQ6f5RZOGzp7/xVVj3P1zHP DmvrtfpuRCiwaXl4jdulG4+Cbq0+Y84W6CZa5RYcuPZPvIVRCtVcwL9203IaRcdsye9Kni htrlT8o/pQxgoAeGLtIwbBGIBrdiSKMTJ5o8XnTXtiIVkY8uXt9FTSO976sWMaifrzAtwt n9XEkohdYtA8dNT7MUsb7k5favOqfAW2U9rn/FqyDx138W6sQ24nULdGNWRP97Odmbbd+8 dRaLQUl+N9TMpy87YiaJ5tebdbGt+BzW0+/cGM+EYQxfOgpG33D9a/lHbzN/1j62wuOtSr h42RTPvO84armgabK7no9NAjcE5IIM7dqtp+mjikj7+eXj/VEh9XXmgQQf/w X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 10 Jul 2026 09:43:48 -0400 (EDT) Received: by fw12.qyliss.net (Postfix, from userid 1000) id 0D98CC15E9F2; Fri, 10 Jul 2026 15:43:45 +0200 (CEST) From: Alyssa Ross To: Demi Marie Obenour Subject: Re: Duplicated VM start and shutdown code In-Reply-To: References: Date: Fri, 10 Jul 2026 15:43:43 +0200 Message-ID: <87qzlb9cz4.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: BEY2O7Q6ZVCXIAEQZBBQOQFVZYOU643B X-Message-ID-Hash: BEY2O7Q6ZVCXIAEQZBBQOQFVZYOU643B X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Spectrum OS Development X-Mailman-Version: 3.3.10 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Demi Marie Obenour writes: > I noticed that vm-import, run-appimage, and run-flatpak all have the > same code to start a VM, and run-flatpak and run-appimage both have > the same code to shut down a VM. Is this intentional, or should it > be replaced with common code? Yes, it probably should. But it is sort of intentional =E2=80=94 sometimes= I'm not sure exactly which parts should be shared, so I leave code duplicated for a while with the idea that it'll become more clear what the common core should be over time. (It usually works out.) Without a good understanding, it's easy to deduplicate too much, and end up with something that isn't flexible enough down the line, and then it has to be un-deduplicated again. Happy for you to try deduplicating it if you think you have a good idea of where to draw that line, but otherwise it's also fine for it to stay duplicated for now. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQQGoGac7QfI+H5ZtFCZddwkt31pFQUCalD3EAAKCRCZddwkt31p FUEjAQCT0DXgmv1xFRZ3CCC9sHx+VAbMKpUCRN1RNjMRHcBGGQD+JpaAVGzb91Kp MBq3kXEyd4cOUDZW8wzXuHcrfU8U3gs= =CPDy -----END PGP SIGNATURE----- --=-=-=--