From: Alyssa Ross <hi@alyssa.is>
To: Demi Marie Obenour <demiobenour@gmail.com>
Cc: Spectrum OS Development <devel@spectrum-os.org>
Subject: Re: [PATCH 4/4] scripts/run-qemu.sh: Unset variables from the environment
Date: Thu, 13 Nov 2025 13:27:18 +0100 [thread overview]
Message-ID: <87qzu2glsp.fsf@alyssa.is> (raw)
In-Reply-To: <20251107-simple-sh-quote-fix-v1-4-5f2d35260c4d@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 798 bytes --]
Demi Marie Obenour <demiobenour@gmail.com> writes:
> These could affect the script.
>
> Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
> ---
> scripts/run-qemu.sh | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
Makes sense.
> diff --git a/scripts/run-qemu.sh b/scripts/run-qemu.sh
> index 14c58729dfceb3a0d2566fcfe076d6c10433419f..ba32467956a509b1744ade461f2fe5f20ae7a5b9 100755
> --- a/scripts/run-qemu.sh
> +++ b/scripts/run-qemu.sh
> @@ -9,12 +9,15 @@ if [ -n ${ARCH+test} ]; then
> ARCH=$(uname -m)
> fi
>
> +unset kernel
> +
Would be clearer if this was attached to the for loop that actually sets
kernel, I think. Then as I reader I don't need to keep it in my head
for as long. (I can make this change and commit if you agree.)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2025-11-13 12:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-08 3:41 [PATCH 0/4] Minor improvements to scripts/run-qemu.sh Demi Marie Obenour
2025-11-08 3:41 ` [PATCH 1/4] scripts/run-qemu.sh: better error checks & formatting Demi Marie Obenour
2025-11-09 11:28 ` Alyssa Ross
2025-11-13 12:23 ` Alyssa Ross
2025-11-13 15:36 ` Demi Marie Obenour
2025-11-13 16:56 ` Alyssa Ross
2025-11-13 19:29 ` Demi Marie Obenour
2025-11-08 3:41 ` [PATCH 2/4] scripts/run-qemu.sh: decrease indentation Demi Marie Obenour
2025-11-08 3:41 ` [PATCH 3/4] scripts/run-qemu.sh: Preserve ,, in QEMU arguments Demi Marie Obenour
2025-11-13 12:28 ` Alyssa Ross
2025-11-13 15:36 ` Demi Marie Obenour
2025-11-13 19:30 ` Demi Marie Obenour
2025-11-08 3:41 ` [PATCH 4/4] scripts/run-qemu.sh: Unset variables from the environment Demi Marie Obenour
2025-11-13 12:27 ` Alyssa Ross [this message]
2025-11-13 19:30 ` Demi Marie Obenour
2025-11-14 11:22 ` Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87qzu2glsp.fsf@alyssa.is \
--to=hi@alyssa.is \
--cc=demiobenour@gmail.com \
--cc=devel@spectrum-os.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).