From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 3F77D1ECCF; Thu, 13 Nov 2025 12:27:25 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 0E24D1ECBC; Thu, 13 Nov 2025 12:27:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fout-a7-smtp.messagingengine.com (fout-a7-smtp.messagingengine.com [103.168.172.150]) by atuin.qyliss.net (Postfix) with ESMTPS id 64CCA1ECB4 for ; Thu, 13 Nov 2025 12:27:22 +0000 (UTC) Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfout.phl.internal (Postfix) with ESMTP id F16A1EC00FF; Thu, 13 Nov 2025 07:27:20 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Thu, 13 Nov 2025 07:27:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1763036840; x=1763123240; bh=5AslqGH7Ok 7aNi/eFmN52nXgypGbFAfVfMzxKhG3V7U=; b=Hlbn3SUazamWM3glmOzKfpjsd2 B6WdIpq60xhnWTPOGR25wzsYYqvn92bftgq1ibxbEfXBZjHMukKgnLCGw+m7dmtF kxmw5pHohfnk3WjntvSiV9wpBeKfu5K+o/yGmD2oy792nnsL9fKX+HvpWofcz4vl vkq86YMbezE+MM6VxxkKVhppBjSSl23s6mHMbTG3l5I3VU7xBPgoFSm6siAOTcO1 GQsQ7wQHdb+edrZkQAdHM+80wm8ztTR94t5FXsIhWUozwaWClVRUfx4GWlhmyyIR HIJHqk1hgon+yQaTdcN6H9fcQg5yaRJBw1hE4I8b25SODqjyIeM3owf/mZGQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1763036840; x=1763123240; bh=5AslqGH7Ok7aNi/eFmN52nXgypGbFAfVfMz xKhG3V7U=; b=zz6hxMEmL++8yFEVpyvPLU5zokxlCtan4fpXQPrCK9e8zOe7z/n o7s1ob7FLLtN6egAoY/wtSkl9pk1M09SWqujI2l9rqmmHNrzTAa9gi3/a17nz+lx nFmN1nAACUebUnGaft3JgkacWMyGOJRpu5L9kAWQwwPZS/pkMjM9B85MXXXCdPhJ ugD3Ckg4qJESoL1gDtZCjIfAglc5YaaRmmYL6zWSCxjI3NzdOVHvLeCMRIDgZ4uW cW8xI9YS1IWxzkSQUEmb0RPxU728hOV7wJosEl+tzGODE2m/RIqwWVhPzKnK6Ooy Ggk4sbY1LTq3/S1tWj21zKzQZjvA1KY4Rpg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvtdeileefucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefujghffffkgggtsehgtderredttddtnecuhfhrohhmpeetlhihshhsrgcu tfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeeiudffue eilefgtefgtddttdekkeehkefgheekudefveetgeefiefftedvteeuveenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehhihesrghlhihsshgrrd hishdpnhgspghrtghpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohep uggvmhhiohgsvghnohhurhesghhmrghilhdrtghomhdprhgtphhtthhopeguvghvvghlse hsphgvtghtrhhumhdqohhsrdhorhhg X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Nov 2025 07:27:20 -0500 (EST) Received: by mbp.qyliss.net (Postfix, from userid 1000) id 873516966D43; Thu, 13 Nov 2025 13:27:19 +0100 (CET) From: Alyssa Ross To: Demi Marie Obenour Subject: Re: [PATCH 4/4] scripts/run-qemu.sh: Unset variables from the environment In-Reply-To: <20251107-simple-sh-quote-fix-v1-4-5f2d35260c4d@gmail.com> References: <20251107-simple-sh-quote-fix-v1-0-5f2d35260c4d@gmail.com> <20251107-simple-sh-quote-fix-v1-4-5f2d35260c4d@gmail.com> Date: Thu, 13 Nov 2025 13:27:18 +0100 Message-ID: <87qzu2glsp.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: HZCSQTISYRLQFSS2RXZYYCH6J6CQMQLY X-Message-ID-Hash: HZCSQTISYRLQFSS2RXZYYCH6J6CQMQLY X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Spectrum OS Development X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Demi Marie Obenour writes: > These could affect the script. > > Signed-off-by: Demi Marie Obenour > --- > scripts/run-qemu.sh | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) Makes sense. > diff --git a/scripts/run-qemu.sh b/scripts/run-qemu.sh > index 14c58729dfceb3a0d2566fcfe076d6c10433419f..ba32467956a509b1744ade461= f2fe5f20ae7a5b9 100755 > --- a/scripts/run-qemu.sh > +++ b/scripts/run-qemu.sh > @@ -9,12 +9,15 @@ if [ -n ${ARCH+test} ]; then > ARCH=3D$(uname -m) > fi >=20=20 > +unset kernel > + Would be clearer if this was attached to the for loop that actually sets kernel, I think. Then as I reader I don't need to keep it in my head for as long. (I can make this change and commit if you agree.) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRV/neXydHjZma5XLJbRZGEIw/wogUCaRXOpgAKCRBbRZGEIw/w omeGAP4/aMEqacNZYyjsK48JYL9AzM3ogpN2EozZGYT9invEGAEA0I3CUS05JdwH 33b655mvW/oAqDlaj+ilXzQ9nvtdags= =+oGx -----END PGP SIGNATURE----- --=-=-=--