From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id DC5AC970D; Mon, 27 Jul 2026 12:20:50 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 499F99709; Mon, 27 Jul 2026 12:20:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fout-b7-smtp.messagingengine.com (fout-b7-smtp.messagingengine.com [202.12.124.150]) by atuin.qyliss.net (Postfix) with ESMTPS id A63CA9705 for ; Mon, 27 Jul 2026 12:20:48 +0000 (UTC) Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfout.stl.internal (Postfix) with ESMTP id 758611D001E5; Mon, 27 Jul 2026 08:20:47 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Mon, 27 Jul 2026 08:20:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1785154847; x=1785241247; bh=ncAduSGLu9 F5nrbjiZt5KrDpzJGFkF/RNZqROA0bOPk=; b=FMgv2QCCjZIy6VhdCfIdmXkIBv n0ONDMGKTtTipysfdE51vubQChBcGb64QFLTAMnpwfYGpbD2Wb+05EEmjyH4syB1 PggbSfXhEmPojSxVgh9Xlro19T/1aD27xoLKVK+0Mpj8mXeD2D+E9c40/VKcoh8P sJ4UWbb5t+GDPL4Zxj1Ym+M2pzFLz08W+kc6LdC1X2/uqmUYfD0SdoUE0ZVOwEpv GTIM0F+Fw+lkpX9LarFGSZ9vspIfWLLTvFdv5C/DAQjYDGLEr2lItJuMdnzeT0L8 5OLRiR3OBPOwyQsm1yrkqk3YkWp8o68i+z/drvgmpSvzbvmD+vrXXsyLLAQA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1785154847; x=1785241247; bh=ncAduSGLu9F5nrbjiZt5KrDpzJGFkF/RNZq ROA0bOPk=; b=rB6CMwk6PBZMXuFjJ/FIzXD/fBajRliMkVrGPv4Q6q1iG7h4izu CWeWHsBM2JWarBbIy/GCuZ/dvPTyLVAodZYhEBU72M+dff4LViR745r0vqMkeVoi 7ir3MIsy5upsOR4d41zIE7+y9wkKpkmN8KVO3OsVg8/B8Ee1eU4Z43PnTmqdOvf6 tyQBd2wEzzhNWZpJXFpI7WU5ltUAYfY/ZVmvmiaAP9zsSaYciiMVPtJ+metPKi8F ml+nWUNAbNzo57yrkRbF6c4Cm3refZOCpDHc6TqW4l44xeX6SDT8wvlghGwk2NpI WwAoZoDmBPbhLn6BFNkx/8lTOJhJawN/Vtg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGXP4jU7Ebg979q/prvspCwgWFae7HHpvj1tJQmrzInYwsCH77HFGApAHV9jyjxba 4XmW9wUakkJNcdlqJdsDPzSZhOlYXILXAGGnVx9afH8dBl6gZ1nHkcMk3VEhJxEzGa+VDk t0a9b2BM0Ascz5Q1zD61zZYQ+/MjQug6yOnVVxdyGlaJclw3neljwrnO0328+LIyFaTp++ kurNI2ybAq4zrd7W5oLlEbjKJlrbdofl1KN7usedbS5U9eWreKh2doLIMp4tKODxwuBXN+ B/8Y/f5+eewEUe05olHpPeCuL7ba2XuVQz/t6NoXV1oG+eKJgZZATmBV00GauH12IoK9j6 tIQ0dpBd6LntvDtkc6dpmnh4VpOwWnoBBRRGJ2gU1BF2rGm0Jf8UVPegvJ54J6d6BPpiE1 4kTgc06G8MNaBN319lo/qYSBUILJEd3utDYHQmLIvxZ80Sy4NjeBzcJ6zDJa4ZUg9febsP Mj+H2nq7VlIvOHMTEJbh1dR614cg3nMNs7IYAQmhgn5H5O6A+HSvLB2EjxQA86H/YgKVXZ lRm+QSGwtb/PTmbe17KMfN/Hg6j0Fbd3/b1RMKa6rwUwwjRedQBrCZQr/d7LkRNXsCBjfJ 0YKBm1hFm7S3vIwidF3fa0RyIqf/LiECNQjLKUFzB6bdPLfSVFy41SPp6qjQ X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 27 Jul 2026 08:20:47 -0400 (EDT) Received: by fw12.qyliss.net (Postfix, from userid 1000) id 1F1E7C4D7B40; Mon, 27 Jul 2026 14:20:46 +0200 (CEST) From: Alyssa Ross To: Demi Marie Obenour Subject: Re: [PATCH v4 18/20] host/rootfs: systemd-udevd: Run in cgroup In-Reply-To: <20260721-cgroups-v4-18-46b2e5fff7b6@gmail.com> References: <20260721-cgroups-v4-0-46b2e5fff7b6@gmail.com> <20260721-cgroups-v4-18-46b2e5fff7b6@gmail.com> Date: Mon, 27 Jul 2026 14:20:44 +0200 Message-ID: <87se54k4ir.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: Z7PGRJE7IIYI4LVTQA2W3TXDBU5UWA4H X-Message-ID-Hash: Z7PGRJE7IIYI4LVTQA2W3TXDBU5UWA4H X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Spectrum OS Development X-Mailman-Version: 3.3.10 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Demi Marie Obenour writes: > Signed-off-by: Demi Marie Obenour > --- > host/rootfs/file-list.mk | 1 + > host/rootfs/image/etc/s6-rc/systemd-udevd/finish | 5 +++++ > host/rootfs/image/etc/s6-rc/systemd-udevd/run | 5 +++-- > 3 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/host/rootfs/file-list.mk b/host/rootfs/file-list.mk > index e3411d40014342e67071a48f9e1c7bc7b3954bcf..065571ef3a5c61fa79a1d2ed878052a5f391be96 100644 > --- a/host/rootfs/file-list.mk > +++ b/host/rootfs/file-list.mk > @@ -106,6 +106,7 @@ S6_RC_FILES = \ > image/etc/s6-rc/systemd-udevd-coldplug/dependencies.d/systemd-udevd \ > image/etc/s6-rc/systemd-udevd-coldplug/type \ > image/etc/s6-rc/systemd-udevd-coldplug/up \ > + image/etc/s6-rc/systemd-udevd/finish \ > image/etc/s6-rc/systemd-udevd/notification-fd \ > image/etc/s6-rc/systemd-udevd/run \ > image/etc/s6-rc/systemd-udevd/type \ > diff --git a/host/rootfs/image/etc/s6-rc/systemd-udevd/finish b/host/rootfs/image/etc/s6-rc/systemd-udevd/finish > new file mode 100755 > index 0000000000000000000000000000000000000000..4d5b454e97c3584d0644c2d738514f13b1c53957 > --- /dev/null > +++ b/host/rootfs/image/etc/s6-rc/systemd-udevd/finish > @@ -0,0 +1,5 @@ > +#!/usr/bin/execlineb -WS3 > +# SPDX-License-Identifier: EUPL-1.2+ > +# SPDX-FileCopyrightText: 2026 Demi Marie Obenour > + > +cgroup-s6-finish $@ > diff --git a/host/rootfs/image/etc/s6-rc/systemd-udevd/run b/host/rootfs/image/etc/s6-rc/systemd-udevd/run > old mode 100644 > new mode 100755 > index aec6444e951503eae988e666b77fda8f2ae33d72..901f3e6667a8de04a6af39945406a1757455f089 > --- a/host/rootfs/image/etc/s6-rc/systemd-udevd/run > +++ b/host/rootfs/image/etc/s6-rc/systemd-udevd/run > @@ -1,7 +1,8 @@ > -#!/bin/execlineb -WP > +#!/bin/execlineb -WS1 > # SPDX-License-Identifier: EUPL-1.2+ > # SPDX-FileCopyrightText: 2025 Demi Marie Obenour > -s6-setlock /run/sd-notify-wrapper/systemd-udevd.lock > + > +cgroup-setup --delegate --child-name udev -- $1 > s6-ipcserver-socketbinder -b0 -m -a 0600 /run/sd-notify-wrapper/systemd-udevd.sock > background -d { > fdmove 1 3 > Is there a reason not to always enable delegation? Is there a reason we need to set the name here? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQQGoGac7QfI+H5ZtFCZddwkt31pFQUCamdNHAAKCRCZddwkt31p FQ+PAP9yYqRzDOzTxK2U7qhi+9IIHwM+hVDjzo6KTjh0BaXUVgEAuxwVbDs09vkX KoLaDIWmh18V3DYznrNBgncLjGwA6wY= =nti3 -----END PGP SIGNATURE----- --=-=-=--