Re: [PATCH 1/8] pkgs: fix aarch64-musl builds with current nixpkgs

[Alyssa Ross <hi@alyssa.is>]

[-- Attachment #1: Type: text/plain, Size: 2387 bytes --]

colbyt <colby@colbyt.com> writes:

> The newer nixpkgs pin exposes several aarch64-musl build issues in
> Spectrum dependencies.
>
> Normalize Python bootstrap outputs that install under usr/, patch the
> generated pyproject-build wrapper to include those paths, and keep the
> GnuTLS STARTTLS tests from observing a host /usr/bin/socat that is not
> on PATH.
>
> Also skip the exact psutil and mypy tests that depend on host network or
> unsandboxed root directory details. The remaining package test suites
> pass with those exact deselections.
>
> Signed-off-by: colbyt <colby@colbyt.com>

Unsandboxed builds on Linux are not commonly used, but they are still
supposed to work, so these fixes perhaps belong in upstream Nixpkgs.
They're unlikely to be specific to aarch64 or to musl.  (You will likely
save yourself a lot of future pain if you can find a way to run your
builds sandboxed though — not many other people will encounter these
issues.)

> ---
>  pkgs/overlay.nix | 105 +++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 105 insertions(+)
>
> diff --git a/pkgs/overlay.nix b/pkgs/overlay.nix
> index 3e3336e..66fea11 100644
> --- a/pkgs/overlay.nix
> +++ b/pkgs/overlay.nix
> @@ -4,12 +4,117 @@
>  (final: super: {
>    cloud-hypervisor = import ./cloud-hypervisor { inherit final super; };
>  
> +  coreutils = super.coreutils.overrideAttrs ({ postPatch ? "", ... }: (
> +    final.lib.optionalAttrs
> +      (super.stdenv.hostPlatform.isAarch64 && super.stdenv.hostPlatform.isMusl)
> +      {
> +        postPatch = postPatch + ''
> +          # These locale-sensitive tests fail in the aarch64-musl bootstrap build.
> +          for f in \
> +            tests/cut/mb-non-utf8.sh \
> +            tests/date/date-locale-hour.sh \
> +            tests/dd/conv-case.sh \
> +            tests/numfmt/mb-non-utf8.sh \
> +            tests/paste/multi-byte.sh \
> +            tests/sort/sort-h-thousands-sep.sh \
> +            tests/sort/sort-month.sh
> +          do
> +            sed '2i echo Skipping aarch64-musl locale test && exit 77' -i "$f"
> +          done
> +        '';
> +      }
> +  ));

I don't know what's up with this one though.  I build on aarch64 with
musl regularly and have never seen this problem.  Would be interesting
to know if it reproduces with sandboxing enabled.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]