From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id CE6DC8DB4; Wed, 26 Nov 2025 10:53:33 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 4ED948D53; Wed, 26 Nov 2025 10:53:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fout-b6-smtp.messagingengine.com (fout-b6-smtp.messagingengine.com [202.12.124.149]) by atuin.qyliss.net (Postfix) with ESMTPS id 3AA458D9C for ; Wed, 26 Nov 2025 10:53:28 +0000 (UTC) Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfout.stl.internal (Postfix) with ESMTP id 69FEF1D000EC; Wed, 26 Nov 2025 05:53:25 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-06.internal (MEProxy); Wed, 26 Nov 2025 05:53:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1764154405; x=1764240805; bh=h2dplNBBRB CdbSzXXYa3K3KJJYEj9NS6q42iKXY37bI=; b=GWumj3entHnRtTYnTO2Mc6l4LF u1Rr1ctXkCNPPAzkeGAyoEz4X/dN3HwR9vH5D4MeE1bEuGoFFahw5Tl4ByJz5sFT PNlyD6eSXPJmPNVbiFymNcEqTCGw0MZRJY0+gDA/9eAQeLxgzngnbZWNTrYvrEfG eWPSS25/ujxXw9KJ3w5mnD9N1XfCAYsZaHSs09mTKgmC0Xpfd7Xc4inmS8YmzVfT EHw5amtVHj9MJbVI7/7DRFnCOilXz6M8zRUQFes+QbO51KIN1hOy22ieui0GL+sx YcxnRSbDxCGo+j02cxT5F/zOLOTtFuNXp0fb4cBY2VBUFyL4BNfwyzZooMcg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1764154405; x=1764240805; bh=h2dplNBBRBCdbSzXXYa3K3KJJYEj9NS6q42 iKXY37bI=; b=MYKXWTZmM1RYR/w12wwl8aBJ44To1+PjOCkmslPFZZVUKkGBrkf b8dinfmNmRbzQl2JQLlSVNBSzrcP2qVEMZ0Nwx08jT3amjQRjnKwVGFVkjMtG264 7odhTv9u6F/W7xKRWz3MjiSKTXl1PAxnnIjatDJGlMRD+btGum0uQ2kp8JMH4bon suNX5yNzG9+wzXqIUNhkPzfiCI4GK+abrK9MdjuLCWGOe8L4DYwzl8NsLOBRREdi wcoUZKkHXqNACPFEEondoEfkG6elXDhfASpELL1pxt2TQFlmGN4OI/V2zN3ejpyi e8gE0aAxXj3ca/CubPNvPpo02NGCx8HYNvA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvgeegudeiucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefujghffffkgggtsehgtderredttdejnecuhfhrohhmpeetlhihshhsrgcu tfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeetheevud fgjefghefhieejudelkeeljeegvdekueeuhffhgedvveefteevgeetieenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehhihesrghlhihsshgrrd hishdpnhgspghrtghpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohep hihurhgvkhgrsegthigsvghrtghhrghoshdruggvvhdprhgtphhtthhopeguvghvvghlse hsphgvtghtrhhumhdqohhsrdhorhhg X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 26 Nov 2025 05:53:24 -0500 (EST) Received: by fw12.qyliss.net (Postfix, from userid 1000) id 210C4260F95D; Wed, 26 Nov 2025 11:53:08 +0100 (CET) From: Alyssa Ross To: Yureka Lilian Subject: Re: [PATCH v1 RFC 2/4] vm/sys/net: integrate xdp-forwarder In-Reply-To: <20251124163531.91029-3-yureka@cyberchaos.dev> References: <20251124163531.91029-1-yureka@cyberchaos.dev> <20251124163531.91029-3-yureka@cyberchaos.dev> Date: Wed, 26 Nov 2025 11:53:05 +0100 Message-ID: <87see1t69a.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: QQRCZSVYKL5GUERQOIHS3MXHCAY2FSLP X-Message-ID-Hash: QQRCZSVYKL5GUERQOIHS3MXHCAY2FSLP X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Yureka Lilian writes: > Signed-off-by: Yureka Lilian > --- > vm/sys/net/default.nix | 13 +++++++++---- > vm/sys/net/image/etc/fstab | 2 ++ > vm/sys/net/image/etc/mdev/iface | 27 ++++++++------------------- > vm/sys/net/image/etc/nftables.conf | 16 ++++++++++++---- > 4 files changed, 31 insertions(+), 27 deletions(-) Looks good. Just a couple of small questions. > diff --git a/vm/sys/net/default.nix b/vm/sys/net/default.nix > index c7ae88e..fd5bf08 100644 > --- a/vm/sys/net/default.nix > +++ b/vm/sys/net/default.nix > @@ -2,12 +2,12 @@ > # SPDX-FileCopyrightText: 2021-2023 Alyssa Ross >=20=20 > import ../../../lib/call-package.nix ( > -{ spectrum-build-tools, src, terminfo, pkgsMusl }: > +{ spectrum-build-tools, spectrum-driver-tools, src, terminfo, pkgsMusl }: We're taking this from the default package set, where it's built with Glibc =E2=80=94 presumably it should be built with musl like everything els= e in the VM? > diff --git a/vm/sys/net/image/etc/nftables.conf b/vm/sys/net/image/etc/nf= tables.conf > index 296d92c..cc8e462 100644 > --- a/vm/sys/net/image/etc/nftables.conf > +++ b/vm/sys/net/image/etc/nftables.conf > @@ -1,8 +1,16 @@ > # SPDX-License-Identifier: EUPL-1.2+ > -# SPDX-FileCopyrightText: 2021 Alyssa Ross > +# SPDX-FileCopyrightText: 2025 Yureka Lilian >=20=20 > -table nat { > - chain postrouting { > - type nat hook postrouting priority 100; > +table driver-fw { > + chain input { > + type filter hook input priority filter; policy drop; > + } > + > + chain output { > + type filter hook output priority filter; policy drop; > + } > + > + chain forward { > + type filter hook forward priority filter; policy drop; > } > } As someone with basically no netfilter experience, I'm surprised to not see a newline after a semicolon. Is that idiomatic for netfilter? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQQGoGac7QfI+H5ZtFCZddwkt31pFQUCaSbcEQAKCRCZddwkt31p FWe6AQCCRPnL3GSkysEaqiqeZhY72TBa1bk0yUo7/XJviN+7FQEAlHIsD+nC8MJ6 GhWUN19DpxckIwDkAnbzxaQrZPQIyQg= =M9BA -----END PGP SIGNATURE----- --=-=-=--